desktop-pwas: Clicking on in-scope links in the New Tab Page closes Chrome. |
|||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Get http://pokedex.org to appear in the New Tab Page (2) Click on it. What is the expected result? Tab should navigate to pokedex.org What happens instead? Chrome closes. Maybe clicking on in-scope links in the New Tab Page should open the app, but that's a separate issue.
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
,
Dec 6 2017
,
Dec 7 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f30d011a672ea5c20e47a4b08faa1d257f4dc10 commit 2f30d011a672ea5c20e47a4b08faa1d257f4dc10 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Dec 07 21:58:35 2017 desktop-pwas: Don't OpenInChrome navigations from New Tab Page to in-scope URLs Clicking on links in the New Tab Page results in the same type of navigation as launching an app. So, sometimes, we try to move the WebContents to a regular browser window even though the WebContents is in a regular browser window already. To solve this, check if we are in a browser window before moving the WebContents. Bug: 790773 Change-Id: I331c4b9c5d59d1e44d2e21d322ee2bfde6775f59 Reviewed-on: https://chromium-review.googlesource.com/802334 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521619}(cherry picked from commit b8b936ba50dcf5dc7b5ccefd8bab6a3606c9d3d1) Reviewed-on: https://chromium-review.googlesource.com/815574 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#79} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/2f30d011a672ea5c20e47a4b08faa1d257f4dc10/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/2f30d011a672ea5c20e47a4b08faa1d257f4dc10/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f3aaf1ddf31473413b88c3d3481521134f5be75 commit 1f3aaf1ddf31473413b88c3d3481521134f5be75 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Dec 08 00:10:27 2017 Revert "desktop-pwas: Don't OpenInChrome navigations from New Tab Page to in-scope URLs" This reverts commit 2f30d011a672ea5c20e47a4b08faa1d257f4dc10. Reason for revert: Breaks https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/2456 Original change's description: > desktop-pwas: Don't OpenInChrome navigations from New Tab Page to in-scope URLs > > Clicking on links in the New Tab Page results in the same type of > navigation as launching an app. So, sometimes, we try to move the > WebContents to a regular browser window even though the WebContents > is in a regular browser window already. > > To solve this, check if we are in a browser window before moving the > WebContents. > > Bug: 790773 > Change-Id: I331c4b9c5d59d1e44d2e21d322ee2bfde6775f59 > Reviewed-on: https://chromium-review.googlesource.com/802334 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#521619}(cherry picked from commit b8b936ba50dcf5dc7b5ccefd8bab6a3606c9d3d1) > Reviewed-on: https://chromium-review.googlesource.com/815574 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/branch-heads/3282@{#79} > Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} TBR=ortuno@chromium.org Change-Id: I609fd8c8a0eb09ea52c3053fb1fa3ac25cd01c94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790773 Reviewed-on: https://chromium-review.googlesource.com/816094 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#82} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/1f3aaf1ddf31473413b88c3d3481521134f5be75/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/1f3aaf1ddf31473413b88c3d3481521134f5be75/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/298fb263f122250540bcb69dcc00531f2e95bcba commit 298fb263f122250540bcb69dcc00531f2e95bcba Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Dec 08 04:02:32 2017 Reland "desktop-pwas: Don't OpenInChrome navigations from New Tab Page to in-scope URLs" This is a reland of 2f30d011a672ea5c20e47a4b08faa1d257f4dc10 Original change's description: > desktop-pwas: Don't OpenInChrome navigations from New Tab Page to in-scope URLs > > Clicking on links in the New Tab Page results in the same type of > navigation as launching an app. So, sometimes, we try to move the > WebContents to a regular browser window even though the WebContents > is in a regular browser window already. > > To solve this, check if we are in a browser window before moving the > WebContents. > > Bug: 790773 > Change-Id: I331c4b9c5d59d1e44d2e21d322ee2bfde6775f59 > Reviewed-on: https://chromium-review.googlesource.com/802334 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#521619}(cherry picked from commit b8b936ba50dcf5dc7b5ccefd8bab6a3606c9d3d1) > Reviewed-on: https://chromium-review.googlesource.com/815574 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/branch-heads/3282@{#79} > Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} Bug: 790773 Change-Id: I58197b1594b286fa99d69733b464c3f7f17959ca Reviewed-on: https://chromium-review.googlesource.com/816495 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#91} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/298fb263f122250540bcb69dcc00531f2e95bcba/chrome/browser/extensions/bookmark_app_navigation_throttle.cc [modify] https://crrev.com/298fb263f122250540bcb69dcc00531f2e95bcba/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
,
Dec 12 2017
Tested the issue on Mac 10.12.6, Windows 10 and Ubuntu 14.04 using Chrome version M64 - 64.0.3282.24 as per the issue mentioned in original comment. Observed that issue is working as intended (Upon navigating to the URL 'http://pokedex.org/' Chrome does not close and able to access the website). Hence adding TE-Verified label. Attached the screen cast for reference. Thank you!
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5 2017