New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790760 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Upgrade oauth2client in chromite third_party

Project Member Reported by nxia@chromium.org, Nov 30 2017

Issue description

Chromite third_party lib is importing oauth2client==1.5.2, the CL_Status_Viewer needs to use the library in oauth2client==4.1.2. Will need to resolve the conflicts by upgrading the third_party oauth2client to 4.1.2.

(env) nxia@nxia:~/chromiumos/infra/cl_status_viewer$ python cl_status_server_unittest.py 
Traceback (most recent call last):
  File "cl_status_server_unittest.py", line 14, in <module>
    import cl_status_server
  File "/usr/local/google/home/nxia/chromiumos/infra/cl_status_viewer/cl_status_server.py", line 15, in <module>
    from chromite.lib import cidb
  File "/usr/local/google/home/nxia/chromiumos/infra/cl_status_viewer/chromite/lib/cidb.py", line 18, in <module>
    from chromite.lib import clactions
  File "/usr/local/google/home/nxia/chromiumos/infra/cl_status_viewer/chromite/lib/clactions.py", line 14, in <module>
    from infra_libs import ts_mon
  File "/usr/local/google/home/nxia/chromiumos/chromite/third_party/infra_libs/__init__.py", line 5, in <module>
    from . import ts_mon  # Must be imported first so httplib2_utils can import it.
  File "/usr/local/google/home/nxia/chromiumos/chromite/third_party/infra_libs/ts_mon/__init__.py", line 5, in <module>
    from infra_libs.ts_mon.config import add_argparse_options
  File "/usr/local/google/home/nxia/chromiumos/chromite/third_party/infra_libs/ts_mon/config.py", line 17, in <module>
    from infra_libs.ts_mon.common import monitors
  File "/usr/local/google/home/nxia/chromiumos/chromite/third_party/infra_libs/ts_mon/common/monitors.py", line 17, in <module>
    from infra_libs import httplib2_utils
  File "/usr/local/google/home/nxia/chromiumos/chromite/third_party/infra_libs/httplib2_utils.py", line 22, in <module>
    from oauth2client import util
ImportError: cannot import name util

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2d4e192d5404d70e2709efa477ba37d46c6de762

commit 2d4e192d5404d70e2709efa477ba37d46c6de762
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Dec 08 11:59:19 2017

Catch the import error for oauth2client.util

chromite third_party and cl_status_viewer are using two different
oauth2client version, catch and ignore the import error in chromite
third_party.

BUG= chromium:790760 
TEST=run_tests

Change-Id: I2b4d18b4b7fb06b884d4329337192e9874a4149e
Reviewed-on: https://chromium-review.googlesource.com/802316
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/2d4e192d5404d70e2709efa477ba37d46c6de762/third_party/infra_libs/httplib2_utils.py

Comment 2 by nxia@chromium.org, May 18 2018

Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Status: WontFix (was: Untriaged)

Sign in to add a comment