[MD Extensions] Keyboard shortcut cards too wide? |
|||||||
Issue descriptionThey are currently set to 90% of the window's width, instead of having a fixed 680px like the details view and toolbar. See screenshots for proposal. @bettes: Should the cards be 680px to match the searchbox and the details view?
,
Dec 5 2017
,
Dec 11 2017
Alan says make them the same width as the search box.
,
Dec 12 2017
Candidate CL at https://chromium-review.googlesource.com/c/chromium/src/+/823075.
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58f4d5d39afe04260bf81bbf59dec733d5de08e7 commit 58f4d5d39afe04260bf81bbf59dec733d5de08e7 Author: dpapad <dpapad@chromium.org> Date: Tue Dec 12 23:14:00 2017 MD Extensions polish: Change shortcut card width. Bug: 790755 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9762cb10a50531f9e169ea16cf05d0ecd98c5534 Reviewed-on: https://chromium-review.googlesource.com/823075 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523595} [modify] https://crrev.com/58f4d5d39afe04260bf81bbf59dec733d5de08e7/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/58f4d5d39afe04260bf81bbf59dec733d5de08e7/chrome/browser/resources/md_extensions/keyboard_shortcuts.html [modify] https://crrev.com/58f4d5d39afe04260bf81bbf59dec733d5de08e7/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/58f4d5d39afe04260bf81bbf59dec733d5de08e7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html [modify] https://crrev.com/58f4d5d39afe04260bf81bbf59dec733d5de08e7/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
,
Dec 12 2017
I'll keep this bug open to also track what is mentioned at #1 (border-radius missing).
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69e1aec80c6dd883ed84e7ff297e877487793035 commit 69e1aec80c6dd883ed84e7ff297e877487793035 Author: dpapad <dpapad@chromium.org> Date: Wed Dec 13 03:45:27 2017 MD Extensios polish: Add border-radius for shortcut cards. Bug: 790755 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I853f3765273c34fbd057708c745b5bc807d8dc3b Reviewed-on: https://chromium-review.googlesource.com/822736 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523678} [modify] https://crrev.com/69e1aec80c6dd883ed84e7ff297e877487793035/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
,
Dec 13 2017
Tested the issue on Windows and Mac using Chrome# 65.0.3293.0. Attaching a screenshot for reference. Could some one please look into the screenshot and confirm whether this is the required behavior. Thanks in Advance.
,
Dec 13 2017
,
Dec 14 2017
Tested the issue on Windows, Mac & Linux using Chrome# 65.0.3294.0 & on Chrome OS (10212.0.0 dev-channel / Peppy Device) using Chrome# 65.0.3293.0 found the issue to be fixed. Hence adding TE-Verified labels accordingly. Thank You. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Nov 30 2017