New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790750 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

ChromeVox (spoken feedback) broken on startup / login

Project Member Reported by dtseng@chromium.org, Nov 30 2017

Issue description

- toggle ChromeVox on
- log in / or reboot

expected:
ChromeVox should be toggled on automatically

actual:
ChromeVox is not started; pref state might be correct, but ChromeVox is not loaded. Bad patch:

https://chromium-review.googlesource.com/c/chromium/src/+/777780


 

Comment 1 by dtseng@chromium.org, Nov 30 2017

Labels: -Pri-3 Pri-1
Owner: warx@chromium.org
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Status: assigned (was: Available)
Suggestion: please revert on m64 branch (including dependent changes) once m64 gets branched.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b77306ffe5cdb87601225e0c4b045fd1b78994

commit 51b77306ffe5cdb87601225e0c4b045fd1b78994
Author: Qiang(Joe) Xu <warx@chromium.org>
Date: Fri Dec 01 01:06:03 2017

Revert "mash: convert PlayEarcon/PlayShutdownSound through mojo call"

This reverts commit 09d525a9a5fb5da068a415342f9fe91b7cd267b8.

Reason for revert: revert for a clean revert of crrev.com/c/777780

Original change's description:
> mash: convert PlayEarcon/PlayShutdownSound through mojo call
> 
> changes:
> - Remove PlayEarcon/PlayShutdownSound from ash::AccessibilityDelegate.
>   Convert them calling into chrome through mojo call.
> - PlayShutdownSound gets shutdown sound duration asynchronously from
>   chrome in ash::AccessibilityController. Synchronize the real shutdown
>   timer's beginning when getting shutdown sound duration.
> 
> TBR=xiyuan@chromium.org
> 
> work when SpokenFeedbackEnabled is moved to ash. And add several test
> coverage.
> 
> Bug:  618070 
> Test: tested on device without --mash, it works fine. --mash should
> Change-Id: I82b3ce684983e3de658e8d165f90a47cf754f4f6
> Reviewed-on: https://chromium-review.googlesource.com/773629
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520441}

TBR=jamescook@chromium.org,xiyuan@chromium.org,dmazzoni@chromium.org,dtseng@chromium.org,tsepez@chromium.org,warx@chromium.org

Change-Id: I3673182425fa0cb4702036d326b83a275415d5de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  618070 ,  790750 
Reviewed-on: https://chromium-review.googlesource.com/802614
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520780}
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/BUILD.gn
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_controller_client.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_controller_client.h
[add] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_delegate.cc
[add] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/accessibility/test_accessibility_delegate.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/public/interfaces/accessibility_controller.mojom
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/test_shell_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client.h
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/accessibility/accessibility_controller_client_unittest.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/ash/volume_controller.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
[modify] https://crrev.com/51b77306ffe5cdb87601225e0c4b045fd1b78994/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0f6445956b48a297a938753cc65bbc79f16800a

commit a0f6445956b48a297a938753cc65bbc79f16800a
Author: Qiang(Joe) Xu <warx@chromium.org>
Date: Fri Dec 01 02:16:50 2017

Revert "mash: make ash learn/control SpokenFeedbackEnabled"

This reverts commit 6edaf9cba06e729ba295cfe3866c5b05dc18c4ca.

Reason for revert: revert for  crbug.com/790750 

Original change's description:
> mash: make ash learn/control SpokenFeedbackEnabled
> 
> changes:
> - Move Is{Toggle}SpokenFeedbackEnabled code to ash, which used to be
>   AccessibilityDelegate and called into chrome. This won't work in
>   mustash world. This change breaks the delegate way, by having prefs
>   in ash, the Is{Set} could be done in ash.
> - Change ToggleSpokenFeedbackEnabled to SetSpokenFeedbackEnabled to
>   align with other method names.
> 
> feedback enabled update the tray icon visibility. This is one step
> forward.
> 
> Bug: 594887
> Test: tested on emulator with --mash. Could see toggling spoken
> Change-Id: I3a9c4277f6d1e8bfb2b03777011f6f2f9055d296
> Reviewed-on: https://chromium-review.googlesource.com/777780
> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519898}

TBR=jamescook@chromium.org,xiyuan@chromium.org,warx@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 594887,  790750 
Change-Id: I29bb0871036990b8e72ff22897575825d3e1674d
Reviewed-on: https://chromium-review.googlesource.com/802615
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520804}
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accelerators/spoken_feedback_toggler.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accelerators/spoken_feedback_toggler_unittest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/accessibility_controller_unittest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/accessibility_delegate.h
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/default_accessibility_delegate.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/accessibility/default_accessibility_delegate.h
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/tray/system_tray.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/tray_accessibility.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/tray_accessibility_unittest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/a0f6445956b48a297a938753cc65bbc79f16800a/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc

Comment 5 by warx@chromium.org, Dec 1 2017

Status: Fixed (was: Assigned)
Fixed by reverting. Thanks!
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by warx@chromium.org, Dec 1 2017

Labels: -Merge-TBD
Both CLs are landed in 64.0.3282.0. No merge needed. Remove the label.
Cc: krajshree@chromium.org brajkumar@chromium.org dtseng@chromium.org ajha@chromium.org
 Issue 788300  has been merged into this issue.
Cc: dmazz...@chromium.org kathrelk...@chromium.org
 Issue 790983  has been merged into this issue.

Sign in to add a comment