New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790742 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

GAE ts_mon does not support Appengine Flex

Project Member Reported by pho...@chromium.org, Nov 30 2017

Issue description

Appengine flexible environment does not have the ndb API for datastore (see https://cloud.google.com/appengine/docs/flexible/python/migrating#datastore). https://chromium.googlesource.com/infra/infra/+/master/appengine_module/gae_ts_mon depends on ndb.

We have an Appengine app that requires the flexible environment which we would also like to emit metrics from ( http://crbug.com/789310 )

I'd like to change gae_ts_mon to use the vanilla datastore API to support using flexible appengine as well.
 

Comment 1 by no...@chromium.org, Nov 30 2017

Cc: vadimsh@chromium.org
it might be a way simpler to use default_memcache_policy https://cloud.google.com/appengine/docs/standard/python/refdocs/google.appengine.ext.ndb.context to disable memcache in ndb on flex

Comment 2 by pho...@chromium.org, Nov 30 2017

I was under the impression that google.appengine.ext wasn't importable in Google appengine flex. How would disabling memcache help?

Comment 3 by no...@chromium.org, Nov 30 2017

sorry, I misread the bug description. I thought the problem was that memcache is not available (it is not, too). FWIW we did something like very recently in Go, but our datastore wrapper library wasn't tied to classic appengine to memcache

Comment 4 by pho...@chromium.org, Nov 30 2017

Cc: akes...@chromium.org

Comment 5 by pho...@chromium.org, Jan 11 2018

Blocking: 800411
Blocking: -800411 -789310
Cc: sergeybe...@chromium.org
Status: Archived (was: Untriaged)
Looks like we'll be using raw ts-mon, so this isn't blocking anything anymore.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/5acf5c3227e337bb7124e09c9adbe1d58fa01f1e

commit 5acf5c3227e337bb7124e09c9adbe1d58fa01f1e
Author: Paul Hobbs <phobbs@google.com>
Date: Fri Apr 06 04:20:57 2018

main.py: Enable ts-mon setup

BUG= chromium:790742 
TEST=ran bin/local_server, presence/up metric prints to file and stdout

Change-Id: I5bdd19d847ed0e82e4294609e274d98b45b3f4c2

[modify] https://crrev.com/5acf5c3227e337bb7124e09c9adbe1d58fa01f1e/main.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/c3f8e7c4916cfbda0ff8be3bb55642dc353b34b7

commit c3f8e7c4916cfbda0ff8be3bb55642dc353b34b7
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Apr 12 18:22:12 2018

Add testing_utils.fake_datastore module

Pull out FakeDatastore into its own module.

BUG= chromium:790742 
TEST=Unit tests pass.

Change-Id: I48985cda56f886de7c7eb080383c011602bbe3c6

[modify] https://crrev.com/c3f8e7c4916cfbda0ff8be3bb55642dc353b34b7/exonerator/innocent_cls_test.py
[add] https://crrev.com/c3f8e7c4916cfbda0ff8be3bb55642dc353b34b7/testing_utils/fake_datastore.py
[add] https://crrev.com/c3f8e7c4916cfbda0ff8be3bb55642dc353b34b7/testing_utils/__init__.py

Sign in to add a comment