New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790734 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Network service: Need to pass NavigationUIData to URLLoader and retrieve it back

Project Member Reported by qin...@chromium.org, Nov 30 2017

Issue description

Offline page uses NavigationUIData to determine if MHTML page should be downloaded.

Without network service, NavigationUIData is passed in the ResourceRequestInfo, and will be updated by OfflineURLRequestJob.

With network service, we need something similar, passing it from NetworkUrlLoaderNetworkService, and pass it back when response body becomes available
 

Comment 1 by mmenke@chromium.org, Nov 30 2017

With the navigation service enabled, I don't think we'll still be able to use OfflineURLRequestJob - we'll need some other solution (Likely a separate URLLoaderFactory)

Comment 2 by jianli@chromium.org, Nov 30 2017

When do we expect to enable the navigation service?

Do you mean to have a separate URLLoaderFactory together with OfflinePageRequestJob or replace it? Any more info on this?

Comment 3 by mmenke@chromium.org, Nov 30 2017

I mean have a separate URLLoaderFactory, and a URLLoader.  The URLLoader would replace OfflinePageRequestJob.  It should hopefully be easy to turn OfflinePageRequestJob into a URLLoaderFactory.  The more challenging part is handling dispatching the request to the offline factory.

The goal is theoretically to have something ready for Windows canary around the start of Q3 next year.

And sorry, that should be "network service", not "navigation service".  To enable the network service, run Chrome with "--enable-features=NetworkService".
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment