New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 790699 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
█ xlai@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Canvas] Remove calls to virtual functions in CanvasResource* destructors

Project Member Reported by junov@chromium.org, Nov 30 2017 
Calling virtuals from a non-base class destructor is technically well-defined, but it is a bad pattern.  It will break if Derived classes get added.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faacc8509a53e4947fb8af4b629385f6c3b6c881

commit faacc8509a53e4947fb8af4b629385f6c3b6c881
Author: Justin Novosad <junov@chromium.org>
Date: Tue Dec 05 18:09:08 2017

Remove virtual calls from CanvasResource destructors.

BUG= 790699 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I432ad3103df1d07732b2629384dc074cb6002a21
Reviewed-on: https://chromium-review.googlesource.com/806692
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521741}
[modify] https://crrev.com/faacc8509a53e4947fb8af4b629385f6c3b6c881/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp
[modify] https://crrev.com/faacc8509a53e4947fb8af4b629385f6c3b6c881/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Comment 2 by junov@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment