Only top half of text rendering in submenus
Reported by
esavad...@forthepeople.com,
Nov 30 2017
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Example URL: https://www.classaction.com Steps to reproduce the problem: 1. Go to specified URL in 62.0.3202.94 on desktop (www.classaction.com) on either Mac OS or Windows 2. Open any of the dropdown menus (Products, Lawsuits, About) 3. Issue is apparent What is the expected behavior? Text renders correctly. What went wrong? Bottom half of text in the menus does not render. This does not occur in previous chrome versions nor in other browsers. Messing with the line-height, z-index or display properties briefly fixes the issue, but toggling the menu again results in the same issue. Does it occur on multiple sites: N/A Is it a problem with a plugin? N/A Did this work before? Yes 62.0.3202.75 Does this work in other browsers? N/A Chrome version: 62.0.3202.94 Channel: stable OS Version: OS X 10.13.0 Flash Version:
,
Nov 30 2017
,
Nov 30 2017
I can see this in 62.0.3202.94 (Official Build) (64-bit) on Mac.
,
Dec 1 2017
"Able to reproduce the issue on reported version 62.0.3202.75, latest Canary 64.0.3280.0 using Mac 10.13.1,Ubuntu 14.04 and Windows 10 Bisect Info: ================ Good Build: 62.0.3194.0 Bad Build: 62.0.3196.0 CHANGELOG URL: You are probably looking for a change made after 497208 (known good), but no later than 497217 (first known bad). https://chromium.googlesource.com/chromium/src/+log/90e1f73cd3d30f789e1865d2314980a8ff0374bb..d4efc5e1bec1e48b561f07cabc01e6f951462c67 suspecting: https://chromium.googlesource.com/chromium/src/+/aefc96a263607de266c5eaa542731ef80814598a Review URL: https://chromium-review.googlesource.com/613780 Suspecting same from changelog. @lindsayw: Please confirm the issue and help in re-assigning if it is not related to your change. Thanks! "
,
Dec 4 2017
I had to implement a workaround on our live site, but I kept the error on our staging site. URL for that is http://www-classaction-com.litify.staging.wpengine.com/
,
Dec 5 2017
Looks like paint invalidation to me. Hovering the menu items repaints them correctly. wangxianzhu@ could this be https://chromium.googlesource.com/chromium/src/+/1db10196d999bf95545aaa30da897e9eb6a26b60 ? (from bisect range)
,
Dec 5 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b36628a543143f75ebba66f852271c49a655dd0 commit 3b36628a543143f75ebba66f852271c49a655dd0 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Dec 13 02:06:10 2017 [PE] Don't ignore clip change not across transform boundary If the clip change is caused by the object having transform, we should not ignore the clip change because it actually affects descendants. Bug: 790560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 Reviewed-on: https://chromium-review.googlesource.com/822919 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523653} [add] https://crrev.com/3b36628a543143f75ebba66f852271c49a655dd0/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize-expected.html [add] https://crrev.com/3b36628a543143f75ebba66f852271c49a655dd0/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize.html [modify] https://crrev.com/3b36628a543143f75ebba66f852271c49a655dd0/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06f3193494518764f0a6300b3407af051039e266 commit 06f3193494518764f0a6300b3407af051039e266 Author: Victor Miura <vmiura@chromium.org> Date: Wed Dec 13 05:20:04 2017 Revert "[PE] Don't ignore clip change not across transform boundary" This reverts commit 3b36628a543143f75ebba66f852271c49a655dd0. Reason for revert: Suspect this broke the build. Unexpected Failures: * compositing/geometry/repaint-foreground-layer.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html * compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html * compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html * compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html * compositing/gestures/gesture-tapHighlight-img-and-text-2.html * compositing/gestures/gesture-tapHighlight-img-and-text.html * compositing/gestures/gesture-tapHighlight-pixel-rotated-link.html * compositing/gestures/gesture-tapHighlight-simple-cancel2.html * compositing/gestures/gesture-tapHighlight-simple-longPress.html * compositing/gestures/gesture-tapHighlight-simple-margin.html * compositing/gestures/gesture-tapHighlight-simple-multi-line.html * compositing/gestures/gesture-tapHighlight-simple-nested.html * compositing/gestures/gesture-tapHighlight-simple-scaledX.html * compositing/gestures/gesture-tapHighlight-simple-scaledY.html * compositing/gestures/gesture-tapHighlight-simple-window-scroll.html * compositing/gestures/gesture-tapHighlight-simple.html Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org Change-Id: Id760d5784db00715f5f16cd0eeed0cb4e2812688 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/822138 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#523695} [delete] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize-expected.html [delete] https://crrev.com/398adf6b070d1d7150763fe85ce3b06a557f97ba/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize.html [modify] https://crrev.com/06f3193494518764f0a6300b3407af051039e266/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94907aacd1d59c585850d897eb01432e72266550 commit 94907aacd1d59c585850d897eb01432e72266550 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Dec 13 06:51:50 2017 Reland "[PE] Don't ignore clip change not across transform boundary" This is a reland of 3b36628a543143f75ebba66f852271c49a655dd0 Fix crashes on release-without-DCHECK builds by adding check for contex.tree_builder_context before dereferencing it. Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} Bug: 790560 Change-Id: I2bc134f829aa38398cf87ad8fa89ac229634d6d0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/822139 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523703} [add] https://crrev.com/94907aacd1d59c585850d897eb01432e72266550/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize-expected.html [add] https://crrev.com/94907aacd1d59c585850d897eb01432e72266550/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize.html [modify] https://crrev.com/94907aacd1d59c585850d897eb01432e72266550/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
,
Dec 18 2017
,
Dec 18 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18 2017
I am trying to replicate this in Mac (M-63), but unable to do so. I'd like to make sure if this isn't already fixed in 63?
,
Dec 18 2017
It's not fixed in M-63. You couldn't reproduce the issue with the reported URL because the page author has modified the page to avoid this bug. You can reproduce with the URL in #c5 or the reduced test case in #c8.
,
Dec 18 2017
Seems like it's still reproducible on latest M63 Stable#63.0.3239.108 for Windows & Mac OS X per c#8.
,
Dec 18 2017
Approving for merge to M64. Branch:3282
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ff20441efc6e76417d13c8fdba85453a65e8d5b commit 8ff20441efc6e76417d13c8fdba85453a65e8d5b Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Dec 18 22:28:16 2017 Reland "[PE] Don't ignore clip change not across transform boundary" This is a reland of 3b36628a543143f75ebba66f852271c49a655dd0 Fix crashes on release-without-DCHECK builds by adding check for contex.tree_builder_context before dereferencing it. Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} TBR=wangxianzhu@chromium.org (cherry picked from commit 94907aacd1d59c585850d897eb01432e72266550) Bug: 790560 Change-Id: I2bc134f829aa38398cf87ad8fa89ac229634d6d0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/822139 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523703} Reviewed-on: https://chromium-review.googlesource.com/832940 Cr-Commit-Position: refs/branch-heads/3282@{#277} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [add] https://crrev.com/8ff20441efc6e76417d13c8fdba85453a65e8d5b/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize-expected.html [add] https://crrev.com/8ff20441efc6e76417d13c8fdba85453a65e8d5b/third_party/WebKit/LayoutTests/paint/invalidation/clip/clip-with-transform-resize.html [modify] https://crrev.com/8ff20441efc6e76417d13c8fdba85453a65e8d5b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
,
Dec 18 2017
,
Jan 19 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by esavad...@forthepeople.com
, Nov 30 2017