New issue
Advanced search Search tips

Issue 790557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 757737



Sign in to add a comment

Failure in audio_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1

Project Member Reported by piman@chromium.org, Nov 30 2017

Issue description

https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win7%20Release%20%28AMD%29/5837

failures:
WinAudioInputTest.WASAPIAudioInputStreamLoopback
WinAudioInputTest.WASAPIAudioInputStreamOpenStartStopAndClose
WinAudioInputTest.WASAPIAudioInputStreamOpenAndClose
WinAudioInputTest.WASAPIAudioInputStreamMiscCallingSequences
WinAudioInputTest.WASAPIAudioInputStreamTestPacketSizes
WinAudioInputTest.WASAPIAudioInputStreamCreateAndClose
WinAudioInputTest.WASAPIAudioInputStreamOpenStartAndClose


Suspecting https://chromium.googlesource.com/chromium/src/+/df64b29e17efa7aed791da9f93b573f2d5af68fc
 

Comment 1 by kbr@chromium.org, Nov 30 2017

Blocking: 757737
I was going to take audio_unittests off the GPU FYI bots altogether after discussion with dalecurtis@ and will follow through on that. In the interim I've reverted the above change in https://chromium-review.googlesource.com/801263 .

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f289287bf59a1b0be2723cf9cb20ab09a7319df4

commit f289287bf59a1b0be2723cf9cb20ab09a7319df4
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Nov 30 19:52:09 2017

Revert "Add WebRTC logging to Windows audio input implementation."

This reverts commit df64b29e17efa7aed791da9f93b573f2d5af68fc.

Reason for revert: Caused  http://crbug.com/790557  .

Original change's description:
> Add WebRTC logging to Windows audio input implementation.
> 
> Log failures in Open() and Start().
> 
> Bug:  757737 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Idaad68af9aabc753cb4fca17b2dfff3cdf69d83b
> Reviewed-on: https://chromium-review.googlesource.com/795727
> Commit-Queue: Henrik Grunell <grunell@chromium.org>
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520562}

TBR=grunell@chromium.org,maxmorin@chromium.org,marinaciocea@chromium.org

Change-Id: I54d97e5063d5a63325977ce19753d1e5439dd396
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  757737 ,  790557 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/801263
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520648}
[modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/audio_manager.h
[modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/f289287bf59a1b0be2723cf9cb20ab09a7319df4/media/audio/win/audio_manager_win.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9

commit 92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri Dec 01 14:11:38 2017

Re-land Add WebRTC logging to Windows audio input implementation.

Log failures in Open() and Start().

Previous (reverted) CL: https://chromium-review.googlesource.com/c/chromium/src/+/795727

Bug:  757737 ,  790557 
Change-Id: Idecad5ba1a692da1386823d30ce65462c9a05ff3
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/795727
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#520562}
Reviewed-on: https://chromium-review.googlesource.com/803219
Cr-Commit-Position: refs/heads/master@{#520930}
[modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/audio_manager.h
[modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9/media/audio/win/audio_manager_win.cc

Status: Started (was: Untriaged)
Waiting until bots have run before closing.
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4251ea30cd82b564d0d35b094c44b468eef5f9a7

commit 4251ea30cd82b564d0d35b094c44b468eef5f9a7
Author: Henrik Grunell <grunell@chromium.org>
Date: Wed Dec 06 08:15:37 2017

Re-land Add WebRTC logging to Windows audio input implementation.

Log failures in Open() and Start().

Previous (reverted) CL: https://chromium-review.googlesource.com/c/chromium/src/+/795727

Bug:  757737 ,  790557 
Change-Id: Idecad5ba1a692da1386823d30ce65462c9a05ff3
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/795727
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#520562}
Reviewed-on: https://chromium-review.googlesource.com/803219
Cr-Original-Commit-Position: refs/heads/master@{#520930}(cherry picked from commit 92b2a7c5cf9822eb0bda9a4c4340ecb86c0f5fe9)
Reviewed-on: https://chromium-review.googlesource.com/809427
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#52}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/audio_manager.h
[modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win.cc
[modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/4251ea30cd82b564d0d35b094c44b468eef5f9a7/media/audio/win/audio_manager_win.cc

Sign in to add a comment