New issue
Advanced search Search tips

Issue 790555 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Controls focused within a ScrollView are not scrolled into view if the given view isn't visible.

Project Member Reported by kylixrd@chromium.org, Nov 30 2017

Issue description


(1) Browse to http://www.popuptest.com/popuptest1.html
(2) Open Blocked popups bubble.
(3) Tab to list of blocked popup URLs
(4) Continue tabbing through the list of blocked popups.

Expected: When an item is focused that is not visible, ScrollView should scroll until newly focused control is visible within the viewport. 

Actual: Newly focused view is not visible and it appears nothing is focused.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eaac482ef2f7f68eab47d1874a3d2a69efeff33

commit 5eaac482ef2f7f68eab47d1874a3d2a69efeff33
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Dec 06 16:59:40 2017

Ensure the ScrollView is scrolled to reveal any control that acquires focus.

Bug:  790555 
Change-Id: Id64b81c88908adce55d47537ddd0744bfdefc857
Reviewed-on: https://chromium-review.googlesource.com/806256
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522112}
[modify] https://crrev.com/5eaac482ef2f7f68eab47d1874a3d2a69efeff33/ui/views/controls/scroll_view_unittest.cc
[modify] https://crrev.com/5eaac482ef2f7f68eab47d1874a3d2a69efeff33/ui/views/view.cc
[modify] https://crrev.com/5eaac482ef2f7f68eab47d1874a3d2a69efeff33/ui/views/view.h

Status: Fixed (was: Assigned)

Sign in to add a comment