New issue
Advanced search Search tips

Issue 790549 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Mar 2018
Cc:
a...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 788390



Sign in to add a comment

tests/media/autoplay tests flaky

Project Member Reported by a...@chromium.org, Nov 30 2017 
The autoplay layout tests are very very flaky.

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/12699
* http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html
* http/tests/media/autoplay/document-user-activation-feature-policy-alternating.html
* virtual/mojo-loading/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/36589
* virtual/mojo-loading/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html
* virtual/mojo-loading/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html

Comment 1 by a...@chromium.org, Nov 30 2017 

In 02610543b96be59539144855a42adc0030212be9 you mark the tests as "[ Pass Timeout ]". Incorrect. These tests fail.

Will update.

Comment 2 by a...@chromium.org, Nov 30 2017

Blocking: 788390
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e8185c83d1757da4c35a889843dd1905b0aca5

commit a7e8185c83d1757da4c35a889843dd1905b0aca5
Author: Avi Drissman <avi@chromium.org>
Date: Thu Nov 30 19:50:22 2017

Disable failing layout tests.

BUG= 790549 , 788390 
TBR=beccahughes
NOTRY=true

Change-Id: I4046eb8ca85c48ba0ec851a14700ace62deca5c0
Reviewed-on: https://chromium-review.googlesource.com/801656
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520647}
[modify] https://crrev.com/a7e8185c83d1757da4c35a889843dd1905b0aca5/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by a...@chromium.org, Nov 30 2017

Status: Assigned (was: Untriaged)

Comment 5 by mlamouri@chromium.org, Feb 8 2018

Components: Blink>Media>Autoplay

Comment 6 by beccahughes@chromium.org, Mar 20 2018

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b44520f3132325defac71697871d328e28b890

commit e3b44520f3132325defac71697871d328e28b890
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Mar 26 15:53:20 2018

Autoplay: Harden and switch layout tests back on

Harden feature policy layout tests and switch them back on.

These tests are still disabled with site isolation until
HasBeenActivated is replicated.

BUG= 794631 , 790549 

Change-Id: I8fd2be1f9222c71288d5e39e1639c4d990df995b
Reviewed-on: https://chromium-review.googlesource.com/966069
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545804}
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-header.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-alternating.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-iframe-no-gesture.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-same-origin.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-iframe-delegation.html
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js
[modify] https://crrev.com/e3b44520f3132325defac71697871d328e28b890/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/test-autoplay-post-navigation.html

Comment 8 by beccahughes@chromium.org, Mar 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment