New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 790548 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Dec 2017
Cc:
█ trchen@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 771643



Sign in to add a comment

[SPv175] SetLayerState for all drawable GraphicsLayers

Project Member Reported by wangxianzhu@chromium.org, Nov 30 2017 
Now we miss SetLayerState for the following GraphcisLayers:
- BackgroundLayer
  test case: virtual/spv175/compositing/fixed-body-background-position.html
- DecorationOutlineLayer
  test case: virtual/spv175/paint/invalidation/overflow/composited-overflow-with-netative-offset-outline.html
- MaskLayer
  test case: virtual/spv175/compositing/masks/mask-with-added-filters.html
- AncestorCliippingMaskLayer
  test cases: virtual/spv175/**/*border-radius*.html
- ChildClippingMaskLayer
  test case: compositing/overflow/tiled-mask.html
- Squashing layer
  virtual/spv175/paint/invalidation/compositing/newly-composited-repaint-rect.html

Comment 1 by wangxianzhu@chromium.org, Nov 30 2017

Owner: wangxianzhu@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e33e2439c74a67a6dc81965470653161e93ba5fe

commit e33e2439c74a67a6dc81965470653161e93ba5fe
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Dec 02 08:04:51 2017

[SPv175] SetLayerState for mask, background, decoration-outline layers

- Add SetLayerState for MaskLayer (using LocalBorderBoxProperties
  plus Mask), BackgroundLayer and DecorationOutlineLayer
  (using LocalBorderBoxProperties()).

- Ensure property update on GraphicsLayer tree structure change.

- Add default layer state for page overlay layer.

Bug:  790548 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I72df09089d11d76afc34072371523a404412f32e
Reviewed-on: https://chromium-review.googlesource.com/802254
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521206}
[modify] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/LayoutTests/virtual/spv175/compositing/overflow/mask-with-small-content-rect-expected.png
[add] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/overflow/composited-overflow-with-negative-offset-outline-expected.txt
[modify] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/Source/core/page/PageOverlay.cpp
[modify] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/e33e2439c74a67a6dc81965470653161e93ba5fe/third_party/WebKit/Source/core/paint/compositing/CompositingLayerPropertyUpdater.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b89f4fe30c693692988e3360acf3c8952c532e

commit 94b89f4fe30c693692988e3360acf3c8952c532e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Dec 10 06:24:43 2017

[SPv175/PE] SetLayerState for AncestorClippingMaskLayer and ChildClippingMaskLayer

Code change in RarePaintData::ContentsProperties() and PaintLayerPainter::
NeedsToClip() also fix bugs of SPv1 by the way:
-  crbug.com/793272  (incorrect property hierarchy about InnerBordorRadiusClip)
- a bug causing the revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/817372
  (not landed because this CL will fix the bug).
  Added a test case (compositing/overflow/border-radius-above-composited-subframe.html)
  for the bug.

Bug:  790548 , 793272 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I514d9b1ae20fe7ebfe0c1712c67a9dae8b4a11d8
Reviewed-on: https://chromium-review.googlesource.com/798511
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523020}
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe-expected.txt
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe.html
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-above-composited-subframe-expected.txt
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/virtual/spv175/compositing/overflow/border-radius-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/virtual/spv175/compositing/overflow/border-radius-on-parent-composited-grandchild-expected.png
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/BlockPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/ClipRect.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintLayerPainter.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintPhase.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/RarePaintData.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/RarePaintData.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositingLayerPropertyUpdater.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/GraphicsLayerUpdater.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Comment 4 by wangxianzhu@chromium.org, Dec 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment