New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790541 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: remove legacy audits & extension audits

Project Member Reported by chenwilliam@chromium.org, Nov 30 2017

Issue description

Now that lighthouse has succeeded our legacy audits panel, it's time to
remove audits, the extension audits API, extension audits-related
docs, and relevant tests.

According to UMA, audits 2 (i.e. lighthouse) has 15x unique users vs. legacy audits.

The extension audits API has always been experimental, so it shouldn't be too bad removing this API.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b

commit ebdba3f23171157c8d2ce3bcd1072b596fe2a03b
Author: Will Chen <chenwilliam@chromium.org>
Date: Fri Dec 01 22:54:41 2017

DevTools: remove legacy audits & extension audits

Now that lighthouse has succeeded our legacy audits panel, it's time to
remove audits, the extension audits API, extension audits-related
docs, and relevant tests.

Bug:  790541 
Change-Id: Ie2cf3fb439dab768a8511b151d81d6066b41a3a9
Reviewed-on: https://chromium-review.googlesource.com/798633
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521101}
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/api/devtools/experimental_audits.json
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/background.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/content.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/devtools.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/devtools.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/examples/api/devtools/audits/broken-links/manifest.json
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/chrome/common/extensions/docs/server2/app.yaml
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/chrome/common/extensions/docs/server2/known_broken_links.json
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/static/images/devtools-audits-category.png
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/static/images/devtools-audits-results.png
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/templates/intros/experimental_devtools_audits.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/chrome/common/extensions/docs/templates/public/extensions/experimental_devtools_audits.html
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-empty-stylesheet-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-empty-stylesheet.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-panel-functional-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-panel-functional.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-panel-noimages-functional-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/audits-panel-noimages-functional.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/resources/abe.png
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/resources/audits-script1.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/resources/audits-script2.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/resources/audits-style1.css
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/set-cookie-header-audit-no-false-positive-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/audits/set-cookie-header-audit-no-false-positive.html
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-api-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits-api-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits-api.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits-content-script-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits-content-script.html
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits-expected.txt
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-audits.html
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics-expected.txt
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/LayoutTests/http/tests/devtools/user-metrics.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/inspector/audits-test.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/LayoutTests/http/tests/inspector/extensions/extensions-audits-tests.js
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/BUILD.gn
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditCategories.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditCategory.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditFormatters.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditLauncherView.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/auditResultTree.css
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/auditsSidebarTree.css
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits/module.json
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits_test_runner/AuditsTestRunner.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/audits_test_runner/module.json
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAuditCategory.js
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/extensions/module.json
[delete] https://crrev.com/238b6116b6bb8dbb62dc8383341a6d0570d3ad84/third_party/WebKit/Source/devtools/front_end/extensions_test_runner/ExtensionsAuditsTestRunner.js
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/extensions_test_runner/module.json
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/ebdba3f23171157c8d2ce3bcd1072b596fe2a03b/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json

Status: Fixed (was: Assigned)

Sign in to add a comment