New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790462 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocked on:
issue 807400
issue 884903



Sign in to add a comment

Migrate "publish_tarball" to LUCI

Project Member Reported by luci-mig...@appspot.gserviceaccount.com, Nov 30 2017

Issue description

Migrate builder chromium.infra.cron:publish_tarball to LUCI.

Buildbot: https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball
LUCI: https://ci.chromium.org/buildbucket/luci.infra.cron/publish_tarball

Migration app will be posting updates on changes of the migration status.
For the latest status, see
https://luci-migration.appspot.com/masters/chromium.infra.cron/builders/publish_tarball

Migration app will close this bug when the builder is entirely migrated from Buildbot to LUCI.
 

Comment 1 by no...@chromium.org, Jan 18 2018

Labels: -Restrict-View-Google

Comment 2 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Blocker-P1Builders

Comment 3 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-Blocker-P1Builders LUCI-Chromium

Comment 4 by efoo@chromium.org, Feb 21 2018

Labels: Pri-2
Blocking: 807400
Must be migrated with alongside with its parent builder (issue 807400)
Blocking: -807400
Blockedon: 807400
Description: Show this description
Labels: LUCI-Chromium-Mass
Labels: Pri-1
Blockedon: 862060
Blockedon: -862060
Status: Assignedf (was: Available)
Assigning to Thomas to take a look. Thomas, can you work with Andrii to update and verify the ACLs this recipe needs? Also, please review and clean up any hardcoded paths/special package needs. 
Owner: thomasanderson@chromium.org
Status: Assigned (was: Assignedf)
Labels: LUCI-Mirror-Red
Blockedon: 884903
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 17

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/364960d4b430682291c56455f0feef4294226cbf

commit 364960d4b430682291c56455f0feef4294226cbf
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Sep 17 22:57:33 2018

Add service account for tarball builders.

R=jchinlee

Bug: 884903, 807400,  790462 
Change-Id: I5bd1326d01f2b5e712c7a67639f62f756ca651ab
Reviewed-on: https://chromium-review.googlesource.com/1228828
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/364960d4b430682291c56455f0feef4294226cbf/cr-buildbucket.cfg

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3ae6153cd9a779c5bbe109b354e1a2e66f2ed406

commit 3ae6153cd9a779c5bbe109b354e1a2e66f2ed406
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Sep 17 22:59:55 2018

Configure recipe for tarball builders.

R=jchinlee

Bug: 807400,  790462 
Change-Id: I950cc2e28fce326dd72c384877ef949dada528a4
Reviewed-on: https://chromium-review.googlesource.com/1228830
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/3ae6153cd9a779c5bbe109b354e1a2e66f2ed406/cr-buildbucket.cfg

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9c1272208575c50acfa471c82daf0d2a7c4f880c

commit 9c1272208575c50acfa471c82daf0d2a7c4f880c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Sat Sep 22 05:05:31 2018

Add publish_tarball and Build From Tarball builders to cron.

TBR=hinoka

Bug: 807400,  790462 
Change-Id: I3958da6cdc0393f2d4bb8fa0b5bcd53b0b1569af
Reviewed-on: https://chromium-review.googlesource.com/1239571
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/9c1272208575c50acfa471c82daf0d2a7c4f880c/luci-milo.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2231992aa874d9a013bad3226b929037ae58d21d

commit 2231992aa874d9a013bad3226b929037ae58d21d
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Sat Sep 22 05:12:07 2018

Add scheduler config for publish_tarball and Build From Tarball.

publish_tarball is ran every 3 hours.
Build From Tarball is triggered by publish_tarball.

TBR=hinoka

Bug: 807400,  790462 
Change-Id: I73a780d6947032941bc0d528be3aa2e343f0bccf
Reviewed-on: https://chromium-review.googlesource.com/1239572
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/2231992aa874d9a013bad3226b929037ae58d21d/luci-scheduler.cfg

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d0acf8648771c75c4d75c08daf9c0088a362343f

commit d0acf8648771c75c4d75c08daf9c0088a362343f
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Sat Sep 22 07:24:52 2018

Update config for publish_tarball and Build From Tarball.

Turns out publish_tarball may trigger itself, so we should make sure
these aren't merged with cron-based trigger.
Additionally, Build From Tarball should also have each trigger result in
a build.

R=hinoka

Bug: 807400,  790462 
Change-Id: I7f8d2998f842165ab11097daca7e97a52f00ebaa
Reviewed-on: https://chromium-review.googlesource.com/1239853
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/d0acf8648771c75c4d75c08daf9c0088a362343f/luci-scheduler.cfg

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/482b689aa96bd389d56e43f717f7a5d3cf4ee3c4

commit 482b689aa96bd389d56e43f717f7a5d3cf4ee3c4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Sep 25 06:15:31 2018

Bump execution timeout to 3h for publish_tarball and Build From Tarball.

TBR=hinoka

Bug: 807400,  790462 
Change-Id: I26ec4aea83a897caae53d1df57bc20355e613a69
Reviewed-on: https://chromium-review.googlesource.com/1242219
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/482b689aa96bd389d56e43f717f7a5d3cf4ee3c4/cr-buildbucket.cfg

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/47c376b4cca3ba32b138fef32e8d1efc9654dbe2

commit 47c376b4cca3ba32b138fef32e8d1efc9654dbe2
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Sep 25 21:14:26 2018

build_from_tarball: Add path to ninja when using ninja.

Otherwise, it fails in LUCI environment w/o ambient depot_tools, e.g.,
https://ci.chromium.org/b/8934459661803908976

R=iannucci

Bug: 807400,  790462 
Change-Id: I251c70c0ebf0f40d62ac6c3d2de9d69555be78fe
Reviewed-on: https://chromium-review.googlesource.com/1242220
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17873}
[modify] https://crrev.com/47c376b4cca3ba32b138fef32e8d1efc9654dbe2/recipes/README.recipes.md
[modify] https://crrev.com/47c376b4cca3ba32b138fef32e8d1efc9654dbe2/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/47c376b4cca3ba32b138fef32e8d1efc9654dbe2/recipes/recipes/build_from_tarball.py
[modify] https://crrev.com/47c376b4cca3ba32b138fef32e8d1efc9654dbe2/recipes/recipes/build_from_tarball.expected/clang-no-fuchsia.json

Builds appear to be working as expected. Are we ready to flip the LUCI builder to PROD? 
SGTM
Builder has been flipped to LUCI. Keep an eye on it over the next day to verify everything is working. Let us know if you see any issues.

If everything looks good on Thursday, re-assign the bug to efoo@ and I'll take care of turning down the Buildbot builder. Thanks!


Both builders seem to fail to "generate last_commit_position.h". 🤔
Cc: thomasanderson@chromium.org raphael....@intel.com
Owner: efoo@chromium.org
generate last_commit_position.h issue fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1333391

Reassigning to efoo@ to take down the buildbot builder.
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 5

Project Member

Comment 32 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/0b61b8daf718edba8ae968d07639bbbd8fb8bee1

commit 0b61b8daf718edba8ae968d07639bbbd8fb8bee1
Author: Eric Foo <efoo@google.com>
Date: Thu Dec 06 00:40:18 2018

Status: Fixed (was: Assigned)
Buildbot builder taken down. Marking as fixed. 
Description: Show this description

Sign in to add a comment