Issue metadata
Sign in to add a comment
|
Bookmarks - Keyboard pushes the New Folder to the top of the header |
||||||||||||||||||||||
Issue descriptionApp Version:63.0.3239.70 Beta iOS Version: 10.3.3,11.2 Device: iPad Pro 12’’ only URL: NA Precondition: Login to the account with no Bookmarks Steps to reproduce: 1. Launch the app 2. Tap on Menu > Bookmarks 3. Tap on New Folder Observed results: Notice that Keyboard pushes the New Folder to the top of the header Note: Put the app to the background & Relaunch the app, the folder moves even more top Expected results: Keyboard should not push the New Folder to the top of the header Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Safari/Firefox: Firefox: no, Safari: no Bug reproducible on current stable build (App Version, iOS Version): M62, No Bug reproducible on the current beta channel build (App Version, iOS Version): M63, Yes Bug reproducible on Chrome desktop? NA Link to video/image: https://drive.google.com/a/google.com/file/d/1T51mVuE-1fSxCIObLncbdQ3eKH1-2jyi/view
,
Dec 1 2017
,
Dec 4 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fce9ec8dd567b03304c0b67b8bf448026025d5c8 commit fce9ec8dd567b03304c0b67b8bf448026025d5c8 Author: Marti Wong <martiw@chromium.org> Date: Mon Dec 04 23:32:30 2017 Fix the incorrect bottom inset when keyboard appears (iOS bookmarks) Fix the incorrect bottom inset of bookmarkTableView which is set when keyboard appears for editing new folder name. (This causes the new folder being "pushed" to the top of the screen on iPad.) Screenshot: https://drive.google.com/file/d/1q_w8bRICkEQmOgApFM1wG79UBLJ_EReS Bug: 790046 Change-Id: Ic331244b9f49d77ef0b01edf20252ae4cec2e88d Reviewed-on: https://chromium-review.googlesource.com/805179 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521518} [modify] https://crrev.com/fce9ec8dd567b03304c0b67b8bf448026025d5c8/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/fce9ec8dd567b03304c0b67b8bf448026025d5c8/ios/chrome/browser/ui/bookmarks/bookmark_table_view.h [modify] https://crrev.com/fce9ec8dd567b03304c0b67b8bf448026025d5c8/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm
,
Dec 5 2017
,
Dec 12 2017
Verified on 65.0.3292.0 Canary on iPad Pro 12"(iOS 10.3.3) Keyboard doesn't push the folder to the top of the header, looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vbarig...@chromium.org
, Dec 1 2017