New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 790024 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 775677



Sign in to add a comment

ImageWriterUtilityClient should not use UtilityProcessMojoClient

Project Member Reported by jcivelli@chromium.org, Nov 30 2017

Issue description

As part of the effort to deprecate UtilityProcessMojoClient, we should servicify RemovableStorageWriter and change ImageWriterUtilityClient to use the service instead of UtilityProcessMojoClient.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d

commit 66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d
Author: Jay Civelli <jcivelli@google.com>
Date: Tue Dec 05 01:05:10 2017

Servicifying RemovableStorageWriter.

Made RemovableStorageWriter a chrome service and changed
ImageWriterUtilityClient to use the service instead of
UtilityProcessMojoClient, which is being deprecated.

ImageWriterUtilityClient now requires a service_manager::Connector
when created. As a result, extensions::image_writer::Operation which
creates an ImageWriterUtilityClient and all its derived classes now
also take a connector.

This patch was tested manually on Windows and Mac by using the Chrome
OS recovery tool [1] and writing a recovery image on a USB stick.

[1] http://bit.ly/2jFtsZZ

Bug:  790024 
Change-Id: Ie31c123e189ccd0134f9fc63a5dd7238011bebca
Reviewed-on: https://chromium-review.googlesource.com/786257
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521563}
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/app/BUILD.gn
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/app/generated_resources.grd
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/DEPS
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation_manager.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation_manager.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/test_utils.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/test_utils.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_file_operation.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_file_operation.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/common/extensions/BUILD.gn
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/BUILD.gn
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/DEPS
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/OWNERS
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/manifest.json
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/public/interfaces/BUILD.gn
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/public/interfaces/OWNERS
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/public/interfaces/constants.mojom
[rename] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/public/interfaces/removable_storage_writer.mojom
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/removable_storage_writer.cc
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/removable_storage_writer.h
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/removable_storage_writer_service.cc
[add] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/services/removable_storage_writer/removable_storage_writer_service.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/test/BUILD.gn
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/BUILD.gn
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/DEPS
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/extensions/extensions_handler.h
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/image_writer/image_writer_handler.cc
[modify] https://crrev.com/66e0d890fcc9d2f24995e8880f82cc3cccb4cf2d/chrome/utility/image_writer/image_writer_handler.h

Status: Fixed (was: Untriaged)

Sign in to add a comment