New issue
Advanced search Search tips

Issue 790013 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in safe_browsing::dmg::ConvertBigEndian

Project Member Reported by ClusterFuzz, Nov 30 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6655896104206336

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x602000002e70
Crash State:
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::HFSBTreeIterator::ReadCurrentLeaf
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6655896104206336

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 30 2017

Labels: Test-Predator-Auto-Owner
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/902112f50d2142fe611aac017954cfd5024023e6 (Add a new safe_browsing DMG fuzzer for the HFS+ layer.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by palmer@chromium.org, Nov 30 2017

Components: Services>Safebrowsing
Labels: M-65
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 1 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 1 2017

Labels: Pri-1
Labels: SafeBrowsing-Triaged
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 15 2017

rsesek: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 30 2017

rsesek: Uh oh! This issue still open and hasn't been updated in the last 29 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d839eaa0fea5857b3a4226a0ee82ea5223b2b9bb

commit d839eaa0fea5857b3a4226a0ee82ea5223b2b9bb
Author: Robert Sesek <rsesek@chromium.org>
Date: Thu Jan 04 02:36:34 2018

[Mac] Fix buffer-overread in safe_browsing::dmg::ConvertBigEndian.

If the HFS volume header's reported variable-length node size is less
than the size of a node's base header struct, the data are malformed.

Bug:  790013 
Change-Id: Ib61e48ad636170c935936fbb4795090c2f8c8f25
Reviewed-on: https://chromium-review.googlesource.com/849076
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526902}
[modify] https://crrev.com/d839eaa0fea5857b3a4226a0ee82ea5223b2b9bb/chrome/utility/safe_browsing/mac/hfs.cc

Status: Fixed (was: Assigned)
Project Member

Comment 10 by ClusterFuzz, Jan 5 2018

ClusterFuzz has detected this issue as fixed in range 526865:526949.

Detailed report: https://clusterfuzz.com/testcase?key=6655896104206336

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x602000002e70
Crash State:
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::HFSBTreeIterator::ReadCurrentLeaf
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=526865:526949

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6655896104206336

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Jan 5 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6655896104206336 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 5 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 15 by sheriffbot@chromium.org, Apr 13 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment