New issue
Advanced search Search tips

Issue 790010 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Window border problems with disabled "Use system title bar and borders"

Reported by bernimo...@gmail.com, Nov 30 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
For all those points go to settings and disable "Use system title bar and borders" on a machine with Linux and GTK (Desktop environment shouldnt matter, seen this behavior on others too).

What is the expected behavior?
1. Space above tab-strip should be visible if the window is maximized so that the user can grab the window to minimize. This behavior is on MacOS and Windows but not on e.g. Linux/GTK/GNOME.
2. The profile/manage people button within the tab-strip should be vertically centered and match the MacOS/Windows counterparts in appereance.

What went wrong?
1. If the window is maximized the window titlebar/frame is only as tall as the tab-strip. Another side effect is that the client side decoration window buttons dont match their native counterparts (way too small).
2. The profile/manage people button within the tab-strip is displaced (top-aligned), has a border around it, is smaller than on MacOS/Windows and if the window is minimized is weirdly placed above the new tab button.

Did this work before? N/A 

Chrome version: 64.0.3253.3  Channel: dev
OS Version: 4.13.12
Flash Version: 

1. Screenshots 1-3. CSD ... show the window titlebar/frame minimized, maximized (no frame) and maximized (fixed).
2. Screenshots 4-5. Profile button ... show the button border, size and weird placement for a minimized and a maximized window.
 
1. CSD (minimized).png
49.7 KB View Download
2. CSD (maximized) - no frame.png
93.0 KB View Download
3. CSD (maximized) - fixed.png
96.0 KB View Download
4. Profile button (minimized).png
5.1 KB View Download
5. Profile button (maximized).png
7.2 KB View Download
With a small change (remove the " || delegate_->IsMaximized()" from "OpaqueBrowserFrameViewLayout::IsTitleBarCondensed()" within "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc") the first problem can be simply resolved (see https://bugs.chromium.org/p/chromium/issues/attachment?aid=314603&inline=1). I havent tested it on other other platforms.


The initial bug report for native GTK window navigation buttons was https://bugs.chromium.org/p/chromium/issues/detail?id=753067
Labels: Needs-Feedback Needs-Triage-M64
Unable to reproduce the issue on reported version 64.0.3253.3 and on latest stable 62.0.3202.94 in Ubuntu 14.04.
Attaching screenshot for reference.

@Reporter: Could you please check this issue by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. 

Thanks!
790010.png
87.6 KB View Download
For me the same problem is visible in your screenshot. There is no space above the tabs to drag'n'drop the window if there are more than 6-9 tabs open. And the profile button besides the window controls has the same border as the window controls (for you, since you dont seem to have the newest version with native gtk csd).

I have attached some MacOS screenshots für a normal window and a maximized window to show you what i mean.

On Windows it seems to be close to whats on Linux (see Screenshots). But i think there should be some space in the maximized version to have the ability to just grab it to go out of maximized mode. And the profile icon is way smaller on the windowed version and looks kinda out of place.

For all those tests i used the binaries from https://download-chromium.appspot.com/ On Linux (my previous screenshots) i tested it with the official Chrome 62.0.3202.94 and Chromium build from https://commondatastorage.googleapis.com/chromium-browser-official/chromium-64.0.3253.3.tar.xz

I think the tab bar / window top border should behave the same (like MacOS) on all platforms to make it more consistent. For Windows an Linux this would fix some weird profile button placement / scaling and would give the user the option to "close" maximized mode / go to windowed mode by dragging the top window border down. For Linux/GTK this would also fix the way too small gtk csd close button issue if the window is maximized (https://bugs.chromium.org/p/chromium/issues/attachment?aid=314605&inline=1).

I hope this explanation is clearer. ;) Thx
MacOS (windowed).png
97.5 KB View Download
MacOS (maximized).png
62.2 KB View Download
Windows (windowed).png
65.1 KB View Download
Windows (maximized).png
76.4 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 4 2017

Cc: kebalaji@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "kebalaji@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Settings
Labels: Triaged-ET M-65 OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Win-10 and Ubuntu 14.04 using chrome reported version #64.0.3253.3 and latest canary #65.0.3309.0.
This is a non-regression issue as it is observed from M50 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!
Just noticed that somehow the screenshots from the first post got switched.

2. CSD (maximized) - no frame.png <=> 3. CSD (maximized) - fixed.png

2. CSD (maximized) - no frame.png: https://bugs.chromium.org/p/chromium/issues/attachment?aid=314603&inline=1
3. CSD (maximized) - fixed.png: https://bugs.chromium.org/p/chromium/issues/attachment?aid=314602&inline=1
The current version 64.0.3282.119 (Official Build) (64-bit) kinda fixed the wrong button part of my 2 point. But the scaling issue is still there.
CSD (windowed).png
3.2 KB View Download
CSD (maximized).png
3.3 KB View Download
System title bar (windowed).png
3.5 KB View Download
Since the profile button was moved near the address bar that part is fixed.

But with PWAs there are new ones!

1. Top window border height is wrong
2. Buttons that are not window controls should have a border
3. Window Title should be centered

I have attached a Google Photos PWA Screenshot and a native GTK (gedit) app for reference.
Screenshot from 2018-10-25 17-10-19.png
8.3 KB View Download
Screenshot from 2018-10-25 17-09-52.png
10.3 KB View Download
Components: -UI -UI>Settings UI>Browser>TabStrip
This is not related to the chrome://settings UI. Removing component.

Sign in to add a comment