Issue metadata
Sign in to add a comment
|
88 Kb regression in resource_sizes (MonochromePublic.apk) at 520377:520377 |
||||||||||||||||||||||
Issue descriptionCaused by "Using ARMv8 CRC32 specific instruction" Commit: 35988c821c051a57e30c76f9fcd87b7b677bd9bd Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=480214 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase Based on the graph: All native growth.
,
Nov 30 2017
88 Kb is a pretty big jump on Android, was this expected? Can we reduce this? Please see the attached symbol diff for details on where the growth came from. I realize this CL has already been reverted for other reasons but I'm assuming the reland will fire another alert so it would be great it we could address the size regression before the reland is submitted. If you want to check locally how much a commit affects size you can run (in an Android checkout): tools/binary_size/diagnose_bloat HEAD -v
,
Nov 30 2017
Didn't look closely at the symbol diff but agrieve pointed out to me offline that this is probably due to another symbol gap being added (unavoidable). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 30 2017