Retry request to perf dashboard when uploading metrics |
|
Issue descriptionSee [1] for an example of a failed upload. All users of perf_dashboard recipe module would benefit if it had some retries. Typically we use 5 retries in other modules. Retries can be added either to the recipe itself [2] or to the script file that does the uploading [3]. [1]: https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.client.v8%2Fv8_cros_perf_1%2F17488%2F%2B%2Frecipes%2Fsteps%2Fperf_dashboard_post%2F0%2Fstdout [2]: https://chromium.googlesource.com/chromium/tools/build/+/682259688d48704f2fc34faa131dd474e705029f/scripts/slave/recipe_modules/perf_dashboard/api.py#98 [3]: https://chromium.googlesource.com/chromium/tools/build/+/682259688d48704f2fc34faa131dd474e705029f/scripts/slave/recipe_modules/perf_dashboard/resources/post_json.py#30 |
|
►
Sign in to add a comment |
|
Comment 1 by simonhatch@chromium.org
, Dec 1 2017