New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789955 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

popBackStack() should be called on cancelled reauth in password settings

Project Member Reported by vabr@chromium.org, Nov 30 2017

Issue description

Observed in Chrome 62 on Android, likely still there in ToT:

0. Ensure the Android device has some screen lock set (PIN, etc.)
1. Save some passwords in Chrome.
2. Visit Settings, Saved passwords, tap on some saved password, to get to the "password detail" view.
3. Tap on the eye icon to view the password.
4. Dismiss the reauth screen with the Back button.
5. Back in the "password detail" view, press the back button again.

Expected: After step 5, the back button should bring the user back to the list of saved passwords.

Actual: Nothing changes. First a subsequent press of the Back button navigates back to the list of saved passwords.

Note: The same holds true if in step 3 the "CANCEL" button is pressed instead. OTOH, if the reauthentication is successfully completed, the back button works as expected.

This is because PasswordReauthenticationFragment#onActivityResult should have the "mFragmentManager.popBackStack();" call outside the inner if-block.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f54676dcee771be7e1271c60aa3440e9574b3c7c

commit f54676dcee771be7e1271c60aa3440e9574b3c7c
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Dec 01 07:01:13 2017

popBackStack after canceled reauthentication

In Chrome's passwords settings, the user needs to reauthenticate to
access their passwords (view, copy, export). Chrome needs to pop the
reauthentication screen from the back stack once the reauthentication
completes, but currently only does it when the reauth is successful.

This CL changes that to always popping the reauth screen.

Bug:  789955 
Change-Id: If6130eb8efb231c191e9ec2d86ac59077acadb73
Reviewed-on: https://chromium-review.googlesource.com/800616
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520879}
[modify] https://crrev.com/f54676dcee771be7e1271c60aa3440e9574b3c7c/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordReauthenticationFragment.java
[modify] https://crrev.com/f54676dcee771be7e1271c60aa3440e9574b3c7c/chrome/android/junit/src/org/chromium/chrome/browser/preferences/password/PasswordReauthenticationFragmentTest.java

Comment 2 by vabr@chromium.org, Dec 7 2017

Status: Fixed (was: Started)

Sign in to add a comment