New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789954 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.input.TextSuggestionMenuTest#testApplySuggestion" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 30 2017

Issue description

"org.chromium.content.browser.input.TextSuggestionMenuTest#testApplySuggestion" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWAsSBUZsYWtlIk1vcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLmlucHV0LlRleHRTdWdnZXN0aW9uTWVudVRlc3QjdGVzdEFwcGx5U3VnZ2VzdGlvbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: rlanday@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Dec 4 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "org.chromium.content.browser.input.TextSuggestionMenuTest#testApplySuggestion". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWAsSBUZsYWtlIk1vcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLmlucHV0LlRleHRTdWdnZXN0aW9uTWVudVRlc3QjdGVzdEFwcGx5U3VnZ2VzdGlvbgw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b716f9806b1d7bcdcde961278dd2d7a1fbb908

commit f0b716f9806b1d7bcdcde961278dd2d7a1fbb908
Author: Ryan Landay <rlanday@chromium.org>
Date: Tue Dec 05 20:18:53 2017

Attempt to reduce flakiness in TextSuggestionMenuTest#testApplySuggestion()

This test is intermittently failing. Based on the screenshots from the failing
try bots, it appears the issue is that the test is tapping at the beginning of
"hello world" instead of at the end.

I'm unable to reproduce the problem locally, but my best guess as to why this is
happening is that we're not waiting to make sure the text has actually been
committed before attempting to find the bounds of the span element that's
supposed to be after the text, so I'm adding this check (which we also have in
testDeleteWordMarkedWithSpellingMarker()).

Bug:  789954 
Change-Id: I06b85282057c361adc9da3f6ee289870ecf0c164
Reviewed-on: https://chromium-review.googlesource.com/802187
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521804}
[modify] https://crrev.com/f0b716f9806b1d7bcdcde961278dd2d7a1fbb908/content/public/android/javatests/src/org/chromium/content/browser/input/TextSuggestionMenuTest.java

Labels: -Sheriff-Chromium
Actively being worked on, removing from sheriff queue.
Status: Fixed (was: Started)

Sign in to add a comment