New issue
Advanced search Search tips

Issue 789949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Reenable FormStructureBrowserTest on iOS

Project Member Reported by olivierrobin@chromium.org, Nov 30 2017

Issue description

Test 67 and 74 have been disabled on cl 692674
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748a0f54a61915c97f36b190277d1d19159be68f

commit 748a0f54a61915c97f36b190277d1d19159be68f
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu Nov 30 21:39:01 2017

Fix Autofill FormStructureBrowserTest expected result.

These fields belong to a form having a action="/search" attribute.
This case is explicitely blacklisted from parsing and these fields should
not appear in the output.
Mark these tests as failing on desktop because pages are loaded via a dataURL
and the form action field is not accessible ( crbug.com/789944 ).

Bug:  789949 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I925f67e68400700c83114c1487fcc00130209f44
Reviewed-on: https://chromium-review.googlesource.com/800512
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520701}
[modify] https://crrev.com/748a0f54a61915c97f36b190277d1d19159be68f/chrome/browser/autofill/form_structure_browsertest.cc
[modify] https://crrev.com/748a0f54a61915c97f36b190277d1d19159be68f/components/test/data/autofill/heuristics/output/067_register_rei.com.out
[modify] https://crrev.com/748a0f54a61915c97f36b190277d1d19159be68f/components/test/data/autofill/heuristics/output/074_register_threadless.com.out
[modify] https://crrev.com/748a0f54a61915c97f36b190277d1d19159be68f/ios/chrome/browser/autofill/form_structure_browsertest.mm

Status: Fixed (was: Started)

Sign in to add a comment