New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789945 link

Starred by 1 user
Status: WontFix
Owner:
sczs@chromium.org
Closed: Sep 27
Cc:
gambard@chromium.org
█ noyau@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Refactoring: create a shared super class for the toolbars of iOS reading list, history and bookmarks.

Project Member Reported by martiw@chromium.org, Nov 30 2017 
We should create a toolbar super class /ui/toolbar/bottom_toolbar.mm.
And reading_list_toolbar.mm, clear_browsing_bar and bookmark_context_bar should be based on that.

This way, we can reduce the redundant code, technical debt and make sure the style/font/spacing of the toolbars are always consistent.

Comment 1 by martiw@chromium.org, Feb 18 2018

Owner: ----
Status: Available (was: Assigned)
Switched team and releasing this bug.

Comment 2 by sczs@chromium.org, Sep 27

Owner: sczs@chromium.org
Status: WontFix (was: Available)
After UIRefresh we're now using the NavigationController stock Toolbar, so we now have a consistent implementation/look for this
►

Sign in to add a comment