New issue
Advanced search Search tips

Issue 789944 link

Starred by 1 user
Status: Fixed
Owner:
rogerm@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Autofill Data driven tests forms have empty action field

Project Member Reported by olivierrobin@chromium.org, Nov 30 2017 
Pages are loaded using data URLs.
This prevent resolving the relative URLs in the page, notably the action fields of forms.
This makes
FormStructureBrowserTest.DataDrivenHeuristics/67
FormStructureBrowserTest.DataDrivenHeuristics/74

fail to have the expected behavior.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/505e8e9c4982d51d0e561aa86735ca3fbb9da849

commit 505e8e9c4982d51d0e561aa86735ca3fbb9da849
Author: Roger McFarlane <rogerm@chromium.org>
Date: Mon Dec 04 23:32:06 2017

[autofill] Make form_structure_browsertest.cc use embedded_test_server.

The data driven tests in form_structure_browsertes.cc were navigating to
test pages using data URLs. These have no way to generate relative URLs
for form actions, so the output was being generated incorrectly for
forms that would be evaluated as !ShouldBeParsed due to having "search"
actions.

This CL uses the embedded test server to serve the test pages instead.

Bug:  789944 
Change-Id: I9bdb6fa376dba070195d125807fb5e4b5443a203
Reviewed-on: https://chromium-review.googlesource.com/804054
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521517}
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/chrome/browser/autofill/form_structure_browsertest.cc
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/autofill/core/common/autofill_regex_constants.cc
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/autofill/core/common/autofill_regex_constants.h
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/018_checkout_ae.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/035_checkout_petco.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/036_checkout_petsmart.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/040_checkout_urbanoutfitters.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/042_checkout_williams-sonoma.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/059_register_macys.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/060_register_mcphee.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/061_register_myspace.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/063_register_officedepot.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/064_register_officemax.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/065_register_pyramidcollection.com.out
[modify] https://crrev.com/505e8e9c4982d51d0e561aa86735ca3fbb9da849/components/test/data/autofill/heuristics/output/071_register_sourceforge.net.out

Comment 2 by rogerm@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment