New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789928 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Dec 2017
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Wrong password should get selected on clicking 'CONFIRM' button in chrome://settings/lockScreen page

Project Member Reported by mmanchala@chromium.org, Nov 30 2017 
Chrome Version: 64.0.3280.5/10172.0.0 dev-channel Daisy,Candy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option
(2)Enter wrong Password in 'Confirm your password' dialog box -> Now click on 'CONFIRM" button and observe entered password is not selected as it is wrong password (Please refer Video and screenshot)

Note:
In "Enter your PIN' overlay enter password -> Now in 'Confirm your PIN' overlay -> enter wrong pin and click 'CONFIRM' button and observe wrong password is selected(Please refer 'Expected_SelectedText' video and screenshot)


Expected: Wrong password should get selected on clicking 'CONFIRM' button
Actual: Instead Wrong password is not getting selected 

This is Non-Regression Issue as 'Screen lock' option is introduced from M-57

@sammiequon : Please confirm the Issue
Actual_NotSelected.webm
350 KB View Download
ACtual_NoSelection.jpg
171 KB View Download
Expected_selectedText.webm
745 KB View Download
Expected_selectedText.webm
745 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4110bb9916191dc638e331cacf4364e9de7dbd1f

commit 4110bb9916191dc638e331cacf4364e9de7dbd1f
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Dec 08 00:16:21 2017

settings: Select all input when wrong password fo lock screen entered.

Request from qa, to match pin input dialog.

Also change nearby code to not use shadow root.

Test: browser_tests CrSettingsPeoplePageQuickUnlockAuthenticateTest.*
Bug:  789928 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If47cb76033ba9f94556a818c88d6e9cdbb28e2cb
Reviewed-on: https://chromium-review.googlesource.com/807525
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522632}
[modify] https://crrev.com/4110bb9916191dc638e331cacf4364e9de7dbd1f/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/4110bb9916191dc638e331cacf4364e9de7dbd1f/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[modify] https://crrev.com/4110bb9916191dc638e331cacf4364e9de7dbd1f/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Comment 2 by sammiequon@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment