Issue metadata
Sign in to add a comment
|
Regression : Remaining time left is not seen completely in Expand form notifications |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3280.5/10172.0.0 dev-channel Daisy,Candy and Reks OS: Chrome Sample URL : http://www.sample-videos.com/ What steps will reproduce the problem? (1)Sign in to user ->Now go to above URL -> download any 30 mb file 2)Now at Notifications ->'Downloading...' is seen in Expand form -> observe remaining time left is not seen completely i.e. '35se....' is seen (Please refer video & screenshot) Expected: Notification with remaining time left text should be seen completely in Expand form Actual: Instead remaining time left is not seen completely This is Regression Issue seen as same is working fine in M-61 i.e. entire Notification is seen @tetsui: Please confirm the Issue
,
Dec 1 2017
Yes, let's do that. We need to show the "n mins left" in totality. Thanks for catching this.
,
Dec 4 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e4cc7265d4f124dfefd8faafe7ac9177b4d449d commit 1e4cc7265d4f124dfefd8faafe7ac9177b4d449d Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Dec 13 02:57:42 2017 Change eliding priority of progress bar notification. Previously, if both the title and the message for a progress bar notification is long enough, the implementation showed the full text of the title and elided the message by following Android behavior. However, in Download notification, it elides "n mins left" text (See screenshot in the bug), which is not preferable. This CL changes the behavior to prioritize the message and elide the title if there is not enough space. TEST=manual BUG= 789924 Change-Id: I9e8da6c9c53ce1409b6d2d7aa05ae2bd62ca854b Reviewed-on: https://chromium-review.googlesource.com/804982 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523666} [modify] https://crrev.com/1e4cc7265d4f124dfefd8faafe7ac9177b4d449d/ui/message_center/views/notification_view_md.cc
,
Dec 13 2017
,
Dec 15 2017
,
Dec 15 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 15 2017
Approving merge to M64 Chrome OS. May wanna look at the CL and ensure any open comments are closed out.
,
Dec 18 2017
kbleicher@: Here is the CL: https://crrev.com/c/804982 I think all the comments are closed.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a766fdf0fc188e100fb4794c9a5dac76ce54b2a1 commit a766fdf0fc188e100fb4794c9a5dac76ce54b2a1 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Dec 19 02:38:06 2017 Change eliding priority of progress bar notification. Previously, if both the title and the message for a progress bar notification is long enough, the implementation showed the full text of the title and elided the message by following Android behavior. However, in Download notification, it elides "n mins left" text (See screenshot in the bug), which is not preferable. This CL changes the behavior to prioritize the message and elide the title if there is not enough space. TEST=manual BUG= 789924 Change-Id: I9e8da6c9c53ce1409b6d2d7aa05ae2bd62ca854b Reviewed-on: https://chromium-review.googlesource.com/804982 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523666}(cherry picked from commit 1e4cc7265d4f124dfefd8faafe7ac9177b4d449d) Reviewed-on: https://chromium-review.googlesource.com/833688 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#291} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a766fdf0fc188e100fb4794c9a5dac76ce54b2a1/ui/message_center/views/notification_view_md.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Dec 1 2017