New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789920 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression:Focus traversal of ChromeVox spoken feedback is not seen on all the network names at ubertray

Project Member Reported by rkalavakuntla@chromium.org, Nov 30 2017

Issue description

Chrome Version:64.0.3280.5/10172.0.0 dev-channel Daisy,Candy,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build>> In OOBE screen->Accessibility section ->Enable ChromeVox spoken feedback
(2)In Ubertray ->click on Network section ->now press tabbing and Observe the orange focus

Actual:While tabbing,orange focus is  is not seen on all the network names at ubertray, instead it is seen out of box
Expected:While tabbing,orange focus should travel along the network names

This is a Regression issue as same is working fine in M-63 

Note:Issue is not seen in Linux,Windows OS

@dmazzoni: Please confirm the issue


 
actual.mp4
10.6 MB View Download
Expected.mp4
10.9 MB View Download
Owner: katie@chromium.org
@katie, this looks similar to the other Views coordinate-related bug you were looking at.

It's possible that this change I landed regressed it: https://chromium-review.googlesource.com/780362

Could you take a look? I'll help you debug it.


Comment 2 by katie@chromium.org, Dec 6 2017

Dominic, commenting out the change you made does fix the problem seen here in ChromeVox, as well as fixing the other bug I was investigating. Should we revert it or try to add a fix?

Comment 3 by katie@chromium.org, Dec 13 2017

Cc: katie@chromium.org
 Issue 793768  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c28658521df0eee696b38c677433a9086091325c

commit c28658521df0eee696b38c677433a9086091325c
Author: Katie Dektar <katydek@google.com>
Date: Wed Dec 13 02:13:28 2017

Fixes accessiblity updates in native views that scroll or animate.

Bug:  789920 , 778080 , 789282 

Change-Id: Ie4b9d18ffbff48602126f6a4024fdd39f49fe032
Reviewed-on: https://chromium-review.googlesource.com/815878
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523654}
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view.cc
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view.h
[modify] https://crrev.com/c28658521df0eee696b38c677433a9086091325c/ui/views/view_unittest.cc

Comment 5 by katie@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by katie@chromium.org, Dec 18 2017

Labels: -Merge-TBD Merge-Request-64
Confirmed this is an issue on current Dev.
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by katie@chromium.org, Dec 18 2017

I cherry-picked it to here: https://chromium-review.googlesource.com/815878.
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 19 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d06b722374fed663b8d5d604627160f5db2dc28

commit 4d06b722374fed663b8d5d604627160f5db2dc28
Author: Katie Dektar <katydek@google.com>
Date: Tue Dec 19 16:37:21 2017

Fixes accessiblity updates in native views that scroll or animate.

Bug:  789920 , 778080 , 789282 

Change-Id: Ie4b9d18ffbff48602126f6a4024fdd39f49fe032
Reviewed-on: https://chromium-review.googlesource.com/815878
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523654}(cherry picked from commit c28658521df0eee696b38c677433a9086091325c)
Reviewed-on: https://chromium-review.googlesource.com/832380
Cr-Commit-Position: refs/branch-heads/3282@{#295}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view.cc
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view.h
[modify] https://crrev.com/4d06b722374fed663b8d5d604627160f5db2dc28/ui/views/view_unittest.cc

Comment 12 by katie@chromium.org, Jan 10 2018

Labels: a11y-testing
Labels: a11y-testers
Labels: -a11y-testing -a11y-testers
Status: Verified (was: Fixed)
Google Chrome OS 69.0.3464.0 (Official Build) canary (64-bit)
Firmware Version Google_Eve.9584.151.0

Steps:
# Reimage to get to OOBE
# Turn on ChromeVox with ctrl + alt + z
# Move up and down list of network connections using search + arrow

Works as expected: the focus highlight is on each network name as expected

Sign in to add a comment