New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789905 link

Starred by 2 users
Status: Fixed
Owner:
js...@chromium.org
Closed: Jan 2018
Cc:
█ krajshree@chromium.org
ajha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted numbers are seen in Language dropdown of OOBE screen

Project Member Reported by kebalaji@chromium.org, Nov 30 2017 
Chrome Version: 64.0.3280.5/10172.0.0 dev-channel Daisy,Candy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE screen, click on Language dropdown and observe

Actual: Unwanted numbers(001) is seen beside Arabic language
Expected: No such numbers should be seen 

This is a Regression issue as same is working fine in M63

NOTE: Issue is not seen in Linux and Windows

@alemate: Please confirm the issue
ActualArabic.jpg
1.9 MB View Download
Expected Arabic.jpg
1.3 MB View Download

Comment 1 by alemate@chromium.org, Dec 13 2017

Cc: alemate@chromium.org
Owner: js...@chromium.org
This is because AvailableLocalesTraits::New() in ui/base/l10n/l10n_util.cc returns 'ar-001' as available locale, and then it translates into:

[130741:130795:1212/225005.991120:ERROR:l10n_util.cc(235)] ########## GetLanguageList() (3): 'ar-001' => display_name='Arabic (001)', native_display_name='ﺎﻠﻋﺮﺒﻳﺓ (001)'

Assigning to l10n owner.

Comment 2 by js...@chromium.org, Dec 15 2017 

We should block ar-001. I'll.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b72993ae87c6bba905ccb9dc838d7c4cee3617

commit a2b72993ae87c6bba905ccb9dc838d7c4cee3617
Author: Jungshik Shin <jshin@chromium.org>
Date: Sun Dec 17 20:20:48 2017

Exclude ar-001 and en-150 from the available locale list

Bug:  789905 
Test: CrOS OOBE language menu does not have ar-001 and en-150.
Change-Id: I5f9489edf5819e789558bf53ddb4ecbb389e6a45
Reviewed-on: https://chromium-review.googlesource.com/828070
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524624}
[modify] https://crrev.com/a2b72993ae87c6bba905ccb9dc838d7c4cee3617/ui/base/l10n/l10n_util.cc

Comment 4 by js...@chromium.org, Dec 19 2017

Labels: merge-request
Status: Started (was: Assigned)
 alemate@:  can you verify in canary?  Then, I'll ask for merge to M64. 
Thank you.

Comment 5 by js...@chromium.org, Dec 19 2017

Labels: -merge-request

Comment 6 by js...@chromium.org, Jan 2 2018

Labels: Merge-Request-64
Status: Fixed (was: Started)
Requesting for merge to 64 branch. The change is very simple and should be safe to merge.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 2 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by kbleicher@chromium.org, Jan 3 2018

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 5 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45377e18a2ec8f726df564835e9e8e8ccaeea6ec

commit 45377e18a2ec8f726df564835e9e8e8ccaeea6ec
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Jan 05 19:53:25 2018

[M64 branch] Exclude ar-001 and en-150 from the available locale list

Bug:  789905 
Test: CrOS OOBE language menu does not have ar-001 and en-150.
Change-Id: I5f9489edf5819e789558bf53ddb4ecbb389e6a45
Reviewed-on: https://chromium-review.googlesource.com/828070
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524624}(cherry picked from commit a2b72993ae87c6bba905ccb9dc838d7c4cee3617)

TBR=alemate@chromium.org

Change-Id: I5f9489edf5819e789558bf53ddb4ecbb389e6a45
Reviewed-on: https://chromium-review.googlesource.com/853012
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#422}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/45377e18a2ec8f726df564835e9e8e8ccaeea6ec/ui/base/l10n/l10n_util.cc
►

Sign in to add a comment