New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

table vertical right border not visible ?

Reported by eli...@gmail.com, Nov 30 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
1. add with javascript tr/td elements to existing table
2. 
3. 

What is the expected behavior?
show correctly the right vertical border of the table,
mode collapse

What went wrong?
do not show the right-vertical border of a table,
worked correctly until last 2-3 weeks.

Did this work before? Yes ?

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 10.0
Flash Version: 

I run my javascript app (with same url) with microsoft edge browser, it shows the right-vertical border correctly.
 
Labels: Needs-Bisect
Cc: vamshi.k...@techmahindra.com
Labels: Triaged-ET Needs-Triage-M62 Needs-Feedback
"Thanks for filing the issue.

@Reporter: Could you please provide a sample file to check the issue, which helps us to triage it in a better way."

Comment 3 by eli...@gmail.com, Dec 2 2017

I think it's regression in chrome last versions, (that not influenced on MS edge for example),

see my fiddle :
https://jsfiddle.net/5rm7phbc/

explanation:
1. see right-vertical border of table not visible (?)

2. you see 2 elements <TD>, if you remove last <TD>, you notice that there is no border right-vertical at the end of one-last <TD>

this is change regression of chrome javascript engine from previous versions, because it worked correctly from beginning of chrome time

Project Member

Comment 4 by sheriffbot@chromium.org, Dec 2 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "vamshi.kommuri@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by eli...@gmail.com, Dec 2 2017

please note, also :
table , border horizontal-bottom is also not visible (??)
I think it should be also visible
Cc: sc00335...@techmahindra.com
Components: -Blink Blink>Paint>Invalidation
Labels: -Pri-2 -Needs-Bisect M-65 hasbisect OS-Linux OS-Mac Pri-1
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 62.0.3202.94 and on latest canary 65.0.3284.0 using Windows 10, Mac 10.13.1 and Ubuntu 14.04 with jsfiddle given in comment#3.

Bisect Info:
================
Good Build: 60.0.3094.0
Bad Build: 60.0.3095.0

Unable to perform per-revision bisect as we are seeing error due to perf builds. Tried on both Mac and Linux. Hence providing chromium bisect info.

You are probably looking for a change made after 470267 (known good), but no later than 470268 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/cffa5eef397958bc2fbc0500af130ebecd07a8c9..dba4d1702934a03d833c91f2c025faf2106b9c76

Review-Url: https://codereview.chromium.org/2861373003

Suspecting same from changelog.

@wangxianzhu: Please confirm the issue and help in re-assignig if it is not related to your change.

Thanks!
Sorry for the break.

Before this is fixed, if possible, you can workaround the issue by removing "overflow:hidden" from the table style.
Components: -Blink>Paint>Invalidation Blink>Layout>Table
Reduced test case (Pass: green rectangle; Fail: green rectangle with a red frame).

The overflow clip rect of the table is smaller by half of the collapsed border widths than expected.
table-border.html
348 bytes View Download

Comment 9 by eli...@gmail.com, Dec 8 2017

1.
sorry, I did not understand your last answer,
what I have to correct or change ?
I see you use 2 tables, my example js.fiddle are 2 divs

2.
from previous answer I understand to remove, meanwhile the 
"overflow:hidden" from table

3. I have to wait for version correction ?



#c8 is my own note of working progress for the bug. 

You can wait for the version correction, or remove "overflow:hidden" from table to avoid this bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/449fb0c0b85a0f862bffc8ba8c17037ef841b6d9

commit 449fb0c0b85a0f862bffc8ba8c17037ef841b6d9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Dec 09 00:40:06 2017

[PE] Don't clip off outer halves of table collapsed borders

Though the outer halves of collapsed borders belong to the border area
in means of layout, they are actually part of the contents so overflow
clip should not clip off them. Use the border box rect as overflow clip
rect for tables with collapsed borders.

Bug:  789892 
Change-Id: Icea5463f1b52f4746aeab4cb82133507fca27de3
Reviewed-on: https://chromium-review.googlesource.com/817647
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522937}
[add] https://crrev.com/449fb0c0b85a0f862bffc8ba8c17037ef841b6d9/third_party/WebKit/LayoutTests/fast/table/collapsed-border-overflow-hidden-expected.html
[add] https://crrev.com/449fb0c0b85a0f862bffc8ba8c17037ef841b6d9/third_party/WebKit/LayoutTests/fast/table/collapsed-border-overflow-hidden.html
[modify] https://crrev.com/449fb0c0b85a0f862bffc8ba8c17037ef841b6d9/third_party/WebKit/Source/core/layout/LayoutTable.cpp

Actually my CL didn't cause regression of the underlying root reason (that table's OverflowClipRect doesn't cover outer halves of the collapsed borders), but exposed it in more cases due to corrected visual overflow of table sections.
Status: Fixed (was: Assigned)

Comment 14 by eli...@gmail.com, Dec 11 2017

it is not fixed,
it works correctly on other browser like IE Edge,
and it worked correctly on chrome until few weeks before

surprise from your answer



elinfo@gmail.com: which version did you try?

Comment 16 by eli...@gmail.com, Dec 11 2017

version :  63.0.3239.84 (Official Build) (64-bit)
it was updated now, from version above (thread)
I started chrome again, and still remain this thread problem

Labels: -M-65 M-64 Merge-Request-64
The bug has been fixed in trunk (65.0.3290.0). You can try this version by downloading the canary channel of chrome (https://www.google.com/chrome/browser/canary.html). Sorry we won't fix this bug for 63.

Does removing "overflow: hidden" from table work for you to workaround this bug?

Comment 18 by eli...@gmail.com, Dec 11 2017

thanks for your info,
I'll follow your instructions

when you expect the version: 65.0.3290.0, will be standard flow of chrome ?

According to the current plan (https://www.chromium.org/developers/calendar), 65 will be stable around 3/8/2018. I have requested to merge the fix to M64. If it's approved, you'll get it in 64 stable around 1/23/2018 according to the current plan.
Please confirm if this has been tested in Canary yet?
Yes, tested on 65.0.3290+
Project Member

Comment 22 by sheriffbot@chromium.org, Dec 12 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 12 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfa6916c0914695d0bc53e0be368d32c2a38f9ea

commit cfa6916c0914695d0bc53e0be368d32c2a38f9ea
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Dec 12 22:14:42 2017

[PE] Don't clip off outer halves of table collapsed borders

Though the outer halves of collapsed borders belong to the border area
in means of layout, they are actually part of the contents so overflow
clip should not clip off them. Use the border box rect as overflow clip
rect for tables with collapsed borders.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 449fb0c0b85a0f862bffc8ba8c17037ef841b6d9)

Bug:  789892 
Change-Id: Icea5463f1b52f4746aeab4cb82133507fca27de3
Reviewed-on: https://chromium-review.googlesource.com/817647
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522937}
Reviewed-on: https://chromium-review.googlesource.com/823221
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#184}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[add] https://crrev.com/cfa6916c0914695d0bc53e0be368d32c2a38f9ea/third_party/WebKit/LayoutTests/fast/table/collapsed-border-overflow-hidden-expected.html
[add] https://crrev.com/cfa6916c0914695d0bc53e0be368d32c2a38f9ea/third_party/WebKit/LayoutTests/fast/table/collapsed-border-overflow-hidden.html
[modify] https://crrev.com/cfa6916c0914695d0bc53e0be368d32c2a38f9ea/third_party/WebKit/Source/core/layout/LayoutTable.cpp

Comment 24 by eli...@gmail.com, Feb 13 2018

google cheers !,
as you promised the new version (end of january 2018)
will correct the borders view in table,
it happends,
now it's working correctly !

Sign in to add a comment