New issue
Advanced search Search tips

Issue 789888 link

Starred by 1 user
Status: Assigned
Owner:
clamy@chromium.org
Cc:
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: Cannot open hertz.com

Project Member Reported by brajkumar@chromium.org, Nov 30 2017 
Automated tests for the below commit have been missing.Please add test coverage ASAP to avoid regressions in future.

CL: 
----
https://chromium.googlesource.com/chromium/src/+/31c3332e3c10c64ec14f4920bda83776941c5937

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=776164

Thank you...!!

Comment 1 by clamy@chromium.org, Nov 30 2017

Cc: mmenke@chromium.org
Status: WontFix (was: Assigned)
Due to the reason of the failure (idiosyncracies of the hertz web server), we agreed with mmenke@ on the review that the fix was not something we wanted to enforce in Chrome, hence why there are no tests on this commit.

Comment 2 by mmenke@chromium.org, Nov 30 2017 

It may be worth testing that we at least set the header, though not its order.

Comment 3 by mmenke@chromium.org, Nov 30 2017 

If we care about the header, we should have a regression test.  If we don't, we shouldn't set it...  More I think about this, more I think we should have a test.

Comment 4 by clamy@chromium.org, Nov 30 2017

Status: Assigned (was: WontFix)
I'll add a test to check that we do put the Upgrade-Insecure-Request header on the main frame request, but not for the ordering.

Comment 5 by mmenke@chromium.org, Nov 30 2017 

SGTM.  If you're not familiar with it, the embedded test server has a magic /echoheader?<header-name> URL you can use.
►

Sign in to add a comment