Mihai, this seems like an a11y regression for the MacViews implementation of the user menu. Re-assigning to you to please take a look. cc'ing Trent as well.

Hm. Generally, using Enter to activate the focused button goes against the Mac Human Interface Guidelines. Enter only activates a dialog's shiny blue "default" button (and does this even if another button has key focus). The key to activate the focussed button is Spacebar, and this seems to be work. Compare, e.g., with the system "Empty Trash" dialog. Pressing Enter while the Cancel button has key focus will empty your trash, not cancel.

But in a system *menu* (not a dialog) both Enter and Space activate menu items.

Since the profile switcher is more menu-like than dialog-like, I think we should handle Enter. But just in the profile menu. However, this may be an issue when the dialog *does* have a shiny blue default button (e.g. "Sign in to Chrome"). Although, for some reason Enter isn't working on the "Sign in to Chrome" button anyway - we can keep it that way.

See also  Issue 607430 ,  Issue 607429 ,  Issue 569509 

Deleted: Screen Shot 2017-12-01 at 9.43.59 am.png 29.6 KB

	Screen Shot 2017-12-01 at 9.43.59 am.png 29.6 KB View Download

Interesting, thanks for the background Trent. Agreed that the user menu is more menu-like than dialog-like, and thus it makes sense to keep the status quo behavior (enter activates whatever is keyboard-focused).

 Issue 790989  has been merged into this issue.

msarda@,
Friendly ping to get an update on this issue as it is marked as stable blocker.
Thanks..!

Starting on this bug today.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb

commit e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Mon Dec 18 11:03:28 2017

[profiles] Allow enter to select the button on MacViews.

As explained in https://bugs.chromium.org/p/chromium/issues/detail?id=789882#c4,
on macOS clicking enter does not select the button that is currently focused. This
breaks the behavior for the user menu.

This CL changes the API for views::Button allowing the subclasses to customize
the action for key events. It then changes the hover button to always support
start a click action when the enter button is pressed.

Bug:  789882 
Change-Id: I2175ee765da71fcd34211f544057973f84cb0ac3
Reviewed-on: https://chromium-review.googlesource.com/824603
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524675}
[modify] https://crrev.com/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb/chrome/browser/ui/views/hover_button.h
[modify] https://crrev.com/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb/ui/views/controls/button/button.cc
[modify] https://crrev.com/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb/ui/views/controls/button/button.h
[modify] https://crrev.com/e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb/ui/views/controls/button/button_unittest.cc

[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.

Seems like this landed just today, so in Canary probably tomorrow. Can you please add Merge-Request-64 label if this needs to be merged to M64, after this has been verified? 

Tested on Canary. Request merge to M64.

This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

 Issue 796568  has been merged into this issue.

Approving merge to M64 Chrome OS.

Hi all, apologies; I'm reverting this update since it was targeted to Mac.

This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M64. Branch:3282

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39548ae536052d5e0a4792c0674fb1c342789e85

commit 39548ae536052d5e0a4792c0674fb1c342789e85
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Fri Dec 22 09:33:38 2017

[profiles] Allow enter to select the button on MacViews.

As explained in https://bugs.chromium.org/p/chromium/issues/detail?id=789882#c4,
on macOS clicking enter does not select the button that is currently focused. This
breaks the behavior for the user menu.

This CL changes the API for views::Button allowing the subclasses to customize
the action for key events. It then changes the hover button to always support
start a click action when the enter button is pressed.

Bug:  789882 
Change-Id: I2175ee765da71fcd34211f544057973f84cb0ac3
Reviewed-on: https://chromium-review.googlesource.com/824603
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524675}(cherry picked from commit e53cc4a7bc3c4c6582c6353ef40cfa6bcd5944bb)
Reviewed-on: https://chromium-review.googlesource.com/842782
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#339}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/39548ae536052d5e0a4792c0674fb1c342789e85/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/39548ae536052d5e0a4792c0674fb1c342789e85/chrome/browser/ui/views/hover_button.h
[modify] https://crrev.com/39548ae536052d5e0a4792c0674fb1c342789e85/ui/views/controls/button/button.cc
[modify] https://crrev.com/39548ae536052d5e0a4792c0674fb1c342789e85/ui/views/controls/button/button.h
[modify] https://crrev.com/39548ae536052d5e0a4792c0674fb1c342789e85/ui/views/controls/button/button_unittest.cc