New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789879 link

Starred by 2 users
Status: Assigned
Owner:
benjhayden@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Unnecessary 'View Options' drop-down list gets closed on pressing 'Space' key,

Reported by dchau...@etouch.net, Nov 30 2017 
Chrome Version: 64.0.3281.0 (Official Build)a9249a3ab02174ce71383e54fedb216ed578ba51-refs/heads/master@{#520391} 32/64-bit.
OS: Win(7,8,10),Mac(10.12.6,10.13.2),Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://tracing page.
2. Click on 'View Options' at header to open drop-down list (Focus will be on 'Flow events' checkbox).
3. Now, press 'Space' key from keyboard and observe.

On pressing 'Space' key, unnecessary 'View Options' drop-down list gets closed.
On pressing 'Space' key, 'Flow events' checkbox should get checked.

This is a regression issue, broken in M-64 series, below is manual regression range.

Good build: 64.0.3248.0
Bad build:  64.0.3249.0

You are probably looking for a change made after 511171 (known good), but no later than 511172 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/3e8787f26ce93e2ca110da7e511353e390010d08..ab702021c631e9d4a3b1858a86ee2a70c73ae04a

Suspect: https://chromium.googlesource.com/catapult.git/+/7d0ab7044d5ea2c71ba38e04a3161833ff93acd8

@benjhayden; Kindly help to reassign, if your changes are not related to this issue.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
833 KB View Download
Expected behavior.mp4
438 KB View Download

Comment 1 by benjhayden@chromium.org, Nov 30 2017 

It appears that Chrome dispatches a keydown, event, a keypress event, a change event, and a click event when pressing spacebar on checkboxes. The checkbox created by tr.ui.b.createCheckBox only listens for the change event, so the click event bubbles up to the dropdown, which Polymer re-dispatches as a tap event. Of course, its coordinates are (0,0) which is outside of the dropdown so it closes. Before my change, this bug was prevented by this line:
if (e.srcElement !== this.$.dialog) return;

I'll add that line back.
►

Sign in to add a comment