Failure in SyntheticMouseEventTest.MouseEventAck on linux_chromium_asan_rel_ng |
||||||||
Issue descriptioncontent_browsertests failed SyntheticMouseEventTest.MouseEventAck in my CQ run: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/501470 Dave, looks like you've edited this code recently, care to take a look? Flakiness dashboard shows some other flakes, including non-asan builders: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SyntheticMouseEventTest.MouseEventAck
,
Nov 30 2017
,
Nov 30 2017
,
Dec 1 2017
,
Dec 1 2017
Issue 790751 has been merged into this issue.
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a7a6504f8fd9a71e080a56d0417f2f0e73deb69 commit 4a7a6504f8fd9a71e080a56d0417f2f0e73deb69 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 04 21:17:35 2017 Fix flaky SyntheticMouseEventTest.MouseEventAck Devtools was not correctly handling input that is not generated by itself and invoking callbacks when the input wasn't actually processed. Add a modifier indicating content was injected using the debugger so that we can then query for that to determine if we should release the event. This is a stop gap solution until we can actually bind callbacks into the sending of events and devtools wouldn't need its own queues of callbacks. BUG= 789869 Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 Reviewed-on: https://chromium-review.googlesource.com/804357 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521454} [modify] https://crrev.com/4a7a6504f8fd9a71e080a56d0417f2f0e73deb69/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/4a7a6504f8fd9a71e080a56d0417f2f0e73deb69/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/4a7a6504f8fd9a71e080a56d0417f2f0e73deb69/third_party/WebKit/public/platform/WebInputEvent.h
,
Dec 4 2017
,
Dec 5 2017
Unfortunately this is still failing on Linux and ChromeOS:
[ RUN ] SyntheticMouseEventTest.MouseEventAck
DevTools listening on ws://127.0.0.1:43121/devtools/browser/90353f6d-80f6-4de2-83f7-44b24ca32f5e
[4634:4634:1204/150858.000393:ERROR:proxy_service.cc(1495)] ProxyConfigService for ChromeOS should be created in profile_io_data.cc::CreateProxyConfigService and this should be used only for examples.
[4634:4651:1204/150858.003829:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[4634:4651:1204/150858.003872:ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
[4634:4649:1204/150858.151491:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[4655:4655:1204/150858.499979:WARNING:gpu_info.cc(103)] No active GPU found, returning primary GPU.
[4634:4651:1204/150858.521914:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[4634:4651:1204/150858.521973:ERROR:service_manager.cc(890)] Failed to resolve service name: metrics
../../content/browser/devtools/protocol/devtools_protocol_browsertest.cc:609: Failure
Expected: 3u
Which is: 3
To be equal to: result_ids_.size()
Which is: 2
[ FAILED ] SyntheticMouseEventTest.MouseEventAck, where TypeParam = and GetParam() = (1290 ms)
I am going to disable the test for now.
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3a3cdd7a48a9e6949918f14ef4cb0a743d89386 commit f3a3cdd7a48a9e6949918f14ef4cb0a743d89386 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Tue Dec 05 00:19:43 2017 Revert "Fix flaky SyntheticMouseEventTest.MouseEventAck" This reverts commit 4a7a6504f8fd9a71e080a56d0417f2f0e73deb69. Reason for revert: The test fails on the Linux dbg testers. dbg 64: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/68703 dbg 32: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/46433 Original change's description: > Fix flaky SyntheticMouseEventTest.MouseEventAck > > Devtools was not correctly handling input that is not generated by itself > and invoking callbacks when the input wasn't actually processed. > > Add a modifier indicating content was injected using the debugger so that > we can then query for that to determine if we should release the event. > This is a stop gap solution until we can actually bind callbacks into the > sending of events and devtools wouldn't need its own queues of callbacks. > > BUG= 789869 > > Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 > Reviewed-on: https://chromium-review.googlesource.com/804357 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521454} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,dtapuska@chromium.org Change-Id: I6cdd9e13b0df35dac12ade33b4c1a2e5c49525bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789869 Reviewed-on: https://chromium-review.googlesource.com/807504 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521544} [modify] https://crrev.com/f3a3cdd7a48a9e6949918f14ef4cb0a743d89386/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/f3a3cdd7a48a9e6949918f14ef4cb0a743d89386/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/f3a3cdd7a48a9e6949918f14ef4cb0a743d89386/third_party/WebKit/public/platform/WebInputEvent.h
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6dfda7edd84192131321f354e76bb2bd8f44ee5 commit d6dfda7edd84192131321f354e76bb2bd8f44ee5 Author: calamity <calamity@chromium.org> Date: Tue Dec 05 00:52:19 2017 Revert "Fix flaky SyntheticMouseEventTest.MouseEventAck" This reverts commit 4a7a6504f8fd9a71e080a56d0417f2f0e73deb69. Reason for revert: Breaking on https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/46433 Original change's description: > Fix flaky SyntheticMouseEventTest.MouseEventAck > > Devtools was not correctly handling input that is not generated by itself > and invoking callbacks when the input wasn't actually processed. > > Add a modifier indicating content was injected using the debugger so that > we can then query for that to determine if we should release the event. > This is a stop gap solution until we can actually bind callbacks into the > sending of events and devtools wouldn't need its own queues of callbacks. > > BUG= 789869 > > Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 > Reviewed-on: https://chromium-review.googlesource.com/804357 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521454} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,dtapuska@chromium.org Change-Id: I526b2c2d4ab644206b1b34126436432a64fd3914 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789869 Reviewed-on: https://chromium-review.googlesource.com/807584 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521557}
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47740515e5b7e5e2df5db5f7f2685f017eec18d9 commit 47740515e5b7e5e2df5db5f7f2685f017eec18d9 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Dec 07 14:31:55 2017 Fix flaky SyntheticMouseEventTest.MouseEventAck Reland https://chromium-review.googlesource.com/804357. This time ensure that we are using a MouseDown event instead of MouseMove event as MouseMove events can be sent from the UI synthetically and that causes the InputMsgWatcher to be in a different state sometimes. Devtools was not correctly handling input that is not generated by itself and invoking callbacks when the input wasn't actually processed. Add a modifier indicating content was injected using the debugger so that we can then query for that to determine if we should release the event. This is a stop gap solution until we can actually bind callbacks into the sending of events and devtools wouldn't need its own queues of callbacks. BUG= 789869 TBR=pfeldman@chromium.org Change-Id: Id769fa9363debb196d787a73920f24e3a409c68f Reviewed-on: https://chromium-review.googlesource.com/811833 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522417} [modify] https://crrev.com/47740515e5b7e5e2df5db5f7f2685f017eec18d9/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/47740515e5b7e5e2df5db5f7f2685f017eec18d9/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/47740515e5b7e5e2df5db5f7f2685f017eec18d9/third_party/WebKit/public/platform/WebInputEvent.h
,
Dec 7 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by michae...@chromium.org
, Nov 30 2017