Stop running --no-validate-asm perf tests |
||||
Issue descriptionPerf runs for --no-validate-asm are no longer needed. The performance of the slow path is of no concern anymore. Let's free up some resources by not executing them anymore. Can be turned down for sure: -Unity-asm - Might also be eligible for switching it off: - JetStream/Octane/Massive/Embenchen/Emscripten/Arewefastyet/Micro/Compile-asm_wasm: I suppose we don't need it anymore because --validate-asm is on per default Unity-asm-wasm needs to stay because it executes the asm.js workload of Unity
,
Nov 30 2017
,
Nov 30 2017
,
Nov 30 2017
To be sure: do you just want me to stop passing --no-validate-asm flag to Unity-asm benchmark or to remove it altogether?
,
Nov 30 2017
Also I am not sure what "JetStream/Octane/Massive/Embenchen/Emscripten/Arewefastyet/Micro/Compile-asm_wasm" means. There is a benchmark in https://chrome-internal.googlesource.com/v8/v8-perf/+/master/benchmarks/Compile/Compile-asm_wasm.json. Do you want me to stop running it or to stop passing --validate-asm flag to all tests?
,
Nov 30 2017
Ah, I think I got it now. Found all these files: $ git grep validate-asm AreWeFastYet/AreWeFastYet-asm_wasm.json: "flags": ["--validate-asm"], Compile/Compile-asm_wasm.json: "flags": ["--validate-asm"], Compile/Compile-asm_wasm.json: "flags": ["--validate-asm"], Compile/Compile-asm_wasm.json: "flags": ["--validate-asm"], Compile/Compile-asm_wasm.json: "flags": ["--validate-asm"], Embenchen/Embenchen-asm_wasm.json: "flags": ["--validate-asm"], Emscripten/Emscripten-asm_wasm.json: "flags": ["--validate-asm"], JetStream/JetStream-asm_wasm.json: "flags": ["--validate-asm"], Massive/Massive-asm_wasm.json: "flags": ["--validate-asm"], Micro/Micro-asm_wasm.json: "flags": ["--validate-asm"], Octane2.1/Octane2.1-asm_wasm.json: "flags": ["--validate-asm"], Unity/Unity-asm-wasm.json: "flags":["--dump-counters", "--validate-asm", "--runtime-call-stats"], Unity/Unity-asm.json: "flags":["--dump-counters", "--no-validate-asm", "--runtime-call-stats"], So to summarize we want to disable: - (JetStream|Octane|Massive|Embenchen|Emscripten|Arewefastyet|Micro|Compile)-asm_wasm - Unity-asm Is this correct?
,
Nov 30 2017
,
Nov 30 2017
Re #6 yes.
,
Nov 30 2017
To clarify: Should we disable benchmarks with --no-validate-asm or with --validate-asm???
,
Nov 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/3c91aa8cfcc81d5a5a3d3c1c30666019c8c63559 commit 3c91aa8cfcc81d5a5a3d3c1c30666019c8c63559 Author: Sergiy Byelozyorov <sergiyb@google.com> Date: Thu Nov 30 15:22:14 2017
,
Nov 30 2017
,
Dec 5 2017
Re #9: partly both, see the list of benchmarks I supplied. Unity-asm-wasm.json runs the Unity benchmark with asm.js workload, which is still very valuable. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bradnelson@chromium.org
, Nov 30 2017