New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789857 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task


Sign in to add a comment

Onion Soup: content/renderer/service_workers

Project Member Reported by shimazu@chromium.org, Nov 30 2017

Issue description

Let's move the code to the new destination:)

Basically codes will move content/renderer/service_workers -> third_party/WebKit/Source/modules/serviceworkers.

Design doc: https://bit.ly/sw-onionsoup
 

Comment 1 by leon....@intel.com, Dec 6 2017

Blockedon: 789846

Comment 2 by leon....@intel.com, Dec 7 2017

Blocking: 792778
Description: Show this description
Blocking: -792778
Blockedon: 792778
Blockedon: 879019
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5

commit 4882d426eb28bdbde4d2cd2e7a645fd85fb438c5
Author: Han Leon <leon.han@intel.com>
Date: Fri Sep 14 00:03:50 2018

[OnionSoup] Move blink.mojom.ServiceWorkerHost endpoint into Blink

This CL moves the blink::mojom::ServiceWorkerHostAssociatedPtr from
Content into Blink, now Blink can use it directly to do IPCs rather than
requesting Content to do so via public Web interfaces.

To avoid too big a CL, this CL tries to do the movement only and is
leaving some refactoring work as TODOs, i.e. some public Web
structs/callbacks no longer need to cross the boundary of Content and
Blink, so some of them should be just removed and some should be hidden
inside Blink. Follow-up CLs will do these cleanup.

BUG=789857

Change-Id: I080e3f40b4f1e5a79cf37cd62bc6e8d3172b54c4
Reviewed-on: https://chromium-review.googlesource.com/1214709
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591218}
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_client.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/4882d426eb28bdbde4d2cd2e7a645fd85fb438c5/third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3034e414715b68fcb5b658f5e6753d8b21909a43

commit 3034e414715b68fcb5b658f5e6753d8b21909a43
Author: Han Leon <leon.han@intel.com>
Date: Tue Sep 25 07:43:16 2018

[OnionSoup] Make ServiceWorkerContainerClient serve only Document

Currently serviceWorkerContainerClient exists as a supplement in both
Document contexts and Service Worker contexts, holding a
WebServiceWorkerProvider to provide some functionality necessary to
ServiceWorkerContainer,
However, ServiceWorkerContainer serves only Document
(navigator.ServiceWorker), and, now we have no any real plan to support
workerNavigator.ServiceWorker, i.e. a service worker execution context
does not need ServiceWorkerContainer(Client) at all.

So, this CL makes serviceWorkerContainerClient not serve service
worker execution contexts any more, i.e. not a supplement of
WorkerClients. In the meantime, do not create WebServiceWorkerProvider
any more in service worker execution contexts.

BUG=789857

Change-Id: I10b9b536cbe1f37859f4e73c001637551bab3033
Reviewed-on: https://chromium-review.googlesource.com/1238079
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#593849}
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/content/renderer/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/3034e414715b68fcb5b658f5e6753d8b21909a43/third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27ea6d66efa8d360b86092d746f804ee81b7c8f

commit c27ea6d66efa8d360b86092d746f804ee81b7c8f
Author: Leon Han <leon.han@intel.com>
Date: Wed Oct 10 06:23:53 2018

[ServiceWorker] Make blink::ServiceWorker itself hold Mojo connections.

After Mojofication work, blink::ServiceWorker no longer needs to rely on
content::WebServiceWorkerImpl to handle IPCs, now it can hold/access
blink.mojom.ServiceWorkerObject(Host) Mojo connections on its own.

This CL:
  - Removes the public interfaces blink::WebServiceWorker(Proxy),
    instead, creates a new struct blink::WebServiceWorkerObjectInfo to
    help carry blink.mojom.ServiceWorkerObjectInfo from Content into
    Blink, which is then put into blink::ServiceWorker, so that
    blink::ServiceWorker can get the information of
    blink.mojom.ServiceWorkerObject(Host) Mojo connections and use them
    on its own there.
  - Moves the (version_id, ServiceWorker object) mapping from Content
    into Blink:
     - for a Document,
       content::SWProviderContext --> blink::SWContainerClient.
     - for a ServiceWorkerGlobalScope,
       content::SWContextClient --> blink::SWGlobalScope.
  - Removes content::WebServiceWorkerImpl completely as it becomes
    useless now.

Next step we can handle blink::SWRegistration in much the same way.

BUG=789857,879019

Change-Id: I7214e96f913cae36785fc1aac1ad53fd6f1b2a79
Reviewed-on: https://chromium-review.googlesource.com/c/1249307
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598223}
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/BUILD.gn
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/service_worker_type_converters.h
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/content/renderer/service_worker/web_service_worker_impl.cc
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/content/renderer/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_registration_impl.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/content/renderer/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/BUILD.gn
[add] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/DEPS
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/third_party/blink/public/platform/modules/service_worker/web_service_worker.h
[add] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_object_info.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider_client.h
[delete] https://crrev.com/c68311b3c1ec782c21107dc68fc13b89a91cd42b/third_party/blink/public/platform/modules/service_worker/web_service_worker_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/c27ea6d66efa8d360b86092d746f804ee81b7c8f/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6856b267639d14077ac2aac923503f586f3c955

commit a6856b267639d14077ac2aac923503f586f3c955
Author: Leon Han <leon.han@intel.com>
Date: Fri Oct 12 04:17:47 2018

[OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

Currently some modules (push_messaging, background_fetch etc.) are
calling blink::SWRegistration::WebRegistration() to get a pointer to
blink::WebSWRegistration to continue their work there.
However, they use that blink::WebSWRegistration just to retrieve the
service worker registration id, i.e. what they really want is not
blink::WebSWRegistration, but just the registration id.

So, this CL removes blink::SWRegistration::WebRegistration() and
provides a new function blink::SWRegistration::RegistrationId() for
those users instead.

This CL is in preparation for https://crrev.com/c/1275300 which plans to
merge content::WebSWRegistrationImpl into blink::SWRegistration and
remove the public interface blink::WebSWRegistration completely.

BUG=789857,879019

Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac
Reviewed-on: https://chromium-review.googlesource.com/c/1275298
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599093}
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_messaging_client.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_messaging_client.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_provider.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/content/renderer/push_messaging/push_provider.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/public/platform/modules/push_messaging/web_push_client.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/public/platform/modules/push_messaging/web_push_provider.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/background_sync/sync_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/notification_manager.h
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/push_messaging/push_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/push_messaging/push_subscription.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/a6856b267639d14077ac2aac923503f586f3c955/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d2349e924e311f441c8805ff5b32b8d7ea75c6f

commit 3d2349e924e311f441c8805ff5b32b8d7ea75c6f
Author: Leon Han <leon.han@intel.com>
Date: Wed Oct 17 04:37:09 2018

[OnionSoup] Make blink::SWRegistration itself hold Mojo connections.

After Mojofication work, blink::SWRegistration no longer needs to rely
on content::WebSWRegistrationImpl to handle IPCs, now it can hold/access
blink.mojom.SWRegistrationObject(Host) Mojo connections on its own.

This CL:
  - Removes the public interfaces blink::WebSWRegistration(Proxy),
    instead, creates a new struct blink::WebSWRegistrationObjectInfo to
    help carry blink.mojom.SWRegistrationObjectInfo from //content into
    Blink, which is then put into blink::SWRegistration, so that
    blink::SWRegistration can get the information of
    blink.mojom.SWRegistrationObject(Host) Mojo connections and use them
    on its own there.
  - Moves the (registration_id, SWRegistration object) mapping from
    //content into Blink:
    - for a Document,
      content::SWProviderStateForClient --> blink::SWContainerClient.
    - for a SWGlobalScope,
      only one SWRegistration object , still in blink::SWGlobalScope.
  - Removes content::WebSWRegistrationImpl completely as it becomes
    useless now.
  - Removes the intermediate blink::WebNavigationPreloadState struct as
    Blink starts to manipulate the Mojo connection directly and no
    longer needs it to help carry data across the boundary of //content
    and Blink.

BUG=789857,879019

Change-Id: Ie47ac2b4b603a9c8e200676febc92d35826ddba2
Reviewed-on: https://chromium-review.googlesource.com/c/1275300
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600277}
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/BUILD.gn
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/renderer/service_worker/web_service_worker_provider_impl.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/content/renderer/service_worker/web_service_worker_registration_impl.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/content/renderer/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_navigation_preload_state.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_object_info.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration.h
[add] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_object_info.h
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/public/platform/modules/service_worker/web_service_worker_registration_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/BUILD.gn
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/renderer/modules/service_worker/navigation_preload_callbacks.cc
[delete] https://crrev.com/47cf9d16123ebdb3622fb4fa336855b335ce716e/third_party/blink/renderer/modules/service_worker/navigation_preload_callbacks.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/3d2349e924e311f441c8805ff5b32b8d7ea75c6f/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf

commit 5094fa025927e2f4d84c998bcb5cf5d6b37d02bf
Author: Leon Han <leon.han@intel.com>
Date: Wed Oct 31 06:54:39 2018

[OnionSoup] Make SWContainer a supplement of Document

After https://crrev.com/c/1238079, blink::SWContainerClient becomes a
supplement of Document and its only user is blink::SWContainer.
This indirection looks redundant, so this CL refactors SWContainer to be
also a supplement of Document and makes it take over all code logic of
SWContainerClient, then removes SWContainerClient completely.

BUG=789857

Change-Id: If2ecede8530c5d3a922f2388853b46b860fbbb2f
Reviewed-on: https://chromium-review.googlesource.com/c/1286434
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604175}
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/BUILD.gn
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/navigator_service_worker.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/navigator_service_worker.h
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_container.h
[delete] https://crrev.com/e70b5b06140f678b56203ec2eb271b7b027f3667/third_party/blink/renderer/modules/service_worker/service_worker_container_client.cc
[delete] https://crrev.com/e70b5b06140f678b56203ec2eb271b7b027f3667/third_party/blink/renderer/modules/service_worker/service_worker_container_client.h
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_container_test.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.h
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/5094fa025927e2f4d84c998bcb5cf5d6b37d02bf/third_party/blink/renderer/modules/service_worker/service_worker_registration.h

Blockedon: 908344
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc6fc17588514878411671cc668ef7c23221d3f5

commit dc6fc17588514878411671cc668ef7c23221d3f5
Author: Leon Han <leon.han@intel.com>
Date: Wed Jan 09 05:26:40 2019

[OnionSoup] Do not use {SWNetworkProvider,SWProviderContext} for SW execution contexts

Previously, SWContextClient propagates the received
blink::mojom::ServiceWorkerProviderInfoForStartWorkerPtr into
{SWNetworkProvider,SWProviderContext}, and gets those information from
them later when needed, i.e. {SWNetworkProvider,SWProviderContext} serve
just for holding some data for SWContextClient, and SWContextClient does
not rely on their code logic for any real operations like SW clients do.

This CL lets SWContextClient itself save the data
(blink::mojom::ServiceWorkerProviderInfoForStartWorkerPtr) rather than
creating any instance of {SWNetworkProvider,SWProviderContext}, thus
{SWNetworkProvider,SWProviderContext} become classes dedicated for SW
clients.
This makes code logic clearer and facilitates Onion Souping
SWContextClient further.

BUG=789857

Change-Id: I5ec96f819a338136b73521fba72089802e770f15
Reviewed-on: https://chromium-review.googlesource.com/c/1400053
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#621052}
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/dc6fc17588514878411671cc668ef7c23221d3f5/content/renderer/service_worker/service_worker_provider_context.h

Blocking: 561879
Blockedon: 922376
Blockedon: 922377

Sign in to add a comment