New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789854 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 911930
issue 845345
issue 877341

Blocking:
issue 789857


Participants' hotlists:
ServiceWorkerOnionSoup


Sign in to add a comment

Eliminate //content/service_worker/common/*

Project Member Reported by leon....@intel.com, Nov 30 2017

Issue description

This belongs to Onion Soup effort for service worker.

For //content/service_worker/common/*:
  - some of them should be moved into //content/browser/service_worker/ to be used only by browser-side code.
  - some of them should be put into //third_party/WebKit/common/service_worker/ to be shared by both browser-side and renderer-side code.
  - some of them would disappear.
 

Comment 1 by leon....@intel.com, Nov 30 2017

I'd like to know your opinions on this, and also want to know the root issue number for service worker onion soup work so that we can make this one block it ;-)
Blocking: 789857
Thanks! 
There was no issue for onion soup, so I've created and assigned to leon.
And the plan makes sense to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c7a33557a8b46e3071d571edfdfcd0d822b171

commit 45c7a33557a8b46e3071d571edfdfcd0d822b171
Author: Han Leon <leon.han@intel.com>
Date: Fri Dec 01 03:25:50 2017

[ServiceWorker] Move ServiceWorkerFetchEventResult to be used only in browser code

enum ServiceWorkerFetchEventResult does not have to be a common type for
both browser and renderer code, this CL moves it out of
content/common/service_worker/service_worker_types.h, and also removes
the unnecessary IPC traits for it from
content/common/service_worker/service_worker_messages.h.

BUG=789854
TBR=tsepez@chromium.org

Change-Id: I6bda299731b71b8b5f9c493b1a785b7f9889f45b
Reviewed-on: https://chromium-review.googlesource.com/799551
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520834}
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/common/service_worker/service_worker_types.h

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d228126d49ab626d7a40c739c4563e60ed8414ab

commit d228126d49ab626d7a40c739c4563e60ed8414ab
Author: Han Leon <leon.han@intel.com>
Date: Wed Dec 06 03:18:09 2017

[ServiceWorker] Move service_worker_installed_scripts_manager.mojom into WebKit/common/

This CL moves service_worker_installed_scripts_manager.mojom from
content/common/service_worker/ into
third_party/WebKit/common/service_worker/, in preparation to merge
content::WebServiceWorkerInstalledScriptsManagerImpl into Blink.

BUG=789854, 789846 

Change-Id: Ice64bb4ad56602370fc14fa6cd21fd124d454a42
Reviewed-on: https://chromium-review.googlesource.com/807761
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521981}
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/common/BUILD.gn
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/third_party/WebKit/common/BUILD.gn
[rename] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/third_party/WebKit/common/service_worker/service_worker_installed_scripts_manager.mojom

Comment 7 by leon....@intel.com, May 22 2018

Blockedon: 845345
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90aedd869bf269b41942c52fbb39671bccd8a8a6

commit 90aedd869bf269b41942c52fbb39671bccd8a8a6
Author: Han Leon <leon.han@intel.com>
Date: Wed Jun 27 02:13:06 2018

[OnionSoup] Move service_worker_status_code.{cc,h} into Blink

This CL moves the ServiceWorkerStatusCode enum definition files
service_worker_status_code.{cc,h} from content/common/service_worker/
into Blink public folder. After that the ServiceWorkerStatusCode enum
is still available to be used by both browser and renderer code.

This CL also moves a TypeConverter for ServiceWorkerStatusCode into
Blink.

BUG=789854

Change-Id: Ie8032cb7474c7f90f17e58170a38b97263643fbd
Reviewed-on: https://chromium-review.googlesource.com/1114474
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#570635}
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/cleanup_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/cleanup_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/delete_registration_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_developer_ids_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_developer_ids_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_metadata_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_metadata_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_num_requests_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_num_requests_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_settled_fetches_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_registration_for_deletion_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_request_complete_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/start_next_pending_request_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/start_next_pending_request_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_database.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_router.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_database.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_internals_ui.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_read_from_cache_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_object_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_object_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_status.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_unregister_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_unregister_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_write_to_cache_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_event_dispatcher.typemap
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_messages.h
[delete] https://crrev.com/a18d47428d64d9ae3b4138b2bb97d113c2c95646/content/common/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/public/browser/push_messaging_service.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/public/test/service_worker_test_helpers.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/test/test_background_sync_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/OWNERS
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/service_worker_status_code.cc
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/OWNERS
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/service_worker_status_code.h
[add] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/service_worker_type_converters.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e125af0ebb15f0e0715e42f3d56c14ef82b217

commit 51e125af0ebb15f0e0715e42f3d56c14ef82b217
Author: Han Leon <leon.han@intel.com>
Date: Wed Jul 04 04:21:02 2018

[OnionSoup] Define blink::ServiceWorkerStatusCode as "enum class'

This CL changes type of blink::ServiceWorkerStatusCode from 'enum' to
'enum class', then updates everywhere it is accessed.

BUG=789854

Change-Id: I837d8b0b06924f8f42fa7246231e654e364523f6
Reviewed-on: https://chromium-review.googlesource.com/1124102
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572469}
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/cookie_store/cookie_store_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_read_from_cache_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_object_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_unregister_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/public/browser/push_messaging_service.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/public/test/service_worker_test_helpers.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/test/test_background_sync_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/common/service_worker/service_worker_status_code.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/common/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/public/common/service_worker/service_worker_status_code.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2072f0430b9caf99cc75680cf5baddd68b49c0f7

commit 2072f0430b9caf99cc75680cf5baddd68b49c0f7
Author: Han Leon <leon.han@intel.com>
Date: Tue Jul 10 09:44:13 2018

[ServiceWorker] Change ServiceWorkerStatusCode::kMax to kMaxValue

This CL renames ServiceWorkerStatusCode::kMax to kMaxValue and sets its
value as the highest enumerator value, this avoids switch statements
having to handle a sentinel no-op value and makes it easier to use
UMA_HISTOGRAM_ENUMERATION().
Then, this CL revises all related tests.

BUG=789854

Change-Id: Ic0e9ad8f9bf90bb3e2b08dc424957a2f3a545c52
Reviewed-on: https://chromium-review.googlesource.com/1125532
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573664}
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/third_party/blink/common/service_worker/service_worker_status_code.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/third_party/blink/public/common/service_worker/service_worker_status_code.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1525df4abd7e9b3b76e59de615a716d545dd92f

commit f1525df4abd7e9b3b76e59de615a716d545dd92f
Author: Han Leon <leon.han@intel.com>
Date: Wed Jul 11 03:47:59 2018

[OnionSoup] Remove ServiceWorkerUtils::IsServicificationEnabled()

This CL removes ServiceWorkerUtils::IsServicificationEnabled() and uses
blink::ServiceWorkerUtils::IsServicificationEnabled() instead.

BUG=789854

Change-Id: I89031cec6ccaa23a8ea0d711fb0e7684d9a370b1
Reviewed-on: https://chromium-review.googlesource.com/1125535
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#574064}
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/appcache/appcache_navigation_handle_core.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_script_loader_factory.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_script_loader.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_script_loader_factory.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_timeout_timer.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_timeout_timer_unittest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/shared_worker/embedded_shared_worker_stub.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00d598cb4ae00510a30326c3db46f9b0506e36d

commit d00d598cb4ae00510a30326c3db46f9b0506e36d
Author: Han Leon <leon.han@intel.com>
Date: Thu Jul 12 09:45:56 2018

[ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

This CL removes native struct ServiceWorkerProviderHostInfo and the
corresponding typemapping for it, instead, directly uses mojom struct
ServiceWorkerProviderHostInfo everywhere.

BUG=789854

Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
Reviewed-on: https://chromium-review.googlesource.com/1132847
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574516}
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/BUILD.gn
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/service_worker/service_worker_provider.mojom
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider.typemap
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_host_info.cc
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_host_info.h
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_struct_traits.cc
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_struct_traits.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/typemaps.gni
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/renderer/service_worker/service_worker_network_provider.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b80761c42842da1b6a8b5fbec6d3af406ef434f

commit 2b80761c42842da1b6a8b5fbec6d3af406ef434f
Author: Han Leon <leon.han@intel.com>
Date: Thu Jul 26 16:01:55 2018

[OnionSoup] Remove [Native] content.mojom.PlatformNotificationData

Currently service_worker.mojom defines a [Native] mojom struct
content.mojom.PlatformNotificationData using the legacy IPC struct
traits for the native struct content::PlatformNotificationData.

However, there is already existing a mojom struct
blink.mojom.NotificationData which is typemapped with
content::PlatformNotificationData, it's exactly fit to our needs, so,
this CL starts to use blink.mojom.NotificationData then removes
the [Native] content.mojom.PlatformNotificationData and the
corresponding legacy IPC struct traits.

BUG=789854

Change-Id: I20549a8feb3575341661b92a5993bf758e6174e1
Reviewed-on: https://chromium-review.googlesource.com/1149714
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#578321}
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/BUILD.gn
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/content_message_generator.h
[delete] https://crrev.com/d2e0f2c6027de3c9db038ff74af054b0171ce2df/content/common/platform_notification_param_traits.h
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/service_worker/service_worker.typemap

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969cf704c35ad42749d3a175b2f3033c45851f83

commit 969cf704c35ad42749d3a175b2f3033c45851f83
Author: Han Leon <leon.han@intel.com>
Date: Mon Jul 30 04:42:59 2018

[OnionSoup] Remove typemapping for blink.mojom.FetchAPIResponse

This CL is the 1st step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step:
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step:
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: Ibae19bcac50688360426ef8b736a3841ca59ff39
Reviewed-on: https://chromium-review.googlesource.com/1134731
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#578974}
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/get_settled_fetches_task.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/service_worker/service_worker_browsertest.cc
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response.typemap
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response_mojom_traits.cc
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response_mojom_traits.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/typemaps.gni
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/third_party/blink/public/platform/modules/fetch/fetch_api_response.mojom

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604

commit 6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604
Author: Han Leon <leon.han@intel.com>
Date: Tue Jul 31 01:13:46 2018

[OnionSoup] Move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/

This CL is the 2nd step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step: (This CL)
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step:
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I9afad29a89887369c211cb46bce5bc98df16064f
Reviewed-on: https://chromium-review.googlesource.com/1149706
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579273}
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/content/common/DEPS
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/OWNERS
[add] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/README.md
[rename] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/fetch_api_response.mojom
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/platform/modules/cache_storage/cache_storage.mojom
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/renderer/core/fetch/fetch_response_data.h
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/renderer/core/fetch/response.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1deace1f39cbc605fa86973daeedb4cd70e1562

commit c1deace1f39cbc605fa86973daeedb4cd70e1562
Author: Han Leon <leon.han@intel.com>
Date: Fri Aug 03 03:52:53 2018

[OnionSoup] Remove struct content::PushEventPayload

Currently we have a [Native] mojom struct content.mojom.PushEventPayload
with a typemapping to the native struct content::PushEventPayload, we
use them to pass payload data when calling the Mojo call
content.mojom.ServiceWorker.DispatchPushEvent().

However, as content::PushEventPayload contains only 2 members: a string
containing real data and a bool indicating data's validity, and it has
no expectations to be expanded for now, so, we can just
use a base::Optional<string> to replace it, and correspondingly in mojom
we just needs a 'string? payload' for our
content.mojom.ServiceWorker.DispatchPushEvent().

This CL removes content::PushEventPayload by doing the above
replacement.

BUG=789854

Change-Id: I8df737165b3004db820e3b758c1bfa8bdb7b5690
Reviewed-on: https://chromium-review.googlesource.com/1149705
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#580445}
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_unittest.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/browser_context.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/push_messaging/push_messaging_router.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker.typemap
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/public/browser/browser_context.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/public/common/BUILD.gn
[delete] https://crrev.com/d50b7b5d2fac65722d7cc3936cb8c7da827cb1dd/content/public/common/push_event_payload.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/renderer/service_worker/service_worker_context_client.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a87e03023a72417bd06f216aa1efa1fb8454001

commit 1a87e03023a72417bd06f216aa1efa1fb8454001
Author: Han Leon <leon.han@intel.com>
Date: Mon Aug 06 12:06:59 2018

[OnionSoup] Use blink.mojom.FetchAPIResponse for FetchEvent#respondWith

This CL is the 3rd step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

Note: Actually after this CL we can remove the Mojo method
content.mojom.ServiceWorkerFetchResponseCallback.OnResponseBlob by using
OnResponse instead, but to avoid a too big CL I'd like to do that with a
follow-up CL.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step: (this CL)
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I8c5740abf5e78d1d9b6e716ad692e33addb80e56
Reviewed-on: https://chromium-review.googlesource.com/1155999
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#580850}
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_fetch_response_callback.mojom
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_loader_helpers.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_type_util.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_type_util.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/third_party/blink/public/mojom/fetch/fetch_api_response.mojom

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3a2fb33b28236f18d85fb349136a1726bfec9c

commit 9a3a2fb33b28236f18d85fb349136a1726bfec9c
Author: Han Leon <leon.han@intel.com>
Date: Tue Aug 07 02:56:01 2018

[OnionSoup] Move service_worker_fetch_response_callback.mojom into Blink

https://chromium-review.googlesource.com/c/chromium/src/+/1155999
already decoupled service_worker_fetch_response_callback.mojom from
//content/ things, this CL just moves it from
//content/common/service_worker/ into
//third_party/blink/public/mojom/service_worker/.

BUG=789854

Change-Id: Id09ee5beb1086c57853927e2ba37115a55d97464
Reviewed-on: https://chromium-review.googlesource.com/1162991
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581106}
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/BUILD.gn
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/service_worker/controller_service_worker.mojom
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/controller_service_worker_impl.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/third_party/blink/public/mojom/service_worker/service_worker_fetch_response_callback.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03381bae89ae5c0aca0208c394f9a831507e0d1f

commit 03381bae89ae5c0aca0208c394f9a831507e0d1f
Author: Han Leon <leon.han@intel.com>
Date: Tue Aug 07 03:17:49 2018

[OnionSoup] Remove the Mojo method ServiceWorkerFetchResponseCallback.OnResponseBlob

This CL is a follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/1155999, after
that we can just transfer the blob body within FetchAPIResponse.blob, so
we no longer need this OnResponseBlob method to transfer the blob body
separately, just OnResponse is enough.

BUG=789854

Change-Id: Id54f5d6ded3576bedc2e7dcf544ed41ac7715069
Reviewed-on: https://chromium-review.googlesource.com/1163288
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#581118}
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/third_party/blink/public/mojom/service_worker/service_worker_fetch_response_callback.mojom

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f

commit fcd63c07fc107f2a4c1a2092c8fce9dda394e92f
Author: Han Leon <leon.han@intel.com>
Date: Mon Aug 13 01:29:21 2018

[OnionSoup] Remove [Native] content.mojom.ServiceWorkerResponse

This CL is the 4th step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706

3rd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1155999

4th step: (this CL)
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I85e6e9489dac50e1cc6905bd28a2d47b7a90fde7
Reviewed-on: https://chromium-review.googlesource.com/1164848
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582489}
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/service_worker/service_worker.mojom
[delete] https://crrev.com/3141871b4a173e2d74c5ff75f4cc2643c0595784/content/common/service_worker/service_worker.typemap
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/typemaps.gni
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/renderer/service_worker/service_worker_context_client.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0489ac9fd62a4bc6db924efaebce1365a582926d

commit 0489ac9fd62a4bc6db924efaebce1365a582926d
Author: Richard Li <richard.li@intel.com>
Date: Mon Aug 20 07:55:39 2018

[OnionSoup] remove content::ServiceWorkerResponse

This CL is the 5th step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706

3rd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1155999

4th step:
https://chromium-review.googlesource.com/c/chromium/src/+/1164848

5th step: (this CL)
- Remove content::ServiceWorkerResponse

Bug=789854

Change-Id: I527f76f79f8614acafd7e414f4c1044d8a7be64e
Reviewed-on: https://chromium-review.googlesource.com/1180738
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584378}
[modify] https://crrev.com/0489ac9fd62a4bc6db924efaebce1365a582926d/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/0489ac9fd62a4bc6db924efaebce1365a582926d/content/common/service_worker/service_worker_types.h

Blockedon: 877341
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca3a5e1cbb792be549303987e0fc387092f7ee81

commit ca3a5e1cbb792be549303987e0fc387092f7ee81
Author: Han Leon <leon.han@intel.com>
Date: Fri Aug 24 06:35:15 2018

[ServiceWorker] Remove the legacy IPC messages file

The legacy IPC struct traits of ServiceWorkerFetchRequest is no longer
used anywhere, so we can just remove it then remove the whole file
service_worker_messages.h.

BUG=789854

Change-Id: I4d4e8ab30d1fca562d6b738aad394d1eb73935e4
Reviewed-on: https://chromium-review.googlesource.com/1187901
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#585726}
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/common/BUILD.gn
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/common/content_message_generator.h
[delete] https://crrev.com/c3bf6a245cb334835b60e2b0b8a274e095f54ddd/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/content/renderer/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/ca3a5e1cbb792be549303987e0fc387092f7ee81/ipc/ipc_message_start.h

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 24

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf70c90e75549b9de74c38c912ced29e52b6d037

commit bf70c90e75549b9de74c38c912ced29e52b6d037
Author: Han Leon <leon.han@intel.com>
Date: Thu Aug 30 01:22:16 2018

[OnionSoup] Use mojom NotificationData instead of WebNotificationData inside Blink

This CL is part of Onion Soup effort for Notification APIs, trying to
use blink::mojom::blink::NotificationData everywhere instead of
blink::WebNotificationData inside Blink.

Also, this CL removes typemapping between blink::WebNotificationData and
blink.mojom.NotificationData, thus building notification.mojom no longer
needs to depend on WebXXX types, which makes it possible for us to move
notification.mojom into blink/public/mojom/notifications/ for next step,
further, notification.mojom movement will facilitate moving
content/common/service_worker/service_worker.mojom into
blink/public/mojom/ in future.

After this CL, the only usage of blink::WebNotificationData is to carry
notification data from Content layer into Blink, which is dispatched via
content.mojom.ServiceWorker.DispatchNotification{Click, Close}Event.

BUG= 595685 ,789854

Change-Id: I2ce6141c55fe874ab11f9f236b4734b9a9d79617
Reviewed-on: https://chromium-review.googlesource.com/1192360
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587362}
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/content/common/notifications/notification_struct_traits.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/content/common/notifications/notification_struct_traits.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/public/platform/modules/notifications/notification.mojom
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/public/platform/modules/notifications/notification_types.typemap
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/public/platform/modules/notifications/web_notification_data.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_data_test.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_manager.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_manager.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/notification_resources_loader_test.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.h
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/bf70c90e75549b9de74c38c912ced29e52b6d037/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits.cc
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits.h
[delete] https://crrev.com/504ec5fc0b9292c72e30692e95ab67f1e28ad7ea/third_party/blink/renderer/platform/mojo/notification_struct_traits_test.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8

commit abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8
Author: Han Leon <leon.han@intel.com>
Date: Thu Aug 30 02:08:10 2018

[OnionSoup] Move payment_{app,request}.mojom into blink/public/mojom/

As part of Onion Soup effort, blink/public/mojom/payments/ should be the
right place for payment_{app,request}.mojom, this CL moves them there
from blink/public/platform/modules/payments/.

This movement facilitates moving
//content/common/service_worker/service_worker.mojom into
blink/public/mojom/service_worker/ in future.

BUG=789854

Change-Id: Idaa2abacfefe706d05acbe8f23a7daea00f4ab66
Reviewed-on: https://chromium-review.googlesource.com/1192687
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587416}
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/android/BUILD.gn
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/DEPS
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/android/payments/service_worker_payment_app_bridge.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/payments/payment_request_factory.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/DEPS
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/android/BUILD.gn
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/android/payment_validator_android.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/installable_payment_app_crawler.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_converter.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_spec_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_state.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_request_web_contents_manager.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_response_helper.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/payment_response_helper_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/service_worker_payment_app_factory.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/service_worker_payment_app_factory_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/service_worker_payment_instrument.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/components/payments/content/service_worker_payment_instrument_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/DEPS
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_app_content_unittest_base.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_app_context_impl.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_app_database.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_app_provider_impl_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_instrument_icon_fetcher.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_manager.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/browser/payments/payment_manager_unittest.cc
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/common/BUILD.gn
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/public/browser/payment_app_provider.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/public/mojom/payments/OWNERS
[rename] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/public/mojom/payments/payment_app.mojom
[rename] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/public/mojom/payments/payment_request.mojom
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/basic_card_helper.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_address.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_instruments.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_manager.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_request.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_response.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payment_test_helper.h
[modify] https://crrev.com/abbe7c9042d2f5eb43711f02db6f6a2253cb7ad8/third_party/blink/renderer/modules/payments/payments_validators.h

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d567caa14b94d1bac1d72e9c4dac9b7458786629

commit d567caa14b94d1bac1d72e9c4dac9b7458786629
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Sep 06 16:12:00 2018

[Background Fetch] Stop setting blob data handle

on web_requests. This causes us to crash when converting
FetchAPIRequest mojo type to content::ServiceWorkerFetchRequest
since the latter doesn't currently support request body.

Once we switch to using the mojo type everywhere in content, we
can start setting the blob data handle  again from blink.

Bug: 789854, 774054
Change-Id: Icec9a74b9302fb9731febc5adc30f4153dfb698c
Reviewed-on: https://chromium-review.googlesource.com/1209522
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589184}
[modify] https://crrev.com/d567caa14b94d1bac1d72e9c4dac9b7458786629/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/d567caa14b94d1bac1d72e9c4dac9b7458786629/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3088d940b375915bf09d66deb23aeb612317f26b

commit 3088d940b375915bf09d66deb23aeb612317f26b
Author: Richard Li <richard.li@intel.com>
Date: Wed Oct 10 08:05:23 2018

[OnionSoup] Move SWFetchRequest::GetCMFLF into content::SWUtils

This CL is a preparation for removing content::SWFetchRequest.

SWFetchRequest::GetCacheModeFromLoadFlags() is moved into
content/common/service_worker/service_worker_utils.{h,cc}.

BUG=789854

Change-Id: I4cac6d5469b42384843c73a2157955c39ad4d7a3
Reviewed-on: https://chromium-review.googlesource.com/c/1270516
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598251}
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/common/service_worker/service_worker_utils_unittest.cc
[modify] https://crrev.com/3088d940b375915bf09d66deb23aeb612317f26b/content/renderer/service_worker/service_worker_context_client.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/251bace48c81ed135dad2043989a07a3891779b1

commit 251bace48c81ed135dad2043989a07a3891779b1
Author: Richard Li <richard.li@intel.com>
Date: Sat Oct 13 05:43:00 2018

[OnionSoup] Move content::SWFetchRequest::Serialize to SWUtils

In this CL, function in content::SWFetchRequest::Serialize is moved into
content::ServiceWorkerUtils::SerializeRequestData.

This work is a preparation for removing content::SWFetchRequest.

BUG=789854

Change-Id: Ic0867e4ee75a19488b92a62a44cd2bad14839a63
Reviewed-on: https://chromium-review.googlesource.com/c/1270519
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599488}
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/storage/get_initialization_data_task.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/browser/background_fetch/storage/start_next_pending_request_task.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/251bace48c81ed135dad2043989a07a3891779b1/content/common/service_worker/service_worker_utils.h

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83f2962634c177f2cdb2726247966781c6b37167

commit 83f2962634c177f2cdb2726247966781c6b37167
Author: Richard Li <richard.li@intel.com>
Date: Tue Oct 30 14:27:20 2018

[OnionSoup] de-couple typemapping of content::SWFetchRequest

This CL de-couples typemapping between content::SWFetchRequest and
blink::mojom::FetchAPIRequest. The target of this work is removing
content::SWFetchRequest.

Since content::SWFetchRequest is a widely used class. Removing it in one
CL resulting in unacceptable large size of CL.

In order to seperate the work into sereral steps. A converter was added
to make convertion between two structures in this CL.
In my plan, content::SWFetchRequest will be removed in a series of CLs
gradually.

The ultimate target of the whole work is moving fetch_api_request.mojom into
third_party/blink/public/mojom/fetch/ folder. To accomplish the goal, the
whole work is seperated into six parts.

1. Remove content::RequestContextType. Use blink.mojom.RequestContextType
instead. --------- CL:1229704

2. Remove content::ServiceWorkerFetchRequest. Use
blink.mojom.FetchAPIRequest instead.  --------This CL.

3. Remove blink::WebURLRequest::RequestContext. Use
blink.mojom.RequestContextType instead. --------- CL:1242301

4. Remove blink::WebServiceWorkerRequest. Use
blink.mojom.FetchAPIRequest instead.

5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy
instead.  --------- CL:1212345

6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer
instead.

Once all the above tasks get done, fetch_api_request.mojom can be moved
into that folder.


Change-Id: I2b299bd8b2830afffefe111716170c1a29e41098
Bug: 789854
Reviewed-on: https://chromium-review.googlesource.com/c/1288084
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603891}
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/background_fetch/storage/match_requests_task.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/BUILD.gn
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/background_fetch/background_fetch_struct_traits.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/background_fetch/background_fetch_types.h
[delete] https://crrev.com/d931b2e1e33f7feb25174acf1cd1cb93c660b11f/content/common/service_worker/service_worker_fetch_request.typemap
[delete] https://crrev.com/d931b2e1e33f7feb25174acf1cd1cb93c660b11f/content/common/service_worker/service_worker_fetch_request_mojom_traits.cc
[delete] https://crrev.com/d931b2e1e33f7feb25174acf1cd1cb93c660b11f/content/common/service_worker/service_worker_fetch_request_mojom_traits.h
[add] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/service_worker/service_worker_type_converter.cc
[add] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/service_worker/service_worker_type_converter.h
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/common/typemaps.gni
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/public/test/DEPS
[modify] https://crrev.com/83f2962634c177f2cdb2726247966781c6b37167/content/public/test/test_utils.h

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7062b825e72bcd739c1d3f293a7457be19f49c4

commit e7062b825e72bcd739c1d3f293a7457be19f49c4
Author: Leon Han <leon.han@intel.com>
Date: Mon Nov 05 06:36:50 2018

[OnionSoup] Remove typemapping of (blink.mojom.Referrer, blink::Referrer)

This CL removes the typemapping of
(blink.mojom.Referrer, blink::Referrer), a follow-up CL will remove the
typemapping of (blink.mojom.Referrer, content::Referrer), after that we
can move blink/public/platform/referrer.mojom into blink/public/mojom/.

BUG=789854

Change-Id: I9acb000e5f64939cd5898954e85f4288e2a88678
Reviewed-on: https://chromium-review.googlesource.com/c/1317344
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#605265}
[modify] https://crrev.com/e7062b825e72bcd739c1d3f293a7457be19f49c4/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/e7062b825e72bcd739c1d3f293a7457be19f49c4/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.cc
[modify] https://crrev.com/e7062b825e72bcd739c1d3f293a7457be19f49c4/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.h
[delete] https://crrev.com/17fc7e485c6cfdbdeeb5120401c0ca832c464e29/third_party/blink/renderer/platform/mojo/referrer.typemap
[delete] https://crrev.com/17fc7e485c6cfdbdeeb5120401c0ca832c464e29/third_party/blink/renderer/platform/mojo/referrer_struct_traits.h

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/963dc180197189c3809f5d429b4b18de11a35234

commit 963dc180197189c3809f5d429b4b18de11a35234
Author: Leon Han <leon.han@intel.com>
Date: Tue Nov 06 05:41:48 2018

[OnionSoup] Remove typemapping of (blink.mojom.Referrer, content::Referrer)

This CL removes the typemapping of
(blink.mojom.Referrer, content::Referrer) and leaves a TODO: replace
content::Referrer with blink::mojom::Referrer everywhere in the future.

Next step we can move blink/public/platform/referrer.mojom into
blink/public/mojom/.

BUG=789854

Change-Id: I70b52fe762a858d6425177604749ce4e85a7fc9c
Reviewed-on: https://chromium-review.googlesource.com/c/1317348
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#605603}
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/components/pdf/browser/pdf_web_contents_helper.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/components/pdf/browser/pdf_web_contents_helper.h
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/components/pdf/renderer/pepper_pdf_host.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/common/page_state_serialization.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/common/service_worker/service_worker_type_converter.cc
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/public/common/BUILD.gn
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/public/common/referrer.h
[delete] https://crrev.com/9d6b90094f06a4aa14159f8a35b19e95f9887aec/content/public/common/referrer.typemap
[delete] https://crrev.com/9d6b90094f06a4aa14159f8a35b19e95f9887aec/content/public/common/referrer_struct_traits.cc
[delete] https://crrev.com/9d6b90094f06a4aa14159f8a35b19e95f9887aec/content/public/common/referrer_struct_traits.h
[add] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/public/common/referrer_type_converters.cc
[add] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/public/common/referrer_type_converters.h
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/public/common/typemaps.gni
[modify] https://crrev.com/963dc180197189c3809f5d429b4b18de11a35234/content/renderer/render_view_impl.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075e0b30b260dfb7399d7c97291e55a90775cf5a

commit 075e0b30b260dfb7399d7c97291e55a90775cf5a
Author: Leon Han <leon.han@intel.com>
Date: Tue Nov 06 07:59:44 2018

[OnionSoup] Move referrer.mojom into blink/public/mojom

Based on https://crrev.com/c/1317344 and https://crrev.com/c/1317348,
this CL moves blink/public/platform/referrer.mojom into
blink/public/mojom, as part of Onion Soup efforts.

BUG=789854

Change-Id: I6832ae85d849ff5395da0b37b1cc7bfa63e1152f
Reviewed-on: https://chromium-review.googlesource.com/c/1319346
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#605627}
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/components/pdf/common/pdf.mojom
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/content/common/frame.mojom
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/content/public/common/referrer_type_converters.h
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/third_party/blink/public/mojom/referrer.mojom
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/third_party/blink/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/075e0b30b260dfb7399d7c97291e55a90775cf5a/third_party/blink/public/platform/web_url_request.h

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fad6942ba975d99d0f1a4fbece0b913bb354472d

commit fad6942ba975d99d0f1a4fbece0b913bb354472d
Author: Richard Li <richard.li@intel.com>
Date: Fri Nov 09 02:26:41 2018

[OnionSoup] Remove content::SWFetchRequest in background_fetch/ folder

The target of this CL is removing content::SWFetchRequest and use
blink::mojom::FetchAPIRequest instead. To keep a minor size of CL, the
operation is restricted in content/browser/background_fetch/. The final
goal is removing content::SWFetchRequest completely.

As a part of work of moving fetch_api_request.mojom, the roadmap is as
follow:

1. Remove content::RequestContextType. Use blink.mojom.RequestContextType
instead. --------- CL:1229704

2. Remove content::ServiceWorkerFetchRequest. Use
blink.mojom.FetchAPIRequest instead.  --------(CL:1288084 and This CL)

3. Remove blink::WebURLRequest::RequestContext. Use
blink.mojom.RequestContextType instead. --------- CL:1242301

4. Remove blink::WebServiceWorkerRequest. Use
blink.mojom.FetchAPIRequest instead.

5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy
instead.  --------- CL:1212345

6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer
instead.

Once all the above tasks get done, fetch_api_request.mojom can be moved
into third_party/blink/public/mojom/fetch/.

Bug: 789854
Change-Id: I9b442b3329293b21d483f468c3b4264526104b85
Reviewed-on: https://chromium-review.googlesource.com/c/1312673
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606707}
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_cross_origin_filter_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_metrics.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_metrics.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_request_info.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_request_info.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_request_match_params.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_request_match_params.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_scheduler_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/background_fetch_test_base.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/background_fetch/storage/match_requests_task.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/common/service_worker/service_worker_type_converter.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/common/service_worker/service_worker_type_converter.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/public/test/test_utils.cc
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/content/public/test/test_utils.h
[modify] https://crrev.com/fad6942ba975d99d0f1a4fbece0b913bb354472d/third_party/blink/public/platform/modules/fetch/fetch_api_request.mojom

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3d0916c3d5fbe90e40c878bdc78323183bfed4

commit cf3d0916c3d5fbe90e40c878bdc78323183bfed4
Author: Leon Han <leon.han@intel.com>
Date: Wed Nov 21 14:43:33 2018

[OnionSoup] Remove typemapping of (FetchAPIRequest, WebServiceWorkerRequest)

This CL removes typemapping of
(blink.mojom.FetchAPIRequest, blink::WebServiceWorkerRequest), instead,
we use blink::mojom::FetchAPIRequest struct directly.

This reduces lots of usages of blink::WebServiceWorkerRequest, now its
only usage is to carry the request data of a fetch event dispatched
towards a service worker, from //content across the boundary into Blink.

BUG=789854

Change-Id: Ife644a71941ea8db9f7798d414d49f2a0c61cf61
Reviewed-on: https://chromium-review.googlesource.com/c/1322360
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610047}
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/public/platform/modules/fetch/fetch_api_request.mojom
[delete] https://crrev.com/b54966e26dc1d83d4d35a1c0479edd387912987e/third_party/blink/public/platform/modules/fetch/fetch_api_request.typemap
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/public/platform/modules/service_worker/web_service_worker_request.h
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/core/fetch/fetch_request_data.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/core/fetch/fetch_request_data.h
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/core/fetch/request.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/core/fetch/request.h
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/core/fetch/request_test.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.h
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_manager_test.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/cache_storage/cache_test.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/modules/cache_storage/inspector_cache_storage_agent.cc
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/cf3d0916c3d5fbe90e40c878bdc78323183bfed4/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[delete] https://crrev.com/b54966e26dc1d83d4d35a1c0479edd387912987e/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.cc
[delete] https://crrev.com/b54966e26dc1d83d4d35a1c0479edd387912987e/third_party/blink/renderer/platform/mojo/fetch_api_request_struct_traits.h

Project Member

Comment 36 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c4627d5b85a8f2bc894c409cebbf85715416a33

commit 4c4627d5b85a8f2bc894c409cebbf85715416a33
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Dec 03 13:51:42 2018

Make FetchAPIRequest::headers use case insensitive Compare

This is a prerequisite step for using FetchAPIRequest instead of
ServiceWorkerFetchRequest. ServiceWorkerFetchRequest has a member |headers| with
CaseInsensitiveCompare, but FetchAPIRequest has a member |headers| with the
default Compare function, so that this will cause behavior changes. This CL is
to change FetchAPIRequest::headers to use CaseInsensitiveCompare.

Bug:  908344 , 789854
Change-Id: I8e1736d5c5ab2d291ff7c126afa0f4025983b84d
Reviewed-on: https://chromium-review.googlesource.com/c/1356463
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613074}
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/content/public/test/test_utils.cc
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/common/fetch/OWNERS
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/common/fetch/fetch_api_request_headers.typemap
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/common/fetch/fetch_api_request_headers_map.h
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/common/fetch/fetch_api_request_headers_mojom_traits.h
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/mojom/fetch/fetch_api_request.mojom
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/renderer/core/fetch/request_test.cc
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/renderer/platform/mojo/blink_typemaps.gni
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/renderer/platform/mojo/fetch_api_request_headers.typemap
[add] https://crrev.com/4c4627d5b85a8f2bc894c409cebbf85715416a33/third_party/blink/renderer/platform/mojo/fetch_api_request_headers_mojom_traits.h

Blockedon: 911930
Project Member

Comment 38 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6731e8592766f6ae89732409315591a95813260

commit c6731e8592766f6ae89732409315591a95813260
Author: Richard Li <richard.li@intel.com>
Date: Thu Dec 13 05:24:05 2018

[OnionSoup] Remove typemapping for content::BackgroundFetchSettledFetch

This CL de-couple the typemapping between
blink.mojom.BackgroundFetchSettledFetch and
content::BackgroundFetchSettledFetch.

content::BGFetchSettledFetch is remained since CloneResponse() and
CloneRequest() is widely used.

This work is a preparation for moving background_fetch.mojom

Bug: 789854
Change-Id: Ia4bb10a04e9e3f1b2878c2f84bc81d3b4466a857
Reviewed-on: https://chromium-review.googlesource.com/c/1371214
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616221}
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_job_controller.h
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/storage/match_requests_task.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/browser/background_fetch/storage/match_requests_task.h
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/common/BUILD.gn
[delete] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/content/common/background_fetch/background_fetch_struct_traits.cc
[delete] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/common/background_fetch/background_fetch_struct_traits_unittest.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/common/background_fetch/background_fetch_types.h
[delete] https://crrev.com/bd9f6fa837fe8a51a95b5c6996dddc7572c288d5/content/common/background_fetch/background_fetch_types.typemap
[modify] https://crrev.com/c6731e8592766f6ae89732409315591a95813260/content/common/typemaps.gni

Project Member

Comment 39 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912523f0f7bea33b9dd4817dcf4e182851361e77

commit 912523f0f7bea33b9dd4817dcf4e182851361e77
Author: Richard Li <richard.li@intel.com>
Date: Thu Dec 13 08:10:40 2018

[OnionSoup] Move background_fetch.mojom to blink/public/mojom/

This moves background_fetch.mojom from:
blink/public/platform/modules/background_fetch/
to:
blink/public/mojom/background_fetch/

TBRing reviewers:
jochen: Please reviewing changes in chrome/browser/DEPS

TBR=jochen@chromium.org

Bug: 789854
Change-Id: I0c67ae8e944d4e2c4c91da2511f933e6e91b9f70
Reviewed-on: https://chromium-review.googlesource.com/c/1370898
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#616241}
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/chrome/browser/DEPS
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[delete] https://crrev.com/7a3fba9b1e3a9b010b84faa8a41ad8a7baea035e/content/browser/background_fetch/DEPS
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_data_manager_observer.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_metrics.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_registration_notifier.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_registration_notifier_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_scheduler.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/background_fetch_service_impl.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/storage/database_task.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/storage/get_developer_ids_task.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/browser/background_fetch/storage/get_initialization_data_task.h
[delete] https://crrev.com/7a3fba9b1e3a9b010b84faa8a41ad8a7baea035e/content/common/background_fetch/DEPS
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/mojom/background_fetch/OWNERS
[rename] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/mojom/background_fetch/background_fetch.mojom
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/public/web/modules/service_worker/web_service_worker_context_proxy.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_event.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_record.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.h
[modify] https://crrev.com/912523f0f7bea33b9dd4817dcf4e182851361e77/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.h

Project Member

Comment 40 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e67748ac273e320e25d9567e244ccd4c030036

commit 99e67748ac273e320e25d9567e244ccd4c030036
Author: Richard Li <richard.li@intel.com>
Date: Thu Dec 20 05:28:13 2018

[OnionSoup] Merge service_worker.mojom from content/ into blink/

This CL merges content/common/service_worker/service_worker.mojom
into third_party/blink/public/mojom/service_worker/service_worker.mojom

service_worker.mojom in content/ is removed after merging.

Bug: 789854
Change-Id: I804c568e821628b3a8607408293289f50240930e
Reviewed-on: https://chromium-review.googlesource.com/c/1381793
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#618119}
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/background_fetch/background_fetch_event_dispatcher.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/common/BUILD.gn
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/common/service_worker/embedded_worker.mojom
[delete] https://crrev.com/be4f408af80e8194b9525dfdcbcca7075ded6679/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/third_party/blink/public/mojom/BUILD.gn
[modify] https://crrev.com/99e67748ac273e320e25d9567e244ccd4c030036/third_party/blink/public/mojom/service_worker/service_worker.mojom

Project Member

Comment 41 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32fb392021985f6cf40e4d40dccfd8c58404e0fb

commit 32fb392021985f6cf40e4d40dccfd8c58404e0fb
Author: Richard Li <richard.li@intel.com>
Date: Fri Dec 21 06:49:41 2018

[OnionSoup] Move service_worker_provider.mojom to blink/public/mojom/

This CL moves service_worker_provider.mojom from:
content/common/service_worker/
to:
third_party/blink/public/mojom/service_worker/

Bug: 789854
Change-Id: Ice3481fca77cdf1a51f823a8fa46ab17975f039f
Reviewed-on: https://chromium-review.googlesource.com/c/1388220
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#618472}
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/shared_worker_host_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/shared_worker_service_impl.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/worker_script_fetch_initiator.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/browser/worker_host/worker_script_fetch_initiator.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/common/BUILD.gn
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/32fb392021985f6cf40e4d40dccfd8c58404e0fb/third_party/blink/public/mojom/service_worker/service_worker_provider.mojom

Project Member

Comment 42 by bugdroid1@chromium.org, Yesterday (39 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2

commit 6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2
Author: Leon Han <leon.han@intel.com>
Date: Thu Jan 17 07:52:25 2019

[OnionSoup] Move worker_content_settings_proxy.mojom into blink/public/mojom/

This CL moves blink/public/web/worker_content_settings_proxy.mojom
into third_party/blink/public/mojom/worker/, in preparation for
onionsoupping some other mojom files using it.

BUG=789854

Change-Id: I366e3b98dd8f7327c7ac38c94fb3e24086cc0056
Reviewed-on: https://chromium-review.googlesource.com/c/1416560
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#623616}
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/browser/service_worker/DEPS
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/browser/service_worker/service_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/browser/worker_host/DEPS
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/browser/worker_host/shared_worker_content_settings_proxy_impl.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/public/mojom/worker/worker_content_settings_proxy.mojom
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/renderer/core/workers/shared_worker_content_settings_proxy.h
[modify] https://crrev.com/6ac123d132c09e64aaa15d6f1f4f96eee7cd80c2/third_party/blink/renderer/modules/service_worker/service_worker_content_settings_proxy.h

Sign in to add a comment