New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 845345

Blocking:
issue 789857



Sign in to add a comment

Eliminate //content/service_worker/common/*

Project Member Reported by leon....@intel.com, Nov 30 2017

Issue description

This belongs to Onion Soup effort for service worker.

For //content/service_worker/common/*:
  - some of them should be moved into //content/browser/service_worker/ to be used only by browser-side code.
  - some of them should be put into //third_party/WebKit/common/service_worker/ to be shared by both browser-side and renderer-side code.
  - some of them would disappear.
 

Comment 1 by leon....@intel.com, Nov 30 2017

I'd like to know your opinions on this, and also want to know the root issue number for service worker onion soup work so that we can make this one block it ;-)
Blocking: 789857
Thanks! 
There was no issue for onion soup, so I've created and assigned to leon.
And the plan makes sense to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c7a33557a8b46e3071d571edfdfcd0d822b171

commit 45c7a33557a8b46e3071d571edfdfcd0d822b171
Author: Han Leon <leon.han@intel.com>
Date: Fri Dec 01 03:25:50 2017

[ServiceWorker] Move ServiceWorkerFetchEventResult to be used only in browser code

enum ServiceWorkerFetchEventResult does not have to be a common type for
both browser and renderer code, this CL moves it out of
content/common/service_worker/service_worker_types.h, and also removes
the unnecessary IPC traits for it from
content/common/service_worker/service_worker_messages.h.

BUG=789854
TBR=tsepez@chromium.org

Change-Id: I6bda299731b71b8b5f9c493b1a785b7f9889f45b
Reviewed-on: https://chromium-review.googlesource.com/799551
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520834}
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/45c7a33557a8b46e3071d571edfdfcd0d822b171/content/common/service_worker/service_worker_types.h

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d228126d49ab626d7a40c739c4563e60ed8414ab

commit d228126d49ab626d7a40c739c4563e60ed8414ab
Author: Han Leon <leon.han@intel.com>
Date: Wed Dec 06 03:18:09 2017

[ServiceWorker] Move service_worker_installed_scripts_manager.mojom into WebKit/common/

This CL moves service_worker_installed_scripts_manager.mojom from
content/common/service_worker/ into
third_party/WebKit/common/service_worker/, in preparation to merge
content::WebServiceWorkerInstalledScriptsManagerImpl into Blink.

BUG=789854,789846

Change-Id: Ice64bb4ad56602370fc14fa6cd21fd124d454a42
Reviewed-on: https://chromium-review.googlesource.com/807761
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521981}
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_installed_scripts_sender_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/common/BUILD.gn
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.h
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl_unittest.cc
[modify] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/third_party/WebKit/common/BUILD.gn
[rename] https://crrev.com/d228126d49ab626d7a40c739c4563e60ed8414ab/third_party/WebKit/common/service_worker/service_worker_installed_scripts_manager.mojom

Blockedon: 845345
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90aedd869bf269b41942c52fbb39671bccd8a8a6

commit 90aedd869bf269b41942c52fbb39671bccd8a8a6
Author: Han Leon <leon.han@intel.com>
Date: Wed Jun 27 02:13:06 2018

[OnionSoup] Move service_worker_status_code.{cc,h} into Blink

This CL moves the ServiceWorkerStatusCode enum definition files
service_worker_status_code.{cc,h} from content/common/service_worker/
into Blink public folder. After that the ServiceWorkerStatusCode enum
is still available to be used by both browser and renderer code.

This CL also moves a TypeConverter for ServiceWorkerStatusCode into
Blink.

BUG=789854

Change-Id: Ie8032cb7474c7f90f17e58170a38b97263643fbd
Reviewed-on: https://chromium-review.googlesource.com/1114474
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#570635}
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/cleanup_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/cleanup_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/database_helpers.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/delete_registration_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_developer_ids_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_developer_ids_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_metadata_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_metadata_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_num_requests_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_num_requests_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/get_settled_fetches_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_registration_for_deletion_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/mark_request_complete_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/start_next_pending_request_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/start_next_pending_request_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/update_registration_ui_task.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_fetch/storage/update_registration_ui_task.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_database.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/push_messaging/push_messaging_router.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_registry.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_client_utils.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_core_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_context_wrapper.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_database.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_internals_ui.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_read_from_cache_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_object_host.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_object_host.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_status.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_unregister_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_unregister_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/browser/service_worker/service_worker_write_to_cache_job.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_event_dispatcher.typemap
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_messages.h
[delete] https://crrev.com/a18d47428d64d9ae3b4138b2bb97d113c2c95646/content/common/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/public/browser/push_messaging_service.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/public/test/service_worker_test_helpers.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/renderer/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/content/test/test_background_sync_manager.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/OWNERS
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/service_worker_status_code.cc
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/common/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/OWNERS
[rename] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/service_worker_status_code.h
[add] https://crrev.com/90aedd869bf269b41942c52fbb39671bccd8a8a6/third_party/blink/public/common/service_worker/service_worker_type_converters.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51e125af0ebb15f0e0715e42f3d56c14ef82b217

commit 51e125af0ebb15f0e0715e42f3d56c14ef82b217
Author: Han Leon <leon.han@intel.com>
Date: Wed Jul 04 04:21:02 2018

[OnionSoup] Define blink::ServiceWorkerStatusCode as "enum class'

This CL changes type of blink::ServiceWorkerStatusCode from 'enum' to
'enum class', then updates everywhere it is accessed.

BUG=789854

Change-Id: I837d8b0b06924f8f42fa7246231e654e364523f6
Reviewed-on: https://chromium-review.googlesource.com/1124102
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572469}
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_fetch/storage/delete_registration_task.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/cookie_store/cookie_store_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/notifications/platform_notification_context_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_client_utils.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_core_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_watcher_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_installed_scripts_sender.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_object_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_process_manager_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_read_from_cache_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_object_host.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_unregister_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/public/browser/push_messaging_service.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/public/test/service_worker_test_helpers.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/content/test/test_background_sync_manager.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/common/service_worker/service_worker_status_code.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/common/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/51e125af0ebb15f0e0715e42f3d56c14ef82b217/third_party/blink/public/common/service_worker/service_worker_status_code.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2072f0430b9caf99cc75680cf5baddd68b49c0f7

commit 2072f0430b9caf99cc75680cf5baddd68b49c0f7
Author: Han Leon <leon.han@intel.com>
Date: Tue Jul 10 09:44:13 2018

[ServiceWorker] Change ServiceWorkerStatusCode::kMax to kMaxValue

This CL renames ServiceWorkerStatusCode::kMax to kMaxValue and sets its
value as the highest enumerator value, this avoids switch statements
having to handle a sentinel no-op value and makes it easier to use
UMA_HISTOGRAM_ENUMERATION().
Then, this CL revises all related tests.

BUG=789854

Change-Id: Ic0e9ad8f9bf90bb3e2b08dc424957a2f3a545c52
Reviewed-on: https://chromium-review.googlesource.com/1125532
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573664}
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_fetch/background_fetch_event_dispatcher.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_fetch/storage/database_helpers.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/third_party/blink/common/service_worker/service_worker_status_code.cc
[modify] https://crrev.com/2072f0430b9caf99cc75680cf5baddd68b49c0f7/third_party/blink/public/common/service_worker/service_worker_status_code.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1525df4abd7e9b3b76e59de615a716d545dd92f

commit f1525df4abd7e9b3b76e59de615a716d545dd92f
Author: Han Leon <leon.han@intel.com>
Date: Wed Jul 11 03:47:59 2018

[OnionSoup] Remove ServiceWorkerUtils::IsServicificationEnabled()

This CL removes ServiceWorkerUtils::IsServicificationEnabled() and uses
blink::ServiceWorkerUtils::IsServicificationEnabled() instead.

BUG=789854

Change-Id: I89031cec6ccaa23a8ea0d711fb0e7684d9a370b1
Reviewed-on: https://chromium-review.googlesource.com/1125535
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#574064}
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/appcache/appcache_navigation_handle_core.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_script_loader_factory.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_script_loader.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_script_loader_factory.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/common/service_worker/service_worker_utils.h
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_timeout_timer.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/service_worker/service_worker_timeout_timer_unittest.cc
[modify] https://crrev.com/f1525df4abd7e9b3b76e59de615a716d545dd92f/content/renderer/shared_worker/embedded_shared_worker_stub.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00d598cb4ae00510a30326c3db46f9b0506e36d

commit d00d598cb4ae00510a30326c3db46f9b0506e36d
Author: Han Leon <leon.han@intel.com>
Date: Thu Jul 12 09:45:56 2018

[ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

This CL removes native struct ServiceWorkerProviderHostInfo and the
corresponding typemapping for it, instead, directly uses mojom struct
ServiceWorkerProviderHostInfo everywhere.

BUG=789854

Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
Reviewed-on: https://chromium-review.googlesource.com/1132847
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574516}
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/BUILD.gn
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/service_worker/service_worker_provider.mojom
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider.typemap
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_host_info.cc
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_host_info.h
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_struct_traits.cc
[delete] https://crrev.com/eef2c0be5716d8857f9ff7dce265e2569c8d333e/content/common/service_worker/service_worker_provider_struct_traits.h
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/common/typemaps.gni
[modify] https://crrev.com/d00d598cb4ae00510a30326c3db46f9b0506e36d/content/renderer/service_worker/service_worker_network_provider.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b80761c42842da1b6a8b5fbec6d3af406ef434f

commit 2b80761c42842da1b6a8b5fbec6d3af406ef434f
Author: Han Leon <leon.han@intel.com>
Date: Thu Jul 26 16:01:55 2018

[OnionSoup] Remove [Native] content.mojom.PlatformNotificationData

Currently service_worker.mojom defines a [Native] mojom struct
content.mojom.PlatformNotificationData using the legacy IPC struct
traits for the native struct content::PlatformNotificationData.

However, there is already existing a mojom struct
blink.mojom.NotificationData which is typemapped with
content::PlatformNotificationData, it's exactly fit to our needs, so,
this CL starts to use blink.mojom.NotificationData then removes
the [Native] content.mojom.PlatformNotificationData and the
corresponding legacy IPC struct traits.

BUG=789854

Change-Id: I20549a8feb3575341661b92a5993bf758e6174e1
Reviewed-on: https://chromium-review.googlesource.com/1149714
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#578321}
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/BUILD.gn
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/content_message_generator.h
[delete] https://crrev.com/d2e0f2c6027de3c9db038ff74af054b0171ce2df/content/common/platform_notification_param_traits.h
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/2b80761c42842da1b6a8b5fbec6d3af406ef434f/content/common/service_worker/service_worker.typemap

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969cf704c35ad42749d3a175b2f3033c45851f83

commit 969cf704c35ad42749d3a175b2f3033c45851f83
Author: Han Leon <leon.han@intel.com>
Date: Mon Jul 30 04:42:59 2018

[OnionSoup] Remove typemapping for blink.mojom.FetchAPIResponse

This CL is the 1st step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step:
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step:
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: Ibae19bcac50688360426ef8b736a3841ca59ff39
Reviewed-on: https://chromium-review.googlesource.com/1134731
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#578974}
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/get_settled_fetches_task.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_dispatcher_host.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_dispatcher_host.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/browser/service_worker/service_worker_browsertest.cc
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response.typemap
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response_mojom_traits.cc
[delete] https://crrev.com/fcee42fbf32f608c27dd82d1fab62e3cb9864226/content/common/service_worker/service_worker_fetch_response_mojom_traits.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/content/common/typemaps.gni
[modify] https://crrev.com/969cf704c35ad42749d3a175b2f3033c45851f83/third_party/blink/public/platform/modules/fetch/fetch_api_response.mojom

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604

commit 6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604
Author: Han Leon <leon.han@intel.com>
Date: Tue Jul 31 01:13:46 2018

[OnionSoup] Move blink.mojom.FetchAPIResponse into blink/public/mojom/fetch/

This CL is the 2nd step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step: (This CL)
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step:
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I9afad29a89887369c211cb46bce5bc98df16064f
Reviewed-on: https://chromium-review.googlesource.com/1149706
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579273}
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/content/common/DEPS
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/content/common/service_worker/service_worker_types_unittest.cc
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/OWNERS
[add] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/README.md
[rename] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/mojom/fetch/fetch_api_response.mojom
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/public/platform/modules/cache_storage/cache_storage.mojom
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/renderer/core/fetch/fetch_response_data.h
[modify] https://crrev.com/6bbe791f4e48ff0ce9b56b1c69d78ab40bd0e604/third_party/blink/renderer/core/fetch/response.h

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1deace1f39cbc605fa86973daeedb4cd70e1562

commit c1deace1f39cbc605fa86973daeedb4cd70e1562
Author: Han Leon <leon.han@intel.com>
Date: Fri Aug 03 03:52:53 2018

[OnionSoup] Remove struct content::PushEventPayload

Currently we have a [Native] mojom struct content.mojom.PushEventPayload
with a typemapping to the native struct content::PushEventPayload, we
use them to pass payload data when calling the Mojo call
content.mojom.ServiceWorker.DispatchPushEvent().

However, as content::PushEventPayload contains only 2 members: a string
containing real data and a bool indicating data's validity, and it has
no expectations to be expanded for now, so, we can just
use a base::Optional<string> to replace it, and correspondingly in mojom
we just needs a 'string? payload' for our
content.mojom.ServiceWorker.DispatchPushEvent().

This CL removes content::PushEventPayload by doing the above
replacement.

BUG=789854

Change-Id: I8df737165b3004db820e3b758c1bfa8bdb7b5690
Reviewed-on: https://chromium-review.googlesource.com/1149705
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#580445}
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/chrome/browser/push_messaging/push_messaging_service_unittest.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/browser_context.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/push_messaging/push_messaging_router.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/push_messaging/push_messaging_router.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker.typemap
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/public/browser/browser_context.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/public/common/BUILD.gn
[delete] https://crrev.com/d50b7b5d2fac65722d7cc3936cb8c7da827cb1dd/content/public/common/push_event_payload.h
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c1deace1f39cbc605fa86973daeedb4cd70e1562/content/renderer/service_worker/service_worker_context_client.h

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a87e03023a72417bd06f216aa1efa1fb8454001

commit 1a87e03023a72417bd06f216aa1efa1fb8454001
Author: Han Leon <leon.han@intel.com>
Date: Mon Aug 06 12:06:59 2018

[OnionSoup] Use blink.mojom.FetchAPIResponse for FetchEvent#respondWith

This CL is the 3rd step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

Note: Actually after this CL we can remove the Mojo method
content.mojom.ServiceWorkerFetchResponseCallback.OnResponseBlob by using
OnResponse instead, but to avoid a too big CL I'd like to do that with a
follow-up CL.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731
- Remove the typemapping of blink.mojom.FetchAPIResponse.
  The mojom struct blink.mojom.FetchAPIResponse describes a Response in
  terms of the concept from the Fetch spec, currently it's defined under
  blink/public/platform/modules/fetch/ and is used only by Cache Storage
  API implementation (by both Browser and Renderer code), as this struct
  meets the 2 conditions below, it should be fine to go into
  blink/public/mojom/:
     - it is expected to be used by both Browser and Renderer code.
     - it is expected to be passed over Mojo between Browser and
       Renderer (Blink).
  But, currently for Chromium Mojo binding variant it is typemapped to
  content::ServiceWorkerResponse being used in
  content/browser/cache_storage/, this blocks it being moved to
  blink/public/mojom/. So we need to remove this typemapping first, this
  removal also helps reduce 1 user of content::ServiceWorkerResponse.

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706
  Now we can just move blink.mojom.FetchAPIResponse into
  blink/public/mojom/fetch/, which makes the next steps possible.

3rd step: (this CL)
- Use blink.mojom.FetchAPIResponse to represent the response a service
  worker provides to FetchEvent#respondWith. Specifically, use this
  mojom struct to replace the existing [Native] mojom struct
  content.mojom.ServiceWorkerResponse in
  content/common/service_worker/service_worker_fetch_response_callback.mojom.
  Thus we can reduce another 1 user of content::ServiceWorkerResponse.
  More importantly, this makes it possible for us to move
  service_worker_fetch_response_callback.mojom into
  blink/public/mojom/service_worker/ in future.

4th step:
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I8c5740abf5e78d1d9b6e716ad692e33addb80e56
Reviewed-on: https://chromium-review.googlesource.com/1155999
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#580850}
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_fetch_response_callback.mojom
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_loader_helpers.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_type_util.cc
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/content/renderer/service_worker/service_worker_type_util.h
[modify] https://crrev.com/1a87e03023a72417bd06f216aa1efa1fb8454001/third_party/blink/public/mojom/fetch/fetch_api_response.mojom

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a3a2fb33b28236f18d85fb349136a1726bfec9c

commit 9a3a2fb33b28236f18d85fb349136a1726bfec9c
Author: Han Leon <leon.han@intel.com>
Date: Tue Aug 07 02:56:01 2018

[OnionSoup] Move service_worker_fetch_response_callback.mojom into Blink

https://chromium-review.googlesource.com/c/chromium/src/+/1155999
already decoupled service_worker_fetch_response_callback.mojom from
//content/ things, this CL just moves it from
//content/common/service_worker/ into
//third_party/blink/public/mojom/service_worker/.

BUG=789854

Change-Id: Id09ee5beb1086c57853927e2ba37115a55d97464
Reviewed-on: https://chromium-review.googlesource.com/1162991
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581106}
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/BUILD.gn
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/service_worker/controller_service_worker.mojom
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/controller_service_worker_impl.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/9a3a2fb33b28236f18d85fb349136a1726bfec9c/third_party/blink/public/mojom/service_worker/service_worker_fetch_response_callback.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03381bae89ae5c0aca0208c394f9a831507e0d1f

commit 03381bae89ae5c0aca0208c394f9a831507e0d1f
Author: Han Leon <leon.han@intel.com>
Date: Tue Aug 07 03:17:49 2018

[OnionSoup] Remove the Mojo method ServiceWorkerFetchResponseCallback.OnResponseBlob

This CL is a follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/1155999, after
that we can just transfer the blob body within FetchAPIResponse.blob, so
we no longer need this OnResponseBlob method to transfer the blob body
separately, just OnResponse is enough.

BUG=789854

Change-Id: Id54f5d6ded3576bedc2e7dcf544ed41ac7715069
Reviewed-on: https://chromium-review.googlesource.com/1163288
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#581118}
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/03381bae89ae5c0aca0208c394f9a831507e0d1f/third_party/blink/public/mojom/service_worker/service_worker_fetch_response_callback.mojom

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 13 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f

commit fcd63c07fc107f2a4c1a2092c8fce9dda394e92f
Author: Han Leon <leon.han@intel.com>
Date: Mon Aug 13 01:29:21 2018

[OnionSoup] Remove [Native] content.mojom.ServiceWorkerResponse

This CL is the 4th step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706

3rd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1155999

4th step: (this CL)
- Use blink.mojom.FetchAPIResponse to represent responses to background
  fetches. Specifically, use this mojom struct to replace the existing
  [Native] mojom struct content.mojom.ServiceWorkerResponse defined in
  content/common/service_worker/service_worker.mojom.
  Thus we can reduce the last 1 user of content::ServiceWorkerResponse.

5th step:
- Remove content::ServiceWorkerResponse and do any left cleanup.

BUG=789854

Change-Id: I85e6e9489dac50e1cc6905bd28a2d47b7a90fde7
Reviewed-on: https://chromium-review.googlesource.com/1164848
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582489}
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/browser/background_fetch/storage/get_settled_fetches_task.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_struct_traits.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_types.cc
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/background_fetch/background_fetch_types.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/service_worker/service_worker.mojom
[delete] https://crrev.com/3141871b4a173e2d74c5ff75f4cc2643c0595784/content/common/service_worker/service_worker.typemap
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/common/typemaps.gni
[modify] https://crrev.com/fcd63c07fc107f2a4c1a2092c8fce9dda394e92f/content/renderer/service_worker/service_worker_context_client.cc

Sign in to add a comment