New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789847 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

master-paladin: Incorrectly show "depends on CL, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set)." error

Project Member Reported by drinkcat@chromium.org, Nov 30 2017

Issue description

https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/17070

So we have 3 CLs:
https://chromium-review.googlesource.com/c/chromiumos/manifest/+/786138
https://chrome-internal-review.googlesource.com/c/chromeos/manifest-internal/+/512717
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/728102

The CQ-DEPEND graph is:
CL:786138 <=> CL:*512717
CL:786138 => CL:728102
CL:*512717 >= CL:728102

And all 3 CLs should be able to get submitted.

However, the following messages are posted on the CL:
CL:786138: CL:786138 depends on CL:728102, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
CL:*512717: CL:*512717 depends on CL:728102, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
CL:728102: The Commit Queue has picked up your change.

Looking at log:
https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fmaster-paladin%2F17070%2F%2B%2Frecipes%2Fsteps%2FCommitQueueSync%2F0%2Fstdout

18:23:48: INFO: Filtered changes: CL:*512717 CL:728102 CL:786138
...
18:24:57: INFO: Attempting to create transaction for chadversary:*512717:*73ad4af6
18:24:58: INFO: Failed creating transaction for chadversary:*512717:*73ad4af6: CL:*512717 depends on CL:728102, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
18:24:58: INFO: Attempting to create transaction for chadversary:786138:f929c96a
18:24:59: INFO: Failed creating transaction for chadversary:786138:f929c96a: CL:786138 depends on CL:728102, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
18:24:59: INFO: The following changes could not cleanly be applied to ToT: *chromeos/manifest-internal~master~Ifd08ef44f1c9e01aec362c077a63e310999a85a9 chromiumos/manifest~master~Ia14d4b51b29957cc4681df04be7a877a530939d5
18:24:59: INFO: Change chadversary:*512717:*73ad4af6 did not apply cleanly.
18:25:02: INFO: Running cidb query on pid 26326, repr(query) starts with <sqlalchemy.sql.expression.Insert object at 0x7f3152dff2d0>
18:25:03: INFO: Change chadversary:786138:f929c96a did not apply cleanly.
18:25:09: INFO: Running cidb query on pid 26326, repr(query) starts with <sqlalchemy.sql.expression.Insert object at 0x7f3152dff450>
...
18:26:06: INFO: RunCommand: git fetch -f https://chromium-review.googlesource.com/chromiumos/overlays/chromiumos-overlay refs/changes/83/797683/4 refs/changes/52/791252/5 refs/changes/53/795053/6 refs/changes/02/728102/6 in /b/c/cbuild/repository/src/third_party/chromiumos-overlay

But then all 3 changes are actually applied:

18:26:52: INFO: Attempting to apply change basni:728102:bf9c85ec:"media-libs/arc-mesa: rename --enable-omx to --enable-omx-bellagio."
18:26:52: INFO: Applying via cherry-pick.
Trying simple merge.
Simple merge failed, trying Automatic merge.
Auto-merging media-libs/arc-mesa/arc-mesa-9999.ebuild
[patch_branch 1625d9ee2ed] media-libs/arc-mesa: rename --enable-omx to --enable-omx-bellagio.
 Author: Bas Nieuwenhuizen <basni@chromium.org>
 Date: Thu Oct 19 14:18:52 2017 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
18:26:52: INFO: Attempting to apply change chadversary:786138:f929c96a:"arc-mesa: Move to branch arc-17.3"
18:26:52: INFO: Applying via cherry-pick.
Trying simple merge.
Simple merge failed, trying Automatic merge.
Auto-merging full.xml
[patch_branch 96bf8c6] arc-mesa: Move to branch arc-17.3
 Author: Chad Versace <chadversary@chromium.org>
 Date: Wed Nov 22 10:37:33 2017 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)
18:26:52: INFO: Attempting to apply change chadversary:*512717:*73ad4af6:"arc-mesa: Move to branch arc-17.3"
18:26:53: INFO: Applying via cherry-pick.
Trying simple merge.
Simple merge failed, trying Automatic merge.
Auto-merging external_full.xml
[patch_branch 1148b5f] arc-mesa: Move to branch arc-17.3
 Author: Chad Versace <chadversary@chromium.org>
 Date: Wed Nov 22 10:37:33 2017 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)

The false warning on the 2 CLs is confusing...

https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/17071 appears to have picked the 3 CLs just fine.

(instead, I see:
22:53:14: INFO: Ignoring dependency errors for chadversary:*512717:*73ad4af6 due to grace period
22:53:14: INFO: Ignoring dependency errors for chadversary:786138:f929c96a due to grace period
)
 

Comment 1 by cindyb@chromium.org, May 31 2018

Hi, this bug has not been updated recently and remains untriaged. Please acknowledge the bug and provide status within two weeks (6/8/2018), or the bug will be closed. Thank you.
Status: WontFix (was: Untriaged)
I assume WontFix. No point trying to figure out what was going on 6 months after the fact.

Sign in to add a comment