New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users
Status: Fixed
Owner:
Closed: Dec 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment
chromium-pfq/-release: BuildPackages: chromeos-chrome: Command 'lsb_release -a' returned non-zero exit status 3
Project Member Reported by drinkcat@chromium.org, Nov 30 Back to list
https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic-chromium-pfq/builds/11021
https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic-chromium-pfq/builds/11022

chromeos-chrome-64.0.3281.0_rc-r1: Installing setuptools, pip, wheel...
chromeos-chrome-64.0.3281.0_rc-r1:   Complete output from command /build/amd64-generic...c29875/bin/python2.7 - setuptools pip wheel:
chromeos-chrome-64.0.3281.0_rc-r1:   Exception:
chromeos-chrome-64.0.3281.0_rc-r1: Traceback (most recent call last):
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/basecommand.py", line 215, in main
chromeos-chrome-64.0.3281.0_rc-r1:     status = self.run(options, args)
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/commands/install.py", line 272, in run
chromeos-chrome-64.0.3281.0_rc-r1:     with self._build_session(options) as session:
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/basecommand.py", line 72, in _build_session
chromeos-chrome-64.0.3281.0_rc-r1:     insecure_hosts=options.trusted_hosts,
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/download.py", line 329, in __init__
chromeos-chrome-64.0.3281.0_rc-r1:     self.headers["User-Agent"] = user_agent()
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/download.py", line 93, in user_agent
chromeos-chrome-64.0.3281.0_rc-r1:     from pip._vendor import distro
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/_vendor/distro.py", line 1050, in <module>
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/_vendor/distro.py", line 594, in __init__
chromeos-chrome-64.0.3281.0_rc-r1:   File "/build/amd64-generic/tmp/portage/chromeos-base/chromeos-chrome-64.0.3281.0_rc-r1/temp/vpython_bootstrap614013661/packages/virtualenv-15.1.0/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl/pip/_vendor/distro.py", line 933, in _get_lsb_release_info
chromeos-chrome-64.0.3281.0_rc-r1: CalledProcessError: Command 'lsb_release -a' returned non-zero exit status 3
chromeos-chrome-64.0.3281.0_rc-r1: ----------------------------------------
chromeos-chrome-64.0.3281.0_rc-r1: ...Installing setuptools, pip, wheel...done.
chromeos-chrome-64.0.3281.0_rc-r1: Traceback (most recent call last):
chromeos-chrome-64.0.3281.0_rc-r1:   File "virtualenv.py", line 2328, in <module>
chromeos-chrome-64.0.3281.0_rc-r1:     main()
chromeos-chrome-64.0.3281.0_rc-r1:   File "virtualenv.py", line 713, in main
chromeos-chrome-64.0.3281.0_rc-r1:     symlink=options.symlink)
chromeos-chrome-64.0.3281.0_rc-r1:   File "virtualenv.py", line 945, in create_environment
chromeos-chrome-64.0.3281.0_rc-r1:     download=download,
chromeos-chrome-64.0.3281.0_rc-r1:   File "virtualenv.py", line 901, in install_wheel
chromeos-chrome-64.0.3281.0_rc-r1:     call_subprocess(cmd, show_stdout=False, extra_env=env, stdin=SCRIPT)
chromeos-chrome-64.0.3281.0_rc-r1:   File "virtualenv.py", line 797, in call_subprocess
chromeos-chrome-64.0.3281.0_rc-r1:     % (cmd_desc, proc.returncode))
chromeos-chrome-64.0.3281.0_rc-r1: OSError: Command /build/amd64-generic...c29875/bin/python2.7 - setuptools pip wheel failed with error code 2

https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic-chromium-pfq/builds/11020 was good (tag 64.0.3280.5), bad from tag 64.0.3281.0.
 
Summary: chromium-pfq: BuildPackages: chromeos-chrome: Command 'lsb_release -a' returned non-zero exit status 3 (was: chromium-pfq: BuildPackages: chromeos-chrome: )
Cc: slavamn@chromium.org vapier@chromium.org ayatane@chromium.org chirantan@chromium.org athilenius@chromium.org
Labels: -Pri-1 Pri-0
Owner: ayatane@chromium.org
Status: Assigned
I was not able to reproduce using the SimpleChrome workflow.

After hitting  issue 770508  (interestingly ensure_bootstrap fails with this same lsb_release error, so I ran it outside of the chroot), I could repro using:

(~/chromium synced to 64.0.3281.0)
cros_sdk --chrome_root=${HOME}/chromium
cros_workon-$BOARD start chromeos-chrome
emerge-$BOARD -av chromeos-chrome

Then 64.0.3280.5 also failed, so the problem is not in Chrome.

lsb_release seems broken in the chroot:

$ lsb_release -a; echo $?
LSB Version:	n/a
Distributor ID:	Gentoo
Description:	(none)
Release:	n/a
Codename:	n/a
3 <<< Return code

Moving lsb_release away fixes the issue (at least hooks don't fail, I didn't try to install them all):
sudo mv /usr/bin/lsb_release /usr/bin/lsb_release.x

Asking a colleague, he does not have lsb_release in his chroot, so some package is pulling it in now...

$ equery d lsb-release
 * These packages depend on lsb-release:
dev-ruby/facter-2.4.1 (test ? sys-apps/lsb-release)
                      (sys-apps/lsb-release)
$ equery d facter
 * These packages depend on facter:
app-admin/puppet-3.7.3 (ruby_targets_ruby19 ? >=dev-ruby/facter-1.6.2[ruby_targets_ruby19])
                       (ruby_targets_ruby19 ? <dev-ruby/facter-3[ruby_targets_ruby19])
                       (ruby_targets_ruby20 ? >=dev-ruby/facter-1.6.2[ruby_targets_ruby20])
                       (ruby_targets_ruby20 ? <dev-ruby/facter-3[ruby_targets_ruby20])
$ equery d puppet
 * These packages depend on puppet:
virtual/target-chromium-os-sdk-1-r92 (app-admin/puppet)

=> blaming https://chromium-review.googlesource.com/794346
Tried to revert here: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/798916, vapier commented that it's probably not the right thing to do...
One way would be to fix pip to ignore return value 3, just like it ignores 127 (or it could just parse the data like it does with return value 0): https://github.com/pypa/pip/blob/master/src/pip/_vendor/distro.py#L928

But I'm not sure how that would play with vpython (and if it's possible to apply a local patch).

Another way would be to "fix" lsb_release to not return 3 (I tested that locally by dropping the line 'EXIT_STATUS=$ERROR_NOANSWER' and that seems to work, but I'm not sure of the consequences...)
Summary: chromium-pfq/-release: BuildPackages: chromeos-chrome: Command 'lsb_release -a' returned non-zero exit status 3 (was: chromium-pfq: BuildPackages: chromeos-chrome: Command 'lsb_release -a' returned non-zero exit status 3)
Most of the -release builders are broken too, e.g.:
https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-release/builds/1719
Owner: vapier@chromium.org
i've posted some CLs to fix it:
  https://chromium-review.googlesource.com/801614
  https://chromium-review.googlesource.com/801495
Cc: xixuan@chromium.org drinkcat@chromium.org kirtika@chromium.org
 Issue 790774  has been merged into this issue.
Project Member Comment 9 by bugdroid1@chromium.org, Dec 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/16e6862363c708c6ff76f91f9417ba2f7873e805

commit 16e6862363c708c6ff76f91f9417ba2f7873e805
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Dec 01 04:30:10 2017

lsb-release: update to 1.4-r3

Pull in the latest version from Gentoo.

BUG= chromium:789839 
TEST=`emerge lsb-release && lsb_release -a` works now
CQ-DEPEND=CL:801614

Change-Id: I103f6d98a27fe8a8ab1d89733c12154c49f3e46c
Reviewed-on: https://chromium-review.googlesource.com/801495
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/16e6862363c708c6ff76f91f9417ba2f7873e805/sys-apps/lsb-release/metadata.xml
[delete] https://crrev.com/5ff712424cdfe0cf2fe6d3cd2eaa434499f40aed/sys-apps/lsb-release/lsb-release-1.4.ebuild
[add] https://crrev.com/16e6862363c708c6ff76f91f9417ba2f7873e805/sys-apps/lsb-release/lsb-release-1.4-r3.ebuild

Project Member Comment 10 by bugdroid1@chromium.org, Dec 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/58059546fad23f0e202898d21e566465bff12c8c

commit 58059546fad23f0e202898d21e566465bff12c8c
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Dec 01 04:30:10 2017

lsb-release: install a full custom /etc/lsb-release file

If this package is installed into the sdk, make sure the
/etc/lsb-release file reflects our distro.

BUG= chromium:789839 
TEST=`emerge lsb-release && lsb_release -a` works now

Change-Id: Ib8d841ecec4ac3970e2146c441c7dbb545f4b8b1
Reviewed-on: https://chromium-review.googlesource.com/801614
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[add] https://crrev.com/58059546fad23f0e202898d21e566465bff12c8c/chromeos/config/env/sys-apps/lsb-release

Status: Fixed
lemme know if bots don't cycle green
I kicked a pfq run:
https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-generic-chromium-pfq/builds/11028

Looking good (chromeos-chrome is building for a while and hasn't failed yet, so I think it's fine).

Thanks!
Issue 791606 has been merged into this issue.
Sign in to add a comment