UI glitch and crash with multi-profile selection menu |
||||||||
Issue description
Chrome Version : 64.0.3274.0
OS Version: 10166.0.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari:
Firefox:
IE/Edge:
What steps will reproduce the problem?
1. Have 2+ users on a Chromebook
2. Sign in as one of the users
3. Click on the system tray
4. Click on the user profile icon
5. The multi-profile popup that says "Sign in another user..." shows up
6. Click on the wallpaper
7. The multi-profile popup remains on the screen (UI glitch)
8. Click on the system tray again
9. Crash
What is the expected result?
No bad behaviors
What happens instead of that?
UI glitch (step 7) + Crash (step 9)
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10166.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3274.0 Safari/537.36
,
Nov 30 2017
I can repro. It looks this crash doesn't happen with clicks but touches.
,
Nov 30 2017
I can repro. It looks this crash doesn't happen with clicks but touches.
,
Nov 30 2017
This is a new regression as I could not reproduce it on latest 63 with touch Also can't reproduce using mouse on a non-touch device on 64.0.3270.0
,
Dec 4 2017
Let me fix this. I'm recently looking the code around the system tray.
,
Dec 8 2017
The CL under review: https://chromium-review.googlesource.com/c/chromium/src/+/813153
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae2446be3d11e6393c0bc8567f953212babc63c commit 3ae2446be3d11e6393c0bc8567f953212babc63c Author: yoshiki iguchi <yoshiki@chromium.org> Date: Wed Dec 13 06:26:28 2017 Make SystemTrayView owned by the view hierarchy Previously, I have added SystemTrayView class which was owned by SystemTray class (crrev.com/727379). But the views in the tray are assumed to be destroyed with the parent view and the bubble, so that caused some issues. This patch changes that and makes SystemTrayView owned by the view hierarchy. Then the issues are solved. This patch also updates the newly-added code in NetworkStateListDetaiedView because the code didn't assume that lifetime of views. Bug: 790716 , 789833 Change-Id: I62eca328780cabb7c5d68967cc1ddee7a1e23b9a Reviewed-on: https://chromium-review.googlesource.com/813153 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#523701} [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/network/network_state_list_detailed_view.h [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/tray/system_tray.cc [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/tray/system_tray.h [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/tray/system_tray_bubble.cc [modify] https://crrev.com/3ae2446be3d11e6393c0bc8567f953212babc63c/ash/system/tray/system_tray_bubble.h
,
Dec 15 2017
,
Dec 15 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21 2017
Added M-64 label to ensure captured in search. This appears to be a rather large update into beta. We've been experiencing a number of crashes that may be tied to this, however. Related?
,
Jan 17 2018
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d commit 04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Jan 30 02:13:29 2018 Make SystemTrayView owned by the view hierarchy Previously, I have added SystemTrayView class which was owned by SystemTray class (crrev.com/727379). But the views in the tray are assumed to be destroyed with the parent view and the bubble, so that caused some issues. This patch changes that and makes SystemTrayView owned by the view hierarchy. Then the issues are solved. This patch also updates the newly-added code in NetworkStateListDetaiedView because the code didn't assume that lifetime of views. TBR=yoshiki@chromium.org (cherry picked from commit 3ae2446be3d11e6393c0bc8567f953212babc63c) Bug: 790716 , 789833 Change-Id: I62eca328780cabb7c5d68967cc1ddee7a1e23b9a Reviewed-on: https://chromium-review.googlesource.com/813153 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523701} Reviewed-on: https://chromium-review.googlesource.com/892194 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#613} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/network/network_state_list_detailed_view.h [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/tray/system_tray.cc [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/tray/system_tray.h [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/tray/system_tray_bubble.cc [modify] https://crrev.com/04c03c427c9ab5ccb28e01969b2cf5a1cfb9752d/ash/system/tray/system_tray_bubble.h
,
Jan 30 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by satorux@chromium.org
, Nov 30 2017