Use "Add to" rather than "Install to" in UI for PWAs |
||||||||||||
Issue descriptionBookmark apps currently use "Add to" in menu items and dialogs. We will use "Install to" when referring to the installation of progressive web apps.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dc69088fa2d1acbd95c6b2ab50467e9fe36be30 commit 4dc69088fa2d1acbd95c6b2ab50467e9fe36be30 Author: Michael McGreevy <mcgreevy@chromium.org> Date: Thu Dec 07 00:41:24 2017 Use "Install to" strings for installable apps. This uses "install to" instead of "add to" in both the app menu and the confirmation dialog for known-installable apps. The choice of string for the app menu does not block on the installability check, but uses the result of the installability check if available. Bug: 789817 Change-Id: Ic73194b41766f98dfcfdba293b70b56319af9fe3 Reviewed-on: https://chromium-review.googlesource.com/798914 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#522277} [modify] https://crrev.com/4dc69088fa2d1acbd95c6b2ab50467e9fe36be30/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/4dc69088fa2d1acbd95c6b2ab50467e9fe36be30/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/4dc69088fa2d1acbd95c6b2ab50467e9fe36be30/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/4dc69088fa2d1acbd95c6b2ab50467e9fe36be30/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
,
Dec 19 2017
,
Jan 9 2018
There was some pushback on this string. I think it's good to have this logic and distinguish the PWA vs non-PWA cases, but we may need to workshop the exact strings some more. Re-opening this for now.
,
Jan 9 2018
,
Feb 21 2018
Also there is an inconsistency in the dialog. The button still says "Add" while the other strings say "Install". Will await final UI/Strings approval.
,
Feb 22 2018
Hi - Hwi & I chatted, the UX recommendation is to use "Add" instead of "Install," for a couple of reasons: 1) Consistency with mobile, which uses "Add" to avoid the impression that the PWA is taking space on your device. 2) Even for desktop, where space may be less of a concern, "Add" conveys a more lightweight feeling than "Install", and is the opposite of "Remove" which we currently use. This would affect the dialog title and the action in the three-dot menu: Install to shelf > Add to shelf CTA in dialog is currently "Add", so no change needed there.
,
Feb 22 2018
Minor addendum: dialog title also needs a question mark b/c this is in essence a confirmation dialog. "Add to shelf?"
,
Feb 23 2018
OK, we can revert or partially-revert r522277. Assigning to Alan. Also note #8.
,
Mar 13 2018
Some users are confused by our current string: https://crbug.com/815067#c3
,
Mar 14 2018
#10 the confusion there is that a site with a manifest uses the start_url instead of the current URL. So there are two different behaviours depending on whether the site has a manifest or not.
Does anybody know if this is true only for PWAs or all sites with a manifest? The conclusion those people came to on that bug ("The fact that "Add to Home screen" sometimes adds the current page sometimes uses the website's manifest makes things inconsistent. I would recommend at doing a variation in the [wording], like "Add app to Home screen" when it's a webapp with a manifest.") suggests that we *are* doing the right thing by having two separate strings.
It sounds like there are in fact three cases:
1. No manifest. "Add to shelf" adds the current URL.
2. Manifest, not PWA. "Add to shelf" adds the manifest start_url.
3. PWA. "Install to shelf" adds the manifest start_url.
Having a different string to differentiate this case is helpful. Maybe we need to fix Case 2, by ignoring the manifest when it is not a full PWA.
,
Mar 14 2018
hmmm based on #7 I thought we decided *not* to have to separate strings, so all three cases use "Add to shelf". I agree that using separate strings is the right thing, so the point I was trying to make is that by using the same string (as we do on Android right now and we'll do for desktop according to #7) is causing confusion for users.
,
Mar 14 2018
Ah right. I didn't realise this was Android (which is why I thought the problem was Case 2 above).
Ignoring that (which may or may not be a problem), we should reconsider this because I agree, having two quite different behaviours with the same string is confusing.
srahim: Can you comment on this? If you really want us to stick with just one string ("Add to shelf/desktop") we can, but please note that if it's a PWA, "Add to shelf" will add the *current app* to the shelf (which may be a generic top-level start page), but if it's not a PWA, "Add to shelf" will add the *current page* to the shelf.
Possible alternative strings:
"Add app to shelf"
"Add <APPNAME> to shelf" (sync up with the Open string on https://crbug.com/819457#c11 ).
,
Mar 22 2018
I'm in favour of having some form of differentiation in the string particularly due to the confusion brought up by #10. "Add <APPNAME> to shelf" SGTM.
,
Mar 22 2018
,
Mar 22 2018
Thanks alancutter@! Looking good. Per #c8, we need to add a question mark in the new-title. i.e. "Add to shelf?"
,
Mar 23 2018
Thanks for catching that, added to WIP CL. https://chromium-review.googlesource.com/c/chromium/src/+/977181
,
Mar 26 2018
Issue 796520 has been merged into this issue.
,
Mar 26 2018
,
Mar 27 2018
,
Mar 27 2018
P1 due to changes to strings that need to be in by March 30 for translation.
,
Mar 27 2018
Pri-1 because string change.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58708cd9ed138fc7200ca9a778e141df96112d8b commit 58708cd9ed138fc7200ca9a778e141df96112d8b Author: Alan Cutter <alancutter@chromium.org> Date: Wed Mar 28 02:40:14 2018 Replace "Install to shelf" menu text with "Add <app name> to shelf" This CL changes the menu text shown to install a PWA associated with the current tab. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=330743&signed_aid=vpIA4CZv_wTkqapJ5jyo4A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=330745&signed_aid=zwKzH1VLr_wZiJbGjw33GA==&inline=1 This also updates the installation prompt dialog to say "Add to shelf?" instead of "Install to shelf". Bug: 789817 Change-Id: I66eaf6929a445a7f59bcfdfc6159bcfd1b8de700 Reviewed-on: https://chromium-review.googlesource.com/977181 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#546372} [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/app/generated_resources.grd [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager_android.cc [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager_android.h [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager_desktop.cc [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/banners/app_banner_manager_desktop.h [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/58708cd9ed138fc7200ca9a778e141df96112d8b/chrome/browser/ui/toolbar/app_menu_model.cc
,
Mar 28 2018
,
Mar 28 2018
Chrome OS UI don't like either the old or the new string: "The string seems off to us. It is not about the shelf here but about adding this to your apps. We can just say "Install <app>"" This feels reasonable to me, but is at odds with #7 in this thread. Shimi, what do you think? The other problem is we have string freeze tomorrow. I am on vacation now (have no code review access) and my team is only available today (on vacation tomorrow). If we can come to an agreement today, we can land a string change, but this has gone back and forth a lot.
,
Mar 28 2018
CL to use "Install <app>...": https://chromium-review.googlesource.com/c/chromium/src/+/984916
,
Mar 29 2018
Screenshots of WIP before and after changes for PWA menu + title strings.
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7 commit a0632f584b74cfc212e4dd3b2753ca748a0bdfc7 Author: Alan Cutter <alancutter@chromium.org> Date: Thu Mar 29 07:07:45 2018 Update PWA and non-PWA shortcut menu and title texts This CL implements recommendations from a Desktop PWA UI review. - Use "Install <app>..." instead of "Add <app> to shelf..." for PWAs. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331947&signed_aid=9D-HKXE7gYd0wUpreYCSAg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331948&signed_aid=cDTnW4abw74CAZfks6FXkw==&inline=1 - Use "Create shortcut" instead of "Add to <shortcut container>" for non-PWAs. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331943&signed_aid=Ok3VbYPcM5cA0kp1mufUcQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331944&signed_aid=Jn3zF1Bjunr7NY6U5HZs-Q==&inline=1 In addition to these changes the confirmation dialog for these actions have been updated for consistency: - For PWAs: Use "Install app?" instead of "Add to shelf?" for the title. Use "Install" instead of "Add" for the button. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331949&signed_aid=NBRq_H4GTrT_Nlj4uJZUgg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331957&signed_aid=yEqown9Qn32Do3_UyXfbGw==&inline=1 - For non-PWAs: Use "Create shortcut?" instead of "Add to shelf" for the title. Use "Create" instead of "Add" for the button. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331945&signed_aid=vHvplIxwxZt1AbSCXNlRug==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331958&signed_aid=y82Q7ebdDf31vnnHy_vqcg==&inline=1 Bug: 789817 , 822305 Change-Id: Ib2fbe35f43b575a985af6c50094235dc7693a149 Reviewed-on: https://chromium-review.googlesource.com/984916 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#546753} [modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/app/generated_resources.grd [modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc [modify] https://crrev.com/a0632f584b74cfc212e4dd3b2753ca748a0bdfc7/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
,
Mar 29 2018
Fix landed. Thanks Alan, Shimi and Hwi for stepping in at the last minute to help out with this! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 30 2017