ReportBadMessageCallback should invoke the connection error handler? |
|||
Issue descriptionCurrently, for all mojo::[Strong][Associated]Binding[Set], when received a bad message, their ReportBadMessageCallback will just close current dispatch connection, but won't invoke the connection error handler to notify user about this. The question is: should we consider such disconnection scenario caused by receiving a bad message as one type of connection error and fire the connection error handler for it? This issue comes up from https://chromium-review.googlesource.com/c/chromium/src/+/778360/13/mojo/public/cpp/bindings/binding_set.h#188
,
Nov 30 2017
Hi, Ken. Given it is an explicit action by the binding user which guarantees to close the Binding object, I slightly lean towards keeping the current behavior, and documenting it more clearly. I feel that it is a little different from other standard validation errors in that the standard errors are automatically handled, without an action from the user. So we need a way to notify the user in that case. WDYT? Thanks!
,
Oct 17
,
Jan 8
Since this argument hasn't come up again, closing the ticket and will reopen the discussion if necessary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by roc...@chromium.org
, Nov 30 2017