New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789815 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Convert ChromeViewMsg_SetAsInterstitial to use mojo.

Project Member Reported by cm.san...@samsung.com, Nov 30 2017

Issue description

This is a tracking bug to eliminate legacy ChromeViewMsg_SetAsInterstitial IPC.

 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/379b785aca740242b5b2840c3a52a90fb2351be5

commit 379b785aca740242b5b2840c3a52a90fb2351be5
Author: cm.sanchi <cm.sanchi@samsung.com>
Date: Tue Jan 09 13:02:11 2018

Convert ChromeViewMsg_SetAsInterstitial to use mojo.

This patch mojofies the SetAsInterstitial message
and also Consolidates tiny mojo interfaces.

Bug:  789815 
Change-Id: I0b56ae2623ab315f24c4b0a06dc39ff8b858d9a0
Reviewed-on: https://chromium-review.googlesource.com/795591
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527978}
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/browser/chrome_content_renderer_manifest_overlay.json
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/common/BUILD.gn
[add] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/common/content_settings_renderer.mojom
[delete] https://crrev.com/ba798aa6432235c3030cfc17db9fd8b0d83f2221/chrome/common/insecure_content_renderer.mojom
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/common/render_messages.h
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/renderer/content_settings_observer.h
[modify] https://crrev.com/379b785aca740242b5b2840c3a52a90fb2351be5/chrome/renderer/content_settings_observer_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment