Browser Actions should display a backup dialog to show all custom items if no provider is available.
The following revision refers to this bug: https://chromium.googlesource.com/custom-tabs-client/+/a0b6c6f7db4127c191ebb9ef008609224658edb2 commit a0b6c6f7db4127c191ebb9ef008609224658edb2 Author: Lei Tian <ltian@chromium.org> Date: Wed Dec 13 20:04:20 2017 Display backup dialog for Browser Actions is no provider is available If no Browser Actions provider is available, Browser Actions support library need to display a backup dialog which handles all custom items. The backup dialog tries to follow the UX guidance for Chrome context menu. Here shows what looks like: https://drive.google.com/a/google.com/file/d/1IuZcMmVRRrp9MmmKsm-0QgroAU_vmxGx/view?usp=sharing. Bug: 789806 Change-Id: I6b0de5616bc07f3464acba06c3ac812adc9f6e61 Reviewed-on: https://chromium-review.googlesource.com/798635 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> [modify] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/Application/src/main/java/org/chromium/customtabsclient/MainActivity.java [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/res/values/colors.xml [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuAdapter.java [modify] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/src/android/support/customtabs/browseractions/BrowserActionsIntent.java [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/res/layout/browser_actions_context_menu_row.xml [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuDialog.java [modify] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/Application/src/main/AndroidManifest.xml [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUi.java [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/res/layout/browser_actions_context_menu_page.xml [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/res/values/dimens.xml [add] https://crrev.com/a0b6c6f7db4127c191ebb9ef008609224658edb2/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuView.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f423fceefe4b957ff2ba8ed0860aa2b198baf8f8 commit f423fceefe4b957ff2ba8ed0860aa2b198baf8f8 Author: Lei Tian <ltian@chromium.org> Date: Thu Dec 21 01:24:26 2017 Sync the CCT change of displaying fallback dialog for Browser Actions Sync the CCT change of displaying fallback dialog for Browser Actions. Bug: 789806 Change-Id: I4ff6d4021e098036bcfdde150bbc1c53c19840ea Reviewed-on: https://chromium-review.googlesource.com/835279 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#525553} [modify] https://crrev.com/f423fceefe4b957ff2ba8ed0860aa2b198baf8f8/DEPS [modify] https://crrev.com/f423fceefe4b957ff2ba8ed0860aa2b198baf8f8/third_party/custom_tabs_client/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/custom-tabs-client/+/11160d765f0448083fc0ad7d2059c6d2ce3002b7 commit 11160d765f0448083fc0ad7d2059c6d2ce3002b7 Author: Lei Tian <ltian@chromium.org> Date: Wed Jan 31 18:17:05 2018 Sync Browser Actions changes on Android support lib Sync the latest changes of Browser Actions in Android support lib. Bug: 789806 Change-Id: Id452b801a2604b113a8f94774afa109bfb955c9e Reviewed-on: https://chromium-review.googlesource.com/894728 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/res/values/colors.xml [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuAdapter.java [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/src/android/support/customtabs/browseractions/BrowserActionsIntent.java [add] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/tests/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUiTest.java [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/res/layout/browser_actions_context_menu_row.xml [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/build.gradle [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuDialog.java [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/tests/src/android/support/customtabs/browseractions/BrowserActionsIntentTest.java [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuUi.java [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/res/layout/browser_actions_context_menu_page.xml [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/res/values/dimens.xml [modify] https://crrev.com/11160d765f0448083fc0ad7d2059c6d2ce3002b7/customtabs/src/android/support/customtabs/browseractions/BrowserActionsFallbackMenuView.java
Comment 1 by bugdroid1@chromium.org
, Dec 13 2017