New issue
Advanced search Search tips

Issue 789801 link

Starred by 1 user
Status: WontFix
Owner:
elawrence@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Investigate presubmit checks for HSTS preload list

Project Member Reported by elawrence@chromium.org, Nov 30 2017 
e.g.

"Is there an automated JSON syntax checker presubmit check? Other JSON data files in our tree have something like it; would be a good idea."

Comment 1 by marti...@chromium.org, Nov 30 2017 

transport_security_state_static.json is covered by the JSON syntax check in PRESUBMUT.py.

The TSS generator has more advanced checks for the file (duplicates, invalid entries, unused keys, ...) but only runs when you build //net. Not really presubmit but it prevents broken changes from going through the CQ.

Comment 2 by elawrence@chromium.org, Nov 30 2017 

Re #1: Thanks! I'd hoped this was the case.

Comment 3 by elawrence@chromium.org, Nov 30 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment