New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 789798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
(OOO slow)
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 776156



Sign in to add a comment

[TTS] Add a feature to force a second tap to not be suppressed

Project Member Reported by donnd@google.com, Nov 30 2017

Issue description

We'd like to experiment with a feature that overrides the Ranker suppression of a tap if it's considered a "second tap" -- a tap near a previous tap that was suppressed in both time and space.
 

Comment 1 by donnd@google.com, Nov 30 2017

Cc: twelling...@chromium.org hamelphi@chromium.org

Comment 2 by donnd@google.com, Nov 30 2017

Blocking: 776156
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a

commit 6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a
Author: Donn Denman <donnd@google.com>
Date: Fri Dec 01 00:13:09 2017

[TTS] Add a feature to force a second tap.

Adds a feature that prevents Ranker from suppressing a tap gesture
that's considered a "second tap"; a tap near a previously suppressed
tap in both time and space.

Adds the ability for a heuristic to override ML suppression.

Also removes the old TapSuppression heuristic (which had some Second
Tap logic that was moved into the new SecondTapMlOverride class).
Obsoleted two histograms and a user action that are not longer needed.

Added an enum for ResultsSeen when passed as a boolean that uses the
expected ordering of 0=not seen, 1=seen.

BUG= 789798 

Change-Id: I6c58508b65b06712c9013731affeda6bb2f5a1c3
Reviewed-on: https://chromium-review.googlesource.com/798757
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520765}
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapState.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
[add] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/SecondTapMlOverride.java
[delete] https://crrev.com/c8467809ff51db3a033b54bd6274e41dfa6ba965/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapSuppression.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapSuppressionHeuristics.java
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/android/java_sources.gni
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/tools/metrics/actions/actions.xml
[modify] https://crrev.com/6bd557ef855e8f0a82b82ae2a4ee1759b6b0257a/tools/metrics/histograms/histograms.xml

Comment 4 by donnd@google.com, Dec 1 2017

Status: Fixed (was: Started)

Sign in to add a comment