New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 789790 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Dec 2017
Cc:
█ hdodda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

disable print preview (GN) makes a build error

Reported by juanka85...@gmail.com, Nov 30 2017 
UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.118 Safari/537.36

Steps to reproduce the problem:
1. build chromium
2. disable print preview (via GN)
3. get the error

What is the expected behavior?
build it

What went wrong?
https://p.teknik.io/Mb2ot

Crashed report ID: 

How much crashed? Just one tab

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Chrome version: 64.0.3278.0  Channel: dev
OS Version: Archlinux
Flash Version:

Comment 1 by hdodda@chromium.org, Nov 30 2017

Cc: hdodda@chromium.org
Labels: Needs-Triage-M64 Needs-Feedback
Thanks for reporting the issue.

@ juanka85pichi-- Could you please try in a frehs chrome profile in latest canary without any extensions and flags enabled and if you can still reproduce the issue ...please provide us with the crash id from chrome://crashes .

Thanks!

Comment 2 by dtapu...@chromium.org, Dec 4 2017

Components: Internals>Printing
Labels: -Needs-Feedback

Comment 3 by thestig@chromium.org, Dec 4 2017

Labels: -Stability-Crash
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Will fix. Please note we don't actively test this build configuration, so please file bugs when it breaks.

Comment 4 by thestig@chromium.org, Dec 5 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/806447
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8669a54422a49c77503cfaf802eab890a436250d

commit 8669a54422a49c77503cfaf802eab890a436250d
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Dec 05 22:59:45 2017

Build PrinterManagerDialog whenever printing is enabled.

Originally, it was only used when Print Preview is enabled, but the
original user no longer exists, and the only user is the Settings page.
Transitively only build settings::PrintingHandler when printing is
enabled.

BUG= 789790 

Change-Id: I8e8b9d0df66b1a5ead01abeeaad78982f16e61ec
Reviewed-on: https://chromium-review.googlesource.com/806447
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521880}
[modify] https://crrev.com/8669a54422a49c77503cfaf802eab890a436250d/chrome/browser/BUILD.gn
[modify] https://crrev.com/8669a54422a49c77503cfaf802eab890a436250d/chrome/browser/printing/printer_manager_dialog.h
[modify] https://crrev.com/8669a54422a49c77503cfaf802eab890a436250d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8669a54422a49c77503cfaf802eab890a436250d/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/8669a54422a49c77503cfaf802eab890a436250d/chrome/browser/ui/webui/settings/printing_handler.h

Comment 6 by thestig@chromium.org, Dec 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment