New issue
Advanced search Search tips

Issue 789789 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 725683


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros SplitView - Maybe missing overview window after dragging spliter.

Project Member Reported by sammiequon@chromium.org, Nov 30 2017

Issue description

(1) Open a couple windows (2-3).
(2) Enter tablet mode, enter overview, snap a window left (or right).
(3) Use the divider to minimize the window.
(4) We are now in overview mode.

What is the expected result?
Can select the minimized window.

What happens instead?
Minimized window cannot be selected.


Android has the minimized window animate back into the overview mode.


 
> Android has the minimized window animate back into the overview mode.

Yep, that's the expected behavior.

Comment 2 by x...@chromium.org, Nov 30 2017

Cc: -sammiequon@chromium.org omrilio@chromium.org zork@chromium.org
Owner: sammiequon@chromium.org
Thanks for the clarification! Sammie, could you take this? Feel free to assign it back to me if you don't have time for this.

Comment 3 by x...@chromium.org, Nov 30 2017

Blocking: 725683
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5846a553c2f3241dc94a9a04d7bd8e15767cda

commit ac5846a553c2f3241dc94a9a04d7bd8e15767cda
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Dec 22 00:04:42 2017

splitview: Return snapped window to overview after closed by divider.

Previously if window snapped left or right, and then divider dragged to
and edge, the window will disappear (but still be open).

Test: ash_unittests SplitViewWindowSelectorTest.DividerDraggedToEdgeReturnsWindowToOverviewList
Bug:  789789 
Change-Id: Iaaef911132bd223b6b124c2cebc9e724bbc35542
Reviewed-on: https://chromium-review.googlesource.com/822371
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525866}
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_grid.h
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_selector.h
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_selector_controller.h
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ac5846a553c2f3241dc94a9a04d7bd8e15767cda/ash/wm/splitview/split_view_controller.cc

Status: Fixed (was: Assigned)
Status: Archived (was: Fixed)

Sign in to add a comment