New issue
Advanced search Search tips

Issue 789768 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 789774
issue 811404
issue 821943



Sign in to add a comment

Add a Xenial FYI bot

Project Member Reported by thomasanderson@chromium.org, Nov 30 2017

Issue description

Eventually, infrastructure will transition from using Trusty to Xenial, when Trusty reaches EOL.  To be prepared, we should add a Xenial builder now to catch any regressions.

Also, it would allow us to get better test coverage (eg. https://bugs.chromium.org/p/chromium/issues/detail?id=736452#c28) for systems with newer libraries/kernels.
 
Blockedon: 789774
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33aa9f138dbb914a52b5adbd2e2503362bcf5369

commit 33aa9f138dbb914a52b5adbd2e2503362bcf5369
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Feb 10 02:23:31 2018

Add Xenial builder (src changes)

BUG= 789768 
R=dpranke@chromium.org

Change-Id: Ic76ef362957eb017ac16f01cc53d04412c187373
Reviewed-on: https://chromium-review.googlesource.com/798631
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535937}
[modify] https://crrev.com/33aa9f138dbb914a52b5adbd2e2503362bcf5369/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/33aa9f138dbb914a52b5adbd2e2503362bcf5369/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/33aa9f138dbb914a52b5adbd2e2503362bcf5369/tools/mb/mb_config.pyl

Blockedon: 811404
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/301d22ac494b796b3be058ceeed7603b02c2df8d

commit 301d22ac494b796b3be058ceeed7603b02c2df8d
Author: Tom Anderson <thomasanderson@google.com>
Date: Tue Feb 13 23:52:48 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b860ecad247794f36735be49900cb01fca27e5ee

commit b860ecad247794f36735be49900cb01fca27e5ee
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Feb 14 01:37:43 2018

Whitelist rtld(GNU_HASH) dependency

This is needed to green-up the Linux Xenial bot [1].  rpmdeps has been updated
between Trusty and Xenial to require rtld(GNU_HASH) when the .gnu.hash section
is present in binaries.  We already ship binaries that have that section, and
glibc has supported GNU_HASH since version 2.4, so adding the new dependency
shouldn't be a problem on any systems.

[1] https://ci.chromium.org/buildbot/chromium.fyi/Linux%20Xenial/

R=thestig
BUG= 789768 

Change-Id: I4d8e669ff5d6c9fbe34c9570d8d9249d2b16456e
Reviewed-on: https://chromium-review.googlesource.com/917648
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536591}
[modify] https://crrev.com/b860ecad247794f36735be49900cb01fca27e5ee/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/b860ecad247794f36735be49900cb01fca27e5ee/chrome/installer/linux/rpm/update_package_provides.py

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 15 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb78d9cd12b4d009fd26fd0b65742a1c46f13cf8

commit cb78d9cd12b4d009fd26fd0b65742a1c46f13cf8
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Feb 15 01:50:21 2018

Add Linux Xenial to milo console

BUG= 789768 
R=dpranke

Change-Id: I425caffb6cb220975502b858bf7c1c15297e5025
Reviewed-on: https://chromium-review.googlesource.com/920301
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/cb78d9cd12b4d009fd26fd0b65742a1c46f13cf8/luci-milo-dev.cfg
[modify] https://crrev.com/cb78d9cd12b4d009fd26fd0b65742a1c46f13cf8/luci-milo.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cddd8cd08266eb66595ecf25083c5ce977113559

commit cddd8cd08266eb66595ecf25083c5ce977113559
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Feb 15 02:15:32 2018

Explicitly request 16.04 swarming bots for the Linux Xenial bot

There was a build step (site_per_process_webkit_layout_tests) on Linux Xenial
that for some reason was requesting Trusty swarming bots.  All of the other
steps were using Xenial bots.  This CL explicitly requests Xenial swarming bots
to fix this step.

BUG= 789768 
R=dpranke@chromium.org

Change-Id: Id9b33f0fd189f2286cf6dbb03cfd1553bafdf354
Reviewed-on: https://chromium-review.googlesource.com/920764
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536927}
[modify] https://crrev.com/cddd8cd08266eb66595ecf25083c5ce977113559/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/cddd8cd08266eb66595ecf25083c5ce977113559/testing/buildbot/waterfalls.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bfb0b04662d7cdb4a08240ac30024891aceef91

commit 8bfb0b04662d7cdb4a08240ac30024891aceef91
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Feb 17 00:44:15 2018

Add dbus-x11 to install-build-deps

dbus_unittests relies on the presence of /usr/bin/dbus-launch, which is provided
by the dbus-x11 package.  The absence of this package is currently causing
dbus_unittests to fail on the Linux Xenial bot.

BUG= 789768 
R=dpranke
NOTRY=true

Change-Id: Ic844648f3651e518e276c1fb764849b09145b34b
Reviewed-on: https://chromium-review.googlesource.com/924693
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537483}
[modify] https://crrev.com/8bfb0b04662d7cdb4a08240ac30024891aceef91/build/install-build-deps.sh

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae738bdaaf19a41b0a3f300d8c9fda35ad02a13d

commit ae738bdaaf19a41b0a3f300d8c9fda35ad02a13d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Feb 20 20:40:09 2018

Run telemetry_perf_unittests on Linux Xenial with xvfb

BUG= 789768 
R=dpranke

Change-Id: I4c31c8c2c2fefad5337dff51727cbfd9c58a89b4
Reviewed-on: https://chromium-review.googlesource.com/924391
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537869}
[modify] https://crrev.com/ae738bdaaf19a41b0a3f300d8c9fda35ad02a13d/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/ae738bdaaf19a41b0a3f300d8c9fda35ad02a13d/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378204c26f8a1a679a0bc0375c399e4fab7bb7af

commit 378204c26f8a1a679a0bc0375c399e4fab7bb7af
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 21 18:47:27 2018

Test removed from Network traffic annotation unittest.

Traffic annotation auditor unittests are updated not to check for clang
tool. This is done to make test available on swarming bots.
The test will be included in the end-to-end tests on the FYI bot.

Bug:  789768 
Bug:  690323 
Change-Id: I580ac0eee164efeb0347d890fe7dda5c5388f15c
Reviewed-on: https://chromium-review.googlesource.com/926125
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538164}
[modify] https://crrev.com/378204c26f8a1a679a0bc0375c399e4fab7bb7af/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/378204c26f8a1a679a0bc0375c399e4fab7bb7af/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/992e88e6e7d78bba6e40d0a82b78377778e923f7

commit 992e88e6e7d78bba6e40d0a82b78377778e923f7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Mar 06 23:16:06 2018

Remove annotations_xml_downstream_caller.py from build file

CL [1] deleted annotations_xml_downstream_caller.py, but there was still a
reference to it in the data list of traffic_annotation_auditor_unittests.  This
was causing isolate_tests to fail on Linux Xenial [2].

[1] https://chromium.googlesource.com/chromium/src/+/6fda5d5ea134a58d5f1053d649762b3896837827
[2] https://ci.chromium.org/buildbot/chromium.fyi/Linux%20Xenial/45

BUG= 789768 
TBR=rhalavati@chromium.org

Change-Id: I00b2d6d12092f1942b09aa657bae518678ec17de
Reviewed-on: https://chromium-review.googlesource.com/952030
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541233}
[modify] https://crrev.com/992e88e6e7d78bba6e40d0a82b78377778e923f7/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/992e88e6e7d78bba6e40d0a82b78377778e923f7/tools/traffic_annotation/scripts/README.md

Blockedon: 821943
Cc: atotic@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c30155dec73ecb559396ee3ad66da0e327d1f1a

commit 9c30155dec73ecb559396ee3ad66da0e327d1f1a
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Mar 23 01:13:44 2018

Fix bad-charset-alias on Ubuntu Xenial

This is a merge of r204850 from upstream WebKit.  It is necessary to fix
bad-charset-alias.html on Ubuntu Xenial.  In the new environment, there is no
global php.ini, so we need to create one to add a default setting for charset.

BUG= 789768 
R=tkent

Change-Id: I3de042f2656e9734e55a340d43dec64206c6423f
Reviewed-on: https://chromium-review.googlesource.com/973944
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545321}
[modify] https://crrev.com/9c30155dec73ecb559396ee3ad66da0e327d1f1a/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/9c30155dec73ecb559396ee3ad66da0e327d1f1a/third_party/WebKit/LayoutTests/http/conf/php.ini
[delete] https://crrev.com/b8f69bfd811f571fb552d8274ac1db445f0723df/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/bmp-partial-load-expected.png
[delete] https://crrev.com/b8f69bfd811f571fb552d8274ac1db445f0723df/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/gif-animated-partial-load-expected.png
[delete] https://crrev.com/b8f69bfd811f571fb552d8274ac1db445f0723df/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/webp-partial-load-expected.png
[delete] https://crrev.com/b8f69bfd811f571fb552d8274ac1db445f0723df/third_party/WebKit/LayoutTests/platform/mac-mac10.11/http/tests/misc/bad-charset-alias-expected.txt
[delete] https://crrev.com/b8f69bfd811f571fb552d8274ac1db445f0723df/third_party/WebKit/LayoutTests/platform/mac/http/tests/misc/bad-charset-alias-expected.txt
[modify] https://crrev.com/9c30155dec73ecb559396ee3ad66da0e327d1f1a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py

Status: Fixed (was: Started)
First green run of Linux Xenial:
https://ci.chromium.org/buildbot/chromium.fyi/Linux%20Xenial/177

atotic plmk if there are any layout test failures that remain for you

Sign in to add a comment