New issue
Advanced search Search tips

Issue 789760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

a script to build component automatically and upload

Project Member Reported by xiaochu@chromium.org, Nov 29 2017

Issue description

1. build&package
2. upload to repo automatically
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9785dfc173d7e89de234560efd22e34d176f57bc

commit 9785dfc173d7e89de234560efd22e34d176f57bc
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Wed Dec 06 02:00:44 2017

net-print/epson-inkjet-printer-escpr: add manifest.json

manifest.json file is necessary to build a component. We copy it to
/build/$BOARD/tmp and then later our script on buildbot can construct a
component out of it.

BUG= chromium:789760 
TEST=emerge-kefka epson-inkjet-printer-escpr

Change-Id: Ic3d99036d68b75a7ddcbe51a9ed33e8b836159f9
Reviewed-on: https://chromium-review.googlesource.com/806652
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9785dfc173d7e89de234560efd22e34d176f57bc/net-print/epson-inkjet-printer-escpr/epson-inkjet-printer-escpr-1.6.10.ebuild
[add] https://crrev.com/9785dfc173d7e89de234560efd22e34d176f57bc/net-print/epson-inkjet-printer-escpr/files/manifest.json
[rename] https://crrev.com/9785dfc173d7e89de234560efd22e34d176f57bc/net-print/epson-inkjet-printer-escpr/epson-inkjet-printer-escpr-1.6.10-r2.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f497669cd977b9d1b213ec6ae0a71f171cc7126f

commit f497669cd977b9d1b213ec6ae0a71f171cc7126f
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Wed Dec 06 04:22:41 2017

net-print/starcupsdrv: add manifest.json

manifest.json file is necessary to build a component. We copy it to
/build/$BOARD/build and then later our script on buildbot can construct a
component out of it.

BUG= chromium:789760 
TEST=emerge-kefka starcupsdrv

Change-Id: Idc2a2e20e4e3c004833b82cdc368a9966a1ac8b5
Reviewed-on: https://chromium-review.googlesource.com/809390
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f497669cd977b9d1b213ec6ae0a71f171cc7126f/net-print/starcupsdrv/starcupsdrv-3.6.0a_pre20170914.ebuild
[add] https://crrev.com/f497669cd977b9d1b213ec6ae0a71f171cc7126f/net-print/starcupsdrv/files/manifest.json
[add] https://crrev.com/f497669cd977b9d1b213ec6ae0a71f171cc7126f/net-print/starcupsdrv/starcupsdrv-3.6.0a_pre20170914-r1.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ff4b801401d22c0e9a05aefce42cd0084c4a8259

commit ff4b801401d22c0e9a05aefce42cd0084c4a8259
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Jan 11 20:02:14 2018

cros_component: script to build component

The scripts (build_component.py) parses cros_components.json to read
configurations for building all components. For each component to build,
it collect all required binary files, generate final manifest file,
create zip file and upload it to Omaha gs bucket.

BUG= chromium:789760 
TEST=./build_component_unittest.py and ./build_component.py

Change-Id: I005d605a2344fbb69f655b7e9e27929b129e86ca
Reviewed-on: https://chromium-review.googlesource.com/820047
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[add] https://crrev.com/ff4b801401d22c0e9a05aefce42cd0084c4a8259/cros_component/build_component.py
[add] https://crrev.com/ff4b801401d22c0e9a05aefce42cd0084c4a8259/cros_component/cros_components.json
[modify] https://crrev.com/ff4b801401d22c0e9a05aefce42cd0084c4a8259/cros_component/README.md
[add] https://crrev.com/ff4b801401d22c0e9a05aefce42cd0084c4a8259/cros_component/build_component_unittest.py
[modify] https://crrev.com/ff4b801401d22c0e9a05aefce42cd0084c4a8259/cros_component/cros_component.gyp
[delete] https://crrev.com/e94ae4488bad8d7b7fa2047f41920d8b0b254b21/cros_component/cros_component.config

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 13 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2c954ea5bf9187a968beace15a4b69601c0cb3de

commit 2c954ea5bf9187a968beace15a4b69601c0cb3de
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Fri Jan 26 03:23:58 2018

cros_component: Add FixPackageVersion function

1. Add FixPackageVersion function:
  Package name in ebuild is in the format of (X){1,3}-rN, we convert it
  to X.Y.Z-rN by padding 0 to Z (and Y).
  I add this function because a package like arc++ has version numbers
  (X)-rN which is not consistent with the rest of packages.
2. Fix a bug in DecideVersion.
3. Replace logging.fatal with cros_build_lib.Die.

BUG= chromium:789760 
TEST=./build_component.py
./build_component_unittest.py

Change-Id: If82ea22bb496a4c1394a33f21623cbd28e8fc964
Reviewed-on: https://chromium-review.googlesource.com/868397
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[modify] https://crrev.com/2c954ea5bf9187a968beace15a4b69601c0cb3de/cros_component/build_component.py
[modify] https://crrev.com/2c954ea5bf9187a968beace15a4b69601c0cb3de/cros_component/build_component_unittest.py

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2f0f4cd8c27692693b4963e8d50dc3424bc8d9e8

commit 2f0f4cd8c27692693b4963e8d50dc3424bc8d9e8
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Jan 30 22:54:23 2018

cros_component: support override gsbucket argument

This CL adds 'gsbucket' argument to build_component script. It overrides
the gsbucket field in config json file.

I add this optional argument for easy testing using a non-prod gsbucket.
Also I plan to use a non-prod gsbucket when we start setup the
component builders to test things out. After it is tested and stable, we
can switch to prod gsbucket by simply avoiding using this parameter.

Also fix a bug in GetCurrentPackageVersion which does not handle None
value.

BUG= chromium:789760 
TEST=./build_component.py --gsbucket=... --upload,
./build_component_unittest.py

Change-Id: Iea98ec9f62c0a272fd386cb05a358d33adaa0947
Reviewed-on: https://chromium-review.googlesource.com/891990
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[modify] https://crrev.com/2f0f4cd8c27692693b4963e8d50dc3424bc8d9e8/cros_component/build_component.py
[modify] https://crrev.com/2f0f4cd8c27692693b4963e8d50dc3424bc8d9e8/cros_component/build_component_unittest.py

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/63f9a39989d3e97c2774180fd86788200f37ee9d

commit 63f9a39989d3e97c2774180fd86788200f37ee9d
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Thu Feb 01 02:01:04 2018

cros_component: mark 4 args non-optional

This CL marks 4 args non-optional. This helps cli users understand the
usage of the script. A simple run of ./build_component.py will print
usage along with parameters missing.

BUG= chromium:789760 
TEST=./build_component.py prints usage along with a missing parameter
error.

Change-Id: Ib7f95a79c0d2fb785db1397abd316d52116f801c
Reviewed-on: https://chromium-review.googlesource.com/894163
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/63f9a39989d3e97c2774180fd86788200f37ee9d/cros_component/build_component.py

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/335a9a089307dc72a6e4f235a6e88fc960f3e458

commit 335a9a089307dc72a6e4f235a6e88fc960f3e458
Author: Nicolas Norvez <norvez@chromium.org>
Date: Fri Feb 02 15:03:19 2018

cros_component: style nits

Change the style of strings and line length split to match the style
guide more closely.
https://google.github.io/styleguide/pyguide.html?showone=Line_length#Line_length

BUG= chromium:789760 
TEST=./build_component.py -h
TEST=./build_component_unittest.py
TEST=cros lint build_component.py

Change-Id: I6e878569157c20bbf947ff84a6b26c4db767ebbd
Reviewed-on: https://chromium-review.googlesource.com/896865
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/335a9a089307dc72a6e4f235a6e88fc960f3e458/cros_component/build_component.py

Status: Fixed (was: Untriaged)
Summary: a script to build component automatically and upload (was: automatic component release )
Description: Show this description

Sign in to add a comment